Layne Penney
55e40c87b9
Cleanup: Remove superfluous generics.
5 months ago
Layne Penney
11ee5549f2
Enhance: Enforce consistent formatting in `build-logic` with Spotless plugin
...
This commit runs the Spotless plugin on `build-logic` to ensure that all code adheres to our style guidelines. As a follow-up to the recent flavor configuration refactor, this cleanup reinforces our commitment to a robust, readable, and maintainable codebase without altering functionality.
5 months ago
Layne Penney
bcdd99efde
Enhance: Bind extension to product flavor for robust type safety
...
This commit refactors flavor configuration in NiaFlavor.kt. The previous implementation relied on runtime type checks for ApplicationExtension and ApplicationProductFlavor, whereas the updated code leverages generics to explicitly bind the extension (E) to the product flavor (F). This change eliminates unnecessary runtime checks and enhances compile-time type safety. Additionally, the introduction of @JvmName(“configureFlavorsImpl”) resolves JVM signature clashes, streamlining our DSL and improving overall code clarity.
5 months ago
Alex Vanyo
689ef92e41
Merge pull request #1850 from ogapants/patch-1
...
Replace org.junit.Assert.assertEquals with kotlin.test.assertEquals for consistency
5 months ago
Alex Vanyo
476baff45f
Merge pull request #1855 from SimonMarquis/deprecated-centerAlignedTopAppBarColors
...
Replace deprecated `centerAlignedTopAppBarColors` with `topAppBarColors`
5 months ago
Ben Weiss
425ddf6a69
Remove death penalty from strict mode violations ( #1857 )
...
The app was still crashing in non-debug after strict mode was enabled. Less restrictive, now only logging violations
Closes #1853
Closes #1809
5 months ago
Simon Marquis
fe4ebce324
Replace deprecated `centerAlignedTopAppBarColors` with `topAppBarColors`
...
from a recent material3 update: https://developer.android.com/jetpack/androidx/releases/compose-material3#1.4.0-alpha06
5 months ago
Alex Vanyo
25d80b4598
Merge pull request #1851 from liutikas/benchmark
...
Upgrade to benchmark 1.3.4
5 months ago
Aurimas Liutikas
8bc0ad7b13
Upgrade to benchmark 1.3.4
...
It picks up Gradle Isolated Project fixes
Test: ./gradlew build --dry-run -Dorg.gradle.unsafe.isolated-projects=true
fewer warnings after the PR
5 months ago
ogapants
ef4b2eaddd
Replace org.junit.Assert.assertEquals with kotlin.test.assertEquals for consistency
5 months ago
Alex Vanyo
e29cff2aa4
Merge pull request #1846 from liutikas/dagger
...
Upgrade to the newest version of dagger/hilt
6 months ago
Aurimas Liutikas
19f0358550
Upgrade to the newest version of dagger/hilt
...
This brings in a fix for Gradle Isolated Projects
https://github.com/google/dagger/issues/4423
Thus helping to make progress on https://github.com/android/nowinandroid/issues/1842
6 months ago
Alex Vanyo
a9dc11f025
Merge pull request #1844 from liutikas/gradlebump
...
Upgrade AGP and Gradle
6 months ago
Aurimas Liutikas
4272acee20
Upgrade AGP and Gradle
...
- Upgrade to Gradle 8.13 ./gradlew wrapper --gradle-version 8.13
- Add checksum to make sure valid distribution is used
- Upgrade AGP to 8.9.0
6 months ago
Alex Vanyo
fe14327910
Merge pull request #1841 from liutikas/ksp-kotlin-upgrade
...
Upgrade Kotlin to 2.1.10, KSP to 2.1.10-1.0.31
6 months ago
Alex Vanyo
896b33120a
Merge pull request #1840 from liutikas/warniningsproperty
...
Remove Gradle Isolated Project violation
6 months ago
Aurimas Liutikas
e0e43c92a2
Upgrade Kotlin to 2.1.10, KSP to 2.1.10-1.0.31
6 months ago
Aurimas Liutikas
aa565cba5f
Remove Gradle Isolated Project violation
...
Calls to Project.properties is not Gradle Isolated Projects safe as it
causes Gradle to look through parent projects to find these. Move to
using providers.gradleProperty as that does not have the same behavior.
Test: ./gradlew build --dry-run -Dorg.gradle.unsafe.isolated-projects=true
fewer warnings after the PR
6 months ago
Alex Vanyo
af33aca699
Merge pull request #1835 from android/av/material3-adaptive-1.1
...
Update to material3-adaptive 1.1
6 months ago
Alex Vanyo
fc418fc7a5
Rename highlightSelectedTopic to shouldHighlightSelectedTopic
...
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
6 months ago
Alex Vanyo
77c0d6c500
Rename to topicRoute
...
Change-Id: I44696efe11f8d660bb7c9dc41ade6927ce15798b
6 months ago
Alex Vanyo
502c719603
Update TopicViewModelTest
...
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
6 months ago
alexvanyo
af98b39223
🤖 Updates screenshots
6 months ago
alexvanyo
ce85daa8e8
🤖 Updates baselines for Dependency Guard
6 months ago
Alex Vanyo
e25b3634ca
Add predictive back and pane expansion back handling
...
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
6 months ago
Alex Vanyo
800e3d55c9
Assisted inject approach
...
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
6 months ago
alexvanyo
ed8745cef5
🤖 Updates screenshots
6 months ago
alexvanyo
aeaa525333
🤖 Updates baselines for Dependency Guard
6 months ago
Alex Vanyo
f3cf2379a3
Update to material3-adaptive 1.1
...
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
6 months ago
Don Turner
e308246131
Merge pull request #1697 from Jaehwa-Noh/fix-snackbar
...
Fix snackbar was covered by System navigation bar.
7 months ago
Jaehwa Noh
104f2a04ff
Merge pull request #18 from Jaehwa-Noh/fix-snackbar-take-a-screenshot
...
Take new screenshots.
7 months ago
Jaehwa-Noh
46b37a3e7f
🤖 Updates screenshots
7 months ago
Jaehwa Noh
01e428bba4
Remove old screenshots.
...
Change-Id: Ib1181a3f9f6cf364794766b70b990f8616edd118
7 months ago
Jaehwa Noh
aa18b8b711
Merge branch 'android-remote-main' into fix-snackbar
...
Change-Id: If0f12500cb55daae98fd7ee0951d3d3384d26b0e
# Conflicts:
# app/src/testDemo/screenshots/insets_snackbar_compact_medium.png
# app/src/testDemo/screenshots/insets_snackbar_expanded_expanded.png
# app/src/testDemo/screenshots/insets_snackbar_medium_medium.png
7 months ago
Don Turner
a0f2786634
Merge pull request #1770 from android/revert-1752-feature/adding-baseline-and-startup-profile-to-the-codebase-in-nightly-builds
...
Revert "Feature / Added baseline and startup profile generation"
8 months ago
Ben Weiss
6c931b1e11
Revert "Feature / Added baseline and startup profile generation ( #1752 )"
...
This reverts commit 8f196e18a7
.
8 months ago
Don Turner
d35dc6cba8
Merge pull request #1799 from eyhgpt/patch-1
...
Update OfflineFirstNewsRepositoryTest.kt
8 months ago
Roberto Orgiu
dc7dd3fefd
Merge pull request #1702 from tiwiz/update-drag-and-drop
...
Simplify Drag&Drop implementation
8 months ago
Don Turner
ef0d89e9fb
Update core/data/src/test/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
8 months ago
Rob Orgiu
7770f83fa5
Updates dependencies baseline
8 months ago
Rob Orgiu
82e4e7c65e
Reformat androidxComposeFoundation in alphabetical order
8 months ago
E Y H
fa532089e2
Update OfflineFirstNewsRepositoryTest.kt
...
Remove the comments. A similar comment wasn't accpeted in my last PR.
8 months ago
EYH GPT
798b941b75
Update OfflineFirstNewsRepositoryTest.kt
...
Improve the unit test to perform meaningful comparisons instead of merely comparing two empty lists.
8 months ago
Rob Orgiu
4885e92ba5
Reformat NewsResourceCard
8 months ago
Rob Orgiu
31c4f05872
Simplify Drag&Drop implementation
8 months ago
Don Turner
904e6fccee
Merge pull request #1730 from seve-andre/force-dark-opt-out
...
Opt out of Force Dark mode
8 months ago
Rob Orgiu
8f75786c88
Merge remote-tracking branch 'refs/remotes/origin/main' into update-drag-and-drop
...
# Conflicts:
# gradle/libs.versions.toml
8 months ago
Don Turner
87c1f11dc3
Merge pull request #1786 from tobioyelekan/add-topicdao-test
...
Add topicdao test
8 months ago
Don Turner
c6588b0e5c
Merge pull request #1798 from eyhgpt/patch-1
...
Update OfflineFirstTopicsRepositoryTest.kt
8 months ago
Don Turner
21c14ef6a1
Merge pull request #1784 from Jaehwa-Noh/kotlin-dsl-withou-type-safe-plugin
...
Follow kotlin dsl without type-safe documentation on plugins
8 months ago