b6d82e24df
Merge branch 'main' into kotlinify
9 months ago
56fbe13b5a
Ignore function naming check when annotated with @Test
9 months ago
485440b550
Suppress ktlint:standard:function-naming in ResultKtTest
9 months ago
d671126f9e
Move @Suppress("ktlint:standard:max-line-length") to function scope
9 months ago
32e1ec0447
Remove violations: property-naming
9 months ago
f8f932705a
Remove violations: discouraged-comment-location
9 months ago
fb5bd225be
Spotless
9 months ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
9 months ago
e8f4537e7c
Update thumbTrackSizePercent calculation for readability
...
Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d
9 months ago
07d9877331
Update thumb movement range by thumb size, in app scrollbars
...
Change-Id: I4438debd5037965a837758e0c78b110ab8197da5
9 months ago
e62d70bf5a
Merge pull request #1067 from android/ben/itemstate
...
Remove redundant mutable state in NewsFeed
9 months ago
e334a727c3
Fix typo in app scrollbars
...
Change-Id: Ie72f1410fa8e5a68a520321c34d4fad251016486
9 months ago
3142ecb495
Remove redundant mutable state
9 months ago
22df321b9e
Apply spotless
10 months ago
72da8e2e56
Use custom Modifier.Node instead of background
10 months ago
d8880e98f0
Move state into a state holder and remove redundant Box
10 months ago
01928d7df5
Move scrollbar changes out of composition
10 months ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
10 months ago
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
10 months ago
cf2d445362
Move Android instrumented test `ThemeTest` to unit test
10 months ago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
10 months ago
b2c1c11218
Update MainDispatcherRule.kt
...
Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.
10 months ago
78573b8efc
Merge pull request #972 from tjmtic/now-update-888
...
Update primitive mutable states to mutableState API where applicable
11 months ago
5482d81fdc
fixed for PR 985
11 months ago
2b84fafcf7
Merge remote-tracking branch 'upstream/main' into now-update-888
11 months ago
245723b5b2
Fix compiler warning: Remove single lambda parameter declaration
11 months ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
11 months ago
7fc67c2915
Update compose-runtime version; Update primitive mutable states to mutableState API where applicable
11 months ago
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
11 months ago
301661ce86
Merge pull request #959 from McGalanes/convention-plugins-toml
...
Add convention plugins to version catalogs
11 months ago
1d0435832d
Fix spotless
...
Change-Id: Ia931fc5662af50a6045a51783d72cb5b68e2486a
12 months ago
beaa85739d
Address PR feedback
...
Change-Id: I50b49d3e216535e384b64849f915b37f6e2acbbc
12 months ago
6e96d30519
Merge pull request #912 from lihenggui/main
...
Upgrade Gradle to v8.3
12 months ago
5612396290
Fit typo in SystemTrayNotifier.kt
12 months ago
6247712064
Add convention plugins to version catalogs
12 months ago
b1266dc05a
Use typesafe project accessors for project modules
12 months ago
77451779cd
Use animateItemPlacement() on feed
...
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
12 months ago
8b759ae569
Fix spotless
...
Change-Id: I7ee8bc84beb38d00983aa7b0da3f3073e1249992
12 months ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
12 months ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
12 months ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
1 year ago
d0909a9c8f
Merge pull request #925 from SimonMarquis/remove-dispatcher
...
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
1 year ago
0ddcf0b4ab
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
...
As mentioned in the following discussion: https://github.com/android/nowinandroid/discussions/818
Room already takes care of switching dispatchers if the DAO method is correctly annotated with the `suspend` modifier.
1 year ago
298f3ce4db
Merge branch 'android:main' into main
1 year ago
c98e6236d5
Replace identical `InstantSerializer` with KotlinX datetime default serializer
1 year ago
5b79869324
Adds dark screenshot tests and fixes background colors in ForYou ( #918 )
...
* Adds dark screenshot tests and fixes background colors in ForYou
* 🤖 Updates screenshots
1 year ago
4e6cda1965
Renamed toggle function signature with boolean parameters
...
Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b
1 year ago
c57fb78fa7
Merge pull request #759 from SimonMarquis/lint/sarif
...
Android Lint improvements
1 year ago
886158d3cb
Adds Screenshot testing with Roborazzi ( #876 )
...
* Adds screenshot tests using Roborazzi (Robolectric Native Graphics)
- Adds Roborazzi to convention plugins
- Adds Screenshot helper in :core-testing
- Creates screenshot suites for :app and :feature-foryou
* CI and spotless
* Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier
* CI: Moves local tests to their own step
* CI: Adds --rerun to screenshot task
* CI: Moves screenshots before local tests
* CI: Fixes wrong if statement in workflow
* CI WIP: trying to trigger the push step
* CI: Re-enables roborazzi verification
* Fixes flaky screenshot tests by setting LocalInspectionMode on
* CI: screenshot commits now use the original author intead of bot account
* CI: Disables globbing because file_pattern didn't work
* CI: Trying new file pattern for png files
* CI: Adds a check for forks
* 🤖 Updates screenshots
* Code review: toml cleanup, comments
* Use new github.event.pull_request.head.repo.fork
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Uses Robolectric qualifiers to set the dpi, adds section to README
* Spotless
* Delegates creation of repository to Hilt in test
* Revert "Use new github.event.pull_request.head.repo.fork"
* 🤖 Updates screenshots
* Empty commit to trigger GHA on main branch
* Makes time zones deterministic in screenshot tests
* Increases GMD timeout to 90m, but it has to be reduced
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
1 year ago
fcc49d141d
Upgrade Gradle to v8.3
1 year ago
928833fe5d
Merge pull request #889 from RivanParmar/main
...
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
1 year ago
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
1 year ago
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
1 year ago
f1bc6f1226
Restore `Unknown` type as empty `String`
1 year ago
c831dc673c
Fix broken text
1 year ago
daa2228132
Restore original `type` labels
1 year ago
480d8e7d7c
Fix missing removal
1 year ago
553b01fcb6
spotlessApply
1 year ago
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
1 year ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
1 year ago
9e1d46e28c
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
1 year ago
5d7e33d905
fix formatting
1 year ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
1 year ago
0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
...
Replace StringDecoder injection with simpler API
1 year ago
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
1 year ago
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
1 year ago
4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
...
Rename constants
1 year ago
a23ffab602
fix: add label to animations for fixing lint issue
1 year ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
1 year ago
4eeb045287
Rename constants
1 year ago
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
1 year ago
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
1 year ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
1 year ago
5bbcc904e9
feat: make painter in one line
1 year ago
3595d8dcb5
feat: move the placeholder default value to the method
1 year ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
1 year ago
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
1 year ago
e276212574
feat: remove check if placeholder null and put a default placeholder if its not passed.
1 year ago
9c1ec17a39
fix: modifier to Modifier
1 year ago
57025e7587
fix: review notes
1 year ago
8a197800c5
feat: fix format issue
1 year ago
f4859e0bcd
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
06e91fd623
Merge branch 'android:main' into loading-progress-for-image
1 year ago
a294adb6b9
feat: fix format issue
1 year ago
48041fcaa4
Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity
...
Call getNewsResourceIds instead of getNewsResources
1 year ago
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
42b16bf7be
Merge remote-tracking branch 'origin/main'
1 year ago
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
9babb50c58
Interact with scrollbar only if drag direction matches scrollbar orientation
...
Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f
1 year ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
1 year ago
806726a7f0
PR feedback
...
Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18
1 year ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
1 year ago
2dba522663
Check if first item size == 0
...
Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf
1 year ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
1 year ago
ce6eaa9d64
Fix spotless
1 year ago
4858167b24
Added clarifying comments to code and used better variable names
1 year ago
bda31e9d15
Default scrollbars to dormant
1 year ago
d6a265093d
Extract scrollbar values to constants
1 year ago
795c5e32a9
Add hoverable to scrollbar
1 year ago
31b4841cb2
Add scrollbars to app
1 year ago
56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
...
Kotlin 1.9.0
1 year ago
f7ed38182d
Add protobuf generated sources to the sourceSets
...
And update to version 3.23.4.
1 year ago
b570be2abb
reformat by spotless
1 year ago
e9a16e437d
add kdoc for getNewsResourceIds
1 year ago
805914dade
Call getNewsResourceIds instead of getNewsResources
1 year ago
7b6c3a16ca
Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format
...
Allow localised date format
1 year ago
b2a74ba174
Merge pull request #812 from Askeri-Muhendis/main
...
Kotlin Coding conventions
1 year ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
1 year ago
3114b2eeaa
Allow localised date format
1 year ago
d136965a0d
Merge branch 'main' into lint/sarif
1 year ago
6271d1c4c0
Merge branch 'android:main' into main
1 year ago
56f8a27132
Kotlin coding conventions places companion object at the bottom of the class
1 year ago
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
1 year ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
1 year ago
8e708cca05
Merge branch 'main' into lint/sarif
1 year ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
1 year ago
890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
...
Keep track of matching `Network`s inside `NetworkCallback`
1 year ago
27154ef38a
Apply changes from review comments
1 year ago
479a2f00b0
Refactor icons
1 year ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
1 year ago
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
1 year ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
1 year ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
1 year ago
9aba5cc0fe
Cleanup unused string resources
1 year ago
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
1 year ago
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
1 year ago
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
1 year ago
b245334a18
Updating TestDataStoreModule to use ApplicationScope
1 year ago
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
1 year ago
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
1 year ago
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
1 year ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
1 year ago
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
1 year ago
bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
...
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
1 year ago
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
1 year ago
e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
...
Configure jvmToolchain for Android and Kotlin projects
1 year ago
ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
...
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
1 year ago
a4eab289df
Merge pull request #719 from android/add-search-analytics
...
Add analytics for search queries
1 year ago
2f2dfb00a4
Mark all news resources read on first sync
...
Otherwise, there will be unread articles until the user clicks through
every article that has ever been published.
1 year ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
1 year ago
ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
7819a0c6bc
Extract common code to update the Flow value
1 year ago
Simon Marquis
lihenggui
Yuya
Ben Trengrove
dahunsi
Ben Trengrove
Daniel Santiago
Mario Manhique
Adetunji Dahunsi
Jonathan Koren
TM
Don Turner
Minseong Kim
Melwin Magalhaes
Simon Marquis
Jose Alcérreca
Roy Matero
Roy Matero
Milosz Moczkowski
RivanParmar
qamarelsafadi
Qamar A. Safadi
AlirezaJoon
Tatsuya Fujisaki
prosixe
TJ Dahunsi
Márton Braun
blackbracken
ahmedmadhoun1
İbrahim Ethem Şen
İbrahim Ethem Şen
Tomáš Mlynarič
James Rose
Don Turner
Neelansh Sahai
Alex Vanyo