Miłosz Moczkowski
3a030c82ba
Simplify Adaptive Scaffold
...
Change-Id: I2775e308de426395d92a2ffd3673f7e4f41f82ca
2 years ago
Miłosz Moczkowski
2b828655d8
Fix NavigationUiTest
...
Change-Id: Ied714177a358fd8e908a392f56aeea18d4f7854a
2 years ago
Miłosz Moczkowski
3368c7d34e
Drawer scaffold improvements
...
Change-Id: Ifb61bb8b016a2edd466f1f3d6f881a3b2800f26b
2 years ago
Miłosz Moczkowski
e6c0176bfd
Fix bottom bar scaffold navigation
...
Change-Id: I5ca88c5d99f20daf4299ab13b3454990c4d9fc1d
2 years ago
Miłosz Moczkowski
7cc7702c92
Fix drawer scaffold
...
Change-Id: I553abedf0690f89fdcd552e04364e4b598d8998c
2 years ago
Miłosz Moczkowski
d91c1f44a3
Improvements
...
Change-Id: I365c759f8c4664ea07ed99cc06f77fec6bba3833
2 years ago
Miłosz Moczkowski
20cc98fde7
Remove unused imports
...
Change-Id: I0466cff3946061d35428496ca99c40da5ac49a08
2 years ago
Miłosz Moczkowski
0cd61134e1
Add details pane support to AdaptiveScaffold
...
Change-Id: I68ff2584ec0c5be2209c21d1bec9b71acad6f42d
2 years ago
Tomáš Mlynarič
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
Tomáš Mlynarič
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
2 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
gururani-abhishek
f6bdba08d9
added comment to document what happens on tapping news resource card.
2 years ago
gururani-abhishek
bbc80bb0e2
added back launchCustomChromeTab()
2 years ago
gururani-abhishek
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
Takeshi Hagikura
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
James Rose
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
Milosz Moczkowski
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
2 years ago
Milosz Moczkowski
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago
Milosz Moczkowski
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
3 years ago
Chris Sinco
93c01ad184
Fix trailing commas based on spotless check
3 years ago
Chris Sinco
049750dd51
Merge branch 'main' into ui-polish
3 years ago
James Rose
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
3 years ago
Simon Marquis
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
3 years ago
James Rose
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
3 years ago
James Rose
9ee2acf327
Add viewed status for news resources to data layer
3 years ago
Keisuke Takagi
072364e7f1
remove newsResourceTitle
3 years ago
Keisuke Takagi
8b51107d7a
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
3 years ago
Don Turner
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
3 years ago
Márton Braun
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
3 years ago
Don Turner
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
3 years ago
Keisuke Takagi
9091abf09e
Provide true to LocalInspectionMode
3 years ago
Miłosz Moczkowski
bcb4d7d592
Replace global variables with PreviewParameterProvider
3 years ago
Márton Braun
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
3 years ago
Don Turner
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
3 years ago
magicalmeghan
45e3cfd989
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
3 years ago
magicalmeghan
de6a4ec6c7
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
3 years ago
magicalmeghan
5137cd7777
removed hardcoded strings
3 years ago
Don Turner
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
3 years ago
magicalmeghan
66046a86b0
Updated NewsResourceCardTest
3 years ago
Don Turner
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
3 years ago
Don Turner
99227b06b5
Spotless
3 years ago
Don Turner
32bc5c1590
Fix merge conflicts
3 years ago
magicalmeghan
ffb5aeba86
Added third draft of tests
3 years ago
magicalmeghan
8089866079
Added second draft of tests
3 years ago
Chris Sinco
2f454de21c
Spacing polish based on design spec
3 years ago
Don Turner
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
3 years ago
Don Turner
cf053ade5a
Fix build warnings
3 years ago
magicalmeghan
9a900f9900
Added first draft of tests
3 years ago
magicalmeghan
a8f55d9d38
Renamed SaveableNewsResource to UserNewsResource
3 years ago