Merge pull request #499 from anasshamsi97/main

Typo fix for search & Remove the redundant "interests" prefix
pull/504/head
Alex Vanyo 2 years ago committed by GitHub
commit f0f2dbff64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -52,12 +52,12 @@ class InterestsScreenTest {
@Before @Before
fun setup() { fun setup() {
composeTestRule.activity.apply { composeTestRule.activity.apply {
interestsLoading = getString(R.string.interests_loading) interestsLoading = getString(R.string.loading)
interestsEmptyHeader = getString(R.string.interests_empty_header) interestsEmptyHeader = getString(R.string.empty_header)
interestsTopicCardFollowButton = interestsTopicCardFollowButton =
getString(R.string.interests_card_follow_button_content_desc) getString(R.string.card_follow_button_content_desc)
interestsTopicCardUnfollowButton = interestsTopicCardUnfollowButton =
getString(R.string.interests_card_unfollow_button_content_desc) getString(R.string.card_unfollow_button_content_desc)
} }
} }

@ -76,7 +76,7 @@ fun InterestsItem(
Icon( Icon(
imageVector = NiaIcons.Add, imageVector = NiaIcons.Add,
contentDescription = stringResource( contentDescription = stringResource(
id = string.interests_card_follow_button_content_desc id = string.card_follow_button_content_desc
) )
) )
}, },
@ -84,7 +84,7 @@ fun InterestsItem(
Icon( Icon(
imageVector = NiaIcons.Check, imageVector = NiaIcons.Check,
contentDescription = stringResource( contentDescription = stringResource(
id = string.interests_card_unfollow_button_content_desc id = string.card_unfollow_button_content_desc
) )
) )
} }

@ -65,7 +65,7 @@ internal fun InterestsScreen(
InterestsUiState.Loading -> InterestsUiState.Loading ->
NiaLoadingWheel( NiaLoadingWheel(
modifier = modifier, modifier = modifier,
contentDesc = stringResource(id = R.string.interests_loading), contentDesc = stringResource(id = R.string.loading),
) )
is InterestsUiState.Interests -> is InterestsUiState.Interests ->
TopicsTabContent( TopicsTabContent(
@ -81,7 +81,7 @@ internal fun InterestsScreen(
@Composable @Composable
private fun InterestsEmptyScreen() { private fun InterestsEmptyScreen() {
Text(text = stringResource(id = R.string.interests_empty_header)) Text(text = stringResource(id = R.string.empty_header))
} }
@DevicePreviews @DevicePreviews

@ -15,13 +15,12 @@
limitations under the License. limitations under the License.
--> -->
<resources> <resources>
<!-- TODO: Remove the redundant "interests" prefix -->
<string name="interests">Interests</string> <string name="interests">Interests</string>
<string name="interests_loading">Loading data</string> <string name="loading">Loading data</string>
<string name="interests_empty_header">"No available data"</string> <string name="empty_header">"No available data"</string>
<string name="interests_card_follow_button_content_desc">Follow interest button</string> <string name="card_follow_button_content_desc">Follow interest button</string>
<string name="interests_card_unfollow_button_content_desc">Unfollow interest button</string> <string name="card_unfollow_button_content_desc">Unfollow interest button</string>
<string name="interests_top_app_bar_title">Interests</string> <string name="top_app_bar_title">Interests</string>
<string name="interests_top_app_bar_action_menu">Menu</string> <string name="top_app_bar_action_menu">Menu</string>
<string name="interests_top_app_bar_action_seearch">Search</string> <string name="top_app_bar_action_search">Search</string>
</resources> </resources>

Loading…
Cancel
Save