Remove applicationIdSuffix from demo variant, add it to prod instead

Change-Id: I890beefbd79de04a9f5fa1153eb8b1ab3ee6eaf4

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Flavor.kt

@@ -14,8 +14,8 @@ enum class FlavorDimension {
 // purposes, or from a production backend server which supplies up-to-date, real content.
 // These two product flavors reflect this behaviour.
 enum class Flavor (val dimension : FlavorDimension, val applicationIdSuffix : String? = null) {
-    demo(FlavorDimension.contentType, ".demo"),
-    prod(FlavorDimension.contentType)
+    demo(FlavorDimension.contentType),
+    prod(FlavorDimension.contentType, ".prod")
 }
 
 fun Project.configureFlavors(