Merge pull request #600 from takagimeow/cleanup-unused-args

Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
pull/1837/head
Milosz Moczkowski 2 years ago committed by GitHub
commit dd3c6827d2

@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) {
) )
} }
fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) { fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) {
logEvent( logEvent(
event = AnalyticsEvent( event = AnalyticsEvent(
type = "news_resource_opened", type = "news_resource_opened",

@ -69,7 +69,6 @@ fun LazyGridScope.newsFeed(
onClick = { onClick = {
analyticsHelper.logNewsResourceOpened( analyticsHelper.logNewsResourceOpened(
newsResourceId = userNewsResource.id, newsResourceId = userNewsResource.id,
newsResourceTitle = userNewsResource.title,
) )
launchCustomChromeTab(context, resourceUrl, backgroundColor) launchCustomChromeTab(context, resourceUrl, backgroundColor)
}, },

@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems(
onClick = { onClick = {
analyticsHelper.logNewsResourceOpened( analyticsHelper.logNewsResourceOpened(
newsResourceId = userNewsResource.id, newsResourceId = userNewsResource.id,
newsResourceTitle = userNewsResource.title,
) )
when (onItemClick) { when (onItemClick) {
null -> launchCustomChromeTab(context, resourceUrl, backgroundColor) null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)

Loading…
Cancel
Save