Remove Scaffolds from previews

Change-Id: I0773e9016a1628c5ad95a139e28b192a8bce6dc0
pull/72/head
Jolanda Verhoef 3 years ago
parent 63250d42d1
commit ccc2776e5e

@ -34,11 +34,9 @@ import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.foundation.shape.CircleShape import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.icons.Icons.Filled import androidx.compose.material.icons.Icons.Filled
import androidx.compose.material.icons.filled.ArrowBack import androidx.compose.material.icons.filled.ArrowBack
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState import androidx.compose.runtime.collectAsState
@ -46,7 +44,6 @@ import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.layout.ContentScale import androidx.compose.ui.layout.ContentScale
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
@ -232,7 +229,6 @@ private fun AuthorToolbar(
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -241,23 +237,16 @@ private fun AuthorToolbar(
fun AuthorScreenPopulated() { fun AuthorScreenPopulated() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( AuthorScreen(
containerColor = Color.Transparent, authorState = AuthorUiState.Success(FollowableAuthor(previewAuthors[0], false)),
contentColor = MaterialTheme.colorScheme.onBackground, newsState = NewsUiState.Success(previewNewsResources),
) { padding -> onBackClick = {},
AuthorScreen( onFollowClick = {}
authorState = AuthorUiState.Success(FollowableAuthor(previewAuthors[0], false)), )
newsState = NewsUiState.Success(previewNewsResources),
onBackClick = {},
onFollowClick = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -266,18 +255,12 @@ fun AuthorScreenPopulated() {
fun AuthorScreenLoading() { fun AuthorScreenLoading() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( AuthorScreen(
containerColor = Color.Transparent, authorState = AuthorUiState.Loading,
contentColor = MaterialTheme.colorScheme.onBackground, newsState = NewsUiState.Loading,
) { padding -> onBackClick = {},
AuthorScreen( onFollowClick = {}
authorState = AuthorUiState.Loading, )
newsState = NewsUiState.Loading,
onBackClick = {},
onFollowClick = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }

@ -27,16 +27,12 @@ import androidx.compose.foundation.layout.windowInsetsPadding
import androidx.compose.material.icons.Icons import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.MoreVert import androidx.compose.material.icons.filled.MoreVert
import androidx.compose.material.icons.filled.Search import androidx.compose.material.icons.filled.Search
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@ -176,7 +172,6 @@ private fun InterestsEmptyScreen() {
Text(text = stringResource(id = R.string.interests_empty_header)) Text(text = stringResource(id = R.string.interests_empty_header))
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -185,32 +180,25 @@ private fun InterestsEmptyScreen() {
fun InterestsScreenPopulated() { fun InterestsScreenPopulated() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( InterestsScreen(
containerColor = Color.Transparent, uiState = InterestsUiState.Interests(
contentColor = MaterialTheme.colorScheme.onBackground, authors = previewAuthors.map { FollowableAuthor(it, false) },
) { padding -> topics = previewTopics.map { FollowableTopic(it, false) }
InterestsScreen( ),
uiState = InterestsUiState.Interests( tabState = InterestsTabState(
authors = previewAuthors.map { FollowableAuthor(it, false) }, titles = listOf(R.string.interests_topics, R.string.interests_people),
topics = previewTopics.map { FollowableTopic(it, false) } currentIndex = 0
), ),
tabState = InterestsTabState( followAuthor = { _, _ -> },
titles = listOf(R.string.interests_topics, R.string.interests_people), followTopic = { _, _ -> },
currentIndex = 0 navigateToAuthor = {},
), navigateToTopic = {},
followAuthor = { _, _ -> }, switchTab = {}
followTopic = { _, _ -> }, )
navigateToAuthor = {},
navigateToTopic = {},
switchTab = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -219,29 +207,22 @@ fun InterestsScreenPopulated() {
fun InterestsScreenLoading() { fun InterestsScreenLoading() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( InterestsScreen(
containerColor = Color.Transparent, uiState = InterestsUiState.Loading,
contentColor = MaterialTheme.colorScheme.onBackground, tabState = InterestsTabState(
) { padding -> titles = listOf(R.string.interests_topics, R.string.interests_people),
InterestsScreen( currentIndex = 0
uiState = InterestsUiState.Loading, ),
tabState = InterestsTabState( followAuthor = { _, _ -> },
titles = listOf(R.string.interests_topics, R.string.interests_people), followTopic = { _, _ -> },
currentIndex = 0 navigateToAuthor = {},
), navigateToTopic = {},
followAuthor = { _, _ -> }, switchTab = {},
followTopic = { _, _ -> }, )
navigateToAuthor = {},
navigateToTopic = {},
switchTab = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -250,24 +231,18 @@ fun InterestsScreenLoading() {
fun InterestsScreenEmpty() { fun InterestsScreenEmpty() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( InterestsScreen(
containerColor = Color.Transparent, uiState = InterestsUiState.Empty,
contentColor = MaterialTheme.colorScheme.onBackground, tabState = InterestsTabState(
) { padding -> titles = listOf(R.string.interests_topics, R.string.interests_people),
InterestsScreen( currentIndex = 0
uiState = InterestsUiState.Empty, ),
tabState = InterestsTabState( followAuthor = { _, _ -> },
titles = listOf(R.string.interests_topics, R.string.interests_people), followTopic = { _, _ -> },
currentIndex = 0 navigateToAuthor = {},
), navigateToTopic = {},
followAuthor = { _, _ -> }, switchTab = {}
followTopic = { _, _ -> }, )
navigateToAuthor = {},
navigateToTopic = {},
switchTab = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }

@ -34,18 +34,15 @@ import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyListScope import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.material.icons.Icons.Filled import androidx.compose.material.icons.Icons.Filled
import androidx.compose.material.icons.filled.ArrowBack import androidx.compose.material.icons.filled.ArrowBack
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@ -230,7 +227,6 @@ private fun TopicToolbar(
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -239,23 +235,16 @@ private fun TopicToolbar(
fun TopicScreenPopulated() { fun TopicScreenPopulated() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( TopicScreen(
containerColor = Color.Transparent, topicState = TopicUiState.Success(FollowableTopic(previewTopics[0], false)),
contentColor = MaterialTheme.colorScheme.onBackground, newsState = NewsUiState.Success(previewNewsResources),
) { padding -> onBackClick = {},
TopicScreen( onFollowClick = {}
topicState = TopicUiState.Success(FollowableTopic(previewTopics[0], false)), )
newsState = NewsUiState.Success(previewNewsResources),
onBackClick = {},
onFollowClick = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480") @Preview(name = "phone", device = "spec:shape=Normal,width=360,height=640,unit=dp,dpi=480")
@Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480") @Preview(name = "landscape", device = "spec:shape=Normal,width=640,height=360,unit=dp,dpi=480")
@Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480") @Preview(name = "foldable", device = "spec:shape=Normal,width=673,height=841,unit=dp,dpi=480")
@ -264,18 +253,12 @@ fun TopicScreenPopulated() {
fun TopicScreenLoading() { fun TopicScreenLoading() {
NiaTheme { NiaTheme {
NiaBackground { NiaBackground {
Scaffold( TopicScreen(
containerColor = Color.Transparent, topicState = TopicUiState.Loading,
contentColor = MaterialTheme.colorScheme.onBackground, newsState = NewsUiState.Loading,
) { padding -> onBackClick = {},
TopicScreen( onFollowClick = {}
topicState = TopicUiState.Loading, )
newsState = NewsUiState.Loading,
onBackClick = {},
onFollowClick = {},
modifier = Modifier.padding(padding)
)
}
} }
} }
} }

Loading…
Cancel
Save