Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3

Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`

core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/util/ConnectivityManagerNetworkMonitor.kt

@@ -37,6 +37,18 @@ class ConnectivityManagerNetworkMonitor @Inject constructor(
 ) : NetworkMonitor {
     override val isOnline: Flow<Boolean> = callbackFlow {
         val connectivityManager = context.getSystemService<ConnectivityManager>()
+        if (connectivityManager == null) {
+            channel.trySend(false)
+            channel.close()
+            return@callbackFlow
+        }
+
+        /**
+         * Sends the latest connectivity status to the underlying channel.
+         */
+        fun update() {
+            channel.trySend(connectivityManager.isCurrentlyConnected())
+        }
 
         /**
          * The callback's methods are invoked on changes to *any* network, not just the active
@@ -44,47 +56,37 @@ class ConnectivityManagerNetworkMonitor @Inject constructor(
          * ConnectivityManager.
          */
         val callback = object : NetworkCallback() {
-            override fun onAvailable(network: Network) {
+            override fun onAvailable(network: Network) = update()
-                channel.trySend(connectivityManager.isCurrentlyConnected())
-            }
 
-            override fun onLost(network: Network) {
+            override fun onLost(network: Network) = update()
-                channel.trySend(connectivityManager.isCurrentlyConnected())
-            }
 
             override fun onCapabilitiesChanged(
                 network: Network,
                 networkCapabilities: NetworkCapabilities,
-            ) {
+            ) = update()
-                channel.trySend(connectivityManager.isCurrentlyConnected())
-            }
         }
 
-        connectivityManager?.registerNetworkCallback(
+        connectivityManager.registerNetworkCallback(
             Builder()
                 .addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
                 .build(),
             callback,
         )
 
-        channel.trySend(connectivityManager.isCurrentlyConnected())
+        update()
 
         awaitClose {
-            connectivityManager?.unregisterNetworkCallback(callback)
+            connectivityManager.unregisterNetworkCallback(callback)
         }
     }
         .conflate()
 
     @Suppress("DEPRECATION")
-    private fun ConnectivityManager?.isCurrentlyConnected() = when (this) {
+    private fun ConnectivityManager.isCurrentlyConnected() = when {
-        null -> false
+        VERSION.SDK_INT >= VERSION_CODES.M ->
-        else -> when {
+            activeNetwork
-            VERSION.SDK_INT >= VERSION_CODES.M ->
+                ?.let(::getNetworkCapabilities)
-                activeNetwork
+                ?.hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
-                    ?.let(::getNetworkCapabilities)
+        else -> activeNetworkInfo?.isConnected
-                    ?.hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
+    } ?: false
-                    ?: false
-            else -> activeNetworkInfo?.isConnected ?: false
-        }
-    }
 }