Apply version catalog in the `plugin`.

Change-Id: I471d999ca3bd9c9246b24565d6e2f57bde010225
pull/1517/head
Jaehwa Noh 1 year ago
parent 2b00e021e2
commit b0388bbfc7

@ -16,6 +16,7 @@
import com.android.build.api.dsl.ApplicationExtension
import com.google.samples.apps.nowinandroid.configureAndroidCompose
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.apply
@ -24,8 +25,8 @@ import org.gradle.kotlin.dsl.getByType
class AndroidApplicationComposeConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
apply(plugin = "com.android.application")
apply(plugin = "org.jetbrains.kotlin.plugin.compose")
apply(plugin = libs.findPlugin("android-application").get().get().pluginId)
apply(plugin = libs.findPlugin("compose").get().get().pluginId)
val extension = extensions.getByType<ApplicationExtension>()
configureAndroidCompose(extension)

@ -21,6 +21,7 @@ import com.google.samples.apps.nowinandroid.configureBadgingTasks
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
import com.google.samples.apps.nowinandroid.configurePrintApksTask
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.configure
@ -30,10 +31,10 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("com.android.application")
apply("org.jetbrains.kotlin.android")
apply("nowinandroid.android.lint")
apply("com.dropbox.dependency-guard")
apply(libs.findPlugin("android-application").get().get().pluginId)
apply(libs.findPlugin("kotlin-android").get().get().pluginId)
apply(libs.findPlugin("nowinandroid.android.lint").get().get().pluginId)
apply(libs.findPlugin("dependencyGuard").get().get().pluginId)
}
extensions.configure<ApplicationExtension> {
@ -49,5 +50,4 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
}
}
}
}

@ -26,9 +26,9 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("com.google.gms.google-services")
apply("com.google.firebase.firebase-perf")
apply("com.google.firebase.crashlytics")
apply(libs.findPlugin("gms").get().get().pluginId)
apply(libs.findPlugin("firebase-perf").get().get().pluginId)
apply(libs.findPlugin("firebase-crashlytics").get().get().pluginId)
}
dependencies {

@ -17,6 +17,7 @@
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
import com.android.build.gradle.internal.dsl.BaseAppModuleExtension
import com.google.samples.apps.nowinandroid.configureJacoco
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.getByType
@ -24,7 +25,7 @@ import org.gradle.kotlin.dsl.getByType
class AndroidApplicationJacocoConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
pluginManager.apply("jacoco")
pluginManager.apply(libs.findPlugin("jacoco").get().get().pluginId)
val androidExtension = extensions.getByType<BaseAppModuleExtension>()
androidExtension.buildTypes.configureEach {

@ -26,8 +26,8 @@ class AndroidFeatureConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
pluginManager.apply {
apply("nowinandroid.android.library")
apply("nowinandroid.android.hilt")
apply(libs.findPlugin("nowinandroid.android.library").get().get().pluginId)
apply(libs.findPlugin("nowinandroid.android.hilt").get().get().pluginId)
}
extensions.configure<LibraryExtension> {
defaultConfig {

@ -23,8 +23,8 @@ class AndroidHiltConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("com.google.devtools.ksp")
apply("dagger.hilt.android.plugin")
apply(libs.findPlugin("ksp").get().get().pluginId)
apply(libs.findPlugin("hilt-plugin").get().get().pluginId)
}
dependencies {

@ -16,6 +16,7 @@
import com.android.build.gradle.LibraryExtension
import com.google.samples.apps.nowinandroid.configureAndroidCompose
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.apply
@ -24,8 +25,8 @@ import org.gradle.kotlin.dsl.getByType
class AndroidLibraryComposeConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
apply(plugin = "com.android.library")
apply(plugin = "org.jetbrains.kotlin.plugin.compose")
apply(plugin = libs.findPlugin("android-library").get().get().pluginId)
apply(plugin = libs.findPlugin("compose").get().get().pluginId)
val extension = extensions.getByType<LibraryExtension>()
configureAndroidCompose(extension)

@ -32,9 +32,9 @@ class AndroidLibraryConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("com.android.library")
apply("org.jetbrains.kotlin.android")
apply("nowinandroid.android.lint")
apply(libs.findPlugin("android-library").get().get().pluginId)
apply(libs.findPlugin("kotlin-android").get().get().pluginId)
apply(libs.findPlugin("nowinandroid.android.lint").get().get().pluginId)
}
extensions.configure<LibraryExtension> {

@ -15,9 +15,9 @@
*/
import com.android.build.api.dsl.LibraryExtension
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
import com.android.build.api.variant.LibraryAndroidComponentsExtension
import com.google.samples.apps.nowinandroid.configureJacoco
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.getByType
@ -25,7 +25,7 @@ import org.gradle.kotlin.dsl.getByType
class AndroidLibraryJacocoConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
pluginManager.apply("jacoco")
pluginManager.apply(libs.findPlugin("jacoco").get().get().pluginId)
val androidExtension = extensions.getByType<LibraryExtension>()
androidExtension.buildTypes.configureEach {

@ -26,8 +26,8 @@ class AndroidRoomConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
pluginManager.apply("androidx.room")
pluginManager.apply("com.google.devtools.ksp")
pluginManager.apply(libs.findPlugin("room").get().get().pluginId)
pluginManager.apply(libs.findPlugin("ksp").get().get().pluginId)
extensions.configure<KspExtension> {
arg("room.generateKotlin", "true")

@ -17,6 +17,7 @@
import com.android.build.gradle.TestExtension
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.configure
@ -25,8 +26,8 @@ class AndroidTestConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("com.android.test")
apply("org.jetbrains.kotlin.android")
apply(libs.findPlugin("android-test").get().get().pluginId)
apply(libs.findPlugin("kotlin-android").get().get().pluginId)
}
extensions.configure<TestExtension> {

@ -15,6 +15,7 @@
*/
import com.google.samples.apps.nowinandroid.configureKotlinJvm
import com.google.samples.apps.nowinandroid.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
@ -22,8 +23,8 @@ class JvmLibraryConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("org.jetbrains.kotlin.jvm")
apply("nowinandroid.android.lint")
apply(libs.findPlugin("kotlin-jvm").get().get().pluginId)
apply(libs.findPlugin("nowinandroid.android.lint").get().get().pluginId)
}
configureKotlinJvm()
}

Loading…
Cancel
Save