fix: address bot review feedback - improve task config efficiency and scope enabledRules to nonMinifiedRelease build type

pull/2102/head
vibhor-kulshrestha 2 weeks ago
parent a15f8041bd
commit 9d80cc47bd

@ -151,11 +151,12 @@ dependencyGuard {
configuration("prodReleaseRuntimeClasspath")
}
tasks.configureEach {
if (name == "createProdNonMinifiedReleaseApkListingFileRedirect") {
val benchmarksProject = project.rootProject.findProject(":benchmarks")
benchmarksProject?.tasks?.matching {
it.name.contains("packageProdNonMinifiedRelease")
}?.let { dependsOn(it) }
}
val benchmarksProject = rootProject.findProject(":benchmarks")
if (benchmarksProject != null) {
tasks.matching { it.name == "createProdNonMinifiedReleaseApkListingFileRedirect" }
.configureEach {
dependsOn(benchmarksProject.tasks.matching {
it.name.contains("packageProdNonMinifiedRelease")
})
}
}

@ -26,10 +26,13 @@ android {
defaultConfig {
minSdk = 28
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
testInstrumentationRunnerArguments["androidx.benchmark.enabledRules"] = "BaselineProfile"
buildConfigField("String", "APP_BUILD_TYPE_SUFFIX", "\"\"")
}
buildTypes {
create("nonMinifiedRelease") {
defaultConfig.testInstrumentationRunnerArguments["androidx.benchmark.enabledRules"] = "BaselineProfile"
}
}
buildFeatures {
buildConfig = true
}

Loading…
Cancel
Save