From 9d80cc47bddebe4f65a5b8fea63245eb309f424a Mon Sep 17 00:00:00 2001 From: vibhor-kulshrestha Date: Wed, 22 Apr 2026 17:02:37 +0530 Subject: [PATCH] fix: address bot review feedback - improve task config efficiency and scope enabledRules to nonMinifiedRelease build type --- app/build.gradle.kts | 15 ++++++++------- benchmarks/build.gradle.kts | 7 +++++-- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 45a284bd7..93e9d8b18 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -151,11 +151,12 @@ dependencyGuard { configuration("prodReleaseRuntimeClasspath") } -tasks.configureEach { - if (name == "createProdNonMinifiedReleaseApkListingFileRedirect") { - val benchmarksProject = project.rootProject.findProject(":benchmarks") - benchmarksProject?.tasks?.matching { - it.name.contains("packageProdNonMinifiedRelease") - }?.let { dependsOn(it) } - } +val benchmarksProject = rootProject.findProject(":benchmarks") +if (benchmarksProject != null) { + tasks.matching { it.name == "createProdNonMinifiedReleaseApkListingFileRedirect" } + .configureEach { + dependsOn(benchmarksProject.tasks.matching { + it.name.contains("packageProdNonMinifiedRelease") + }) + } } diff --git a/benchmarks/build.gradle.kts b/benchmarks/build.gradle.kts index 67b053ec6..037e8866e 100644 --- a/benchmarks/build.gradle.kts +++ b/benchmarks/build.gradle.kts @@ -26,10 +26,13 @@ android { defaultConfig { minSdk = 28 testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" - testInstrumentationRunnerArguments["androidx.benchmark.enabledRules"] = "BaselineProfile" buildConfigField("String", "APP_BUILD_TYPE_SUFFIX", "\"\"") } - + buildTypes { + create("nonMinifiedRelease") { + defaultConfig.testInstrumentationRunnerArguments["androidx.benchmark.enabledRules"] = "BaselineProfile" + } + } buildFeatures { buildConfig = true }