- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules. - Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code. - Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint). - Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs. If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`. But in practice, this does not change the total build time on this project.pull/759/head
parent
0c8457099d
commit
8ea9a8fa51
@ -0,0 +1,46 @@
|
|||||||
|
/*
|
||||||
|
* Copyright 2022 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* https://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import com.android.build.api.dsl.ApplicationExtension
|
||||||
|
import com.android.build.api.dsl.Lint
|
||||||
|
import com.android.build.gradle.LibraryExtension
|
||||||
|
import org.gradle.api.Plugin
|
||||||
|
import org.gradle.api.Project
|
||||||
|
import org.gradle.kotlin.dsl.configure
|
||||||
|
|
||||||
|
class AndroidLintConventionPlugin : Plugin<Project> {
|
||||||
|
override fun apply(target: Project) {
|
||||||
|
with(target) {
|
||||||
|
when {
|
||||||
|
pluginManager.hasPlugin("com.android.application") ->
|
||||||
|
configure<ApplicationExtension> { lint(Lint::configure) }
|
||||||
|
|
||||||
|
pluginManager.hasPlugin("com.android.library") ->
|
||||||
|
configure<LibraryExtension> { lint(Lint::configure) }
|
||||||
|
|
||||||
|
else -> {
|
||||||
|
pluginManager.apply("com.android.lint")
|
||||||
|
configure<Lint>(Lint::configure)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun Lint.configure() {
|
||||||
|
xmlReport = true
|
||||||
|
sarifReport = true
|
||||||
|
}
|
Loading…
Reference in new issue