Don't rely on `finalizeDsl` API to configure Crashlytics

pull/678/head
Simon Marquis 2 years ago committed by GitHub
parent 2c18740d62
commit 80b8ae7a98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -14,7 +14,7 @@
* limitations under the License. * limitations under the License.
*/ */
import com.android.build.api.variant.ApplicationAndroidComponentsExtension import com.android.build.api.dsl.ApplicationExtension
import com.google.firebase.crashlytics.buildtools.gradle.CrashlyticsExtension import com.google.firebase.crashlytics.buildtools.gradle.CrashlyticsExtension
import org.gradle.api.Plugin import org.gradle.api.Plugin
import org.gradle.api.Project import org.gradle.api.Project
@ -41,13 +41,12 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
"implementation"(libs.findLibrary("firebase.crashlytics").get()) "implementation"(libs.findLibrary("firebase.crashlytics").get())
} }
extensions.configure<ApplicationAndroidComponentsExtension> { extensions.configure<ApplicationExtension> {
finalizeDsl { buildTypes.configureEach {
it.buildTypes.forEach { buildType ->
// Disable the Crashlytics mapping file upload. This feature should only be // Disable the Crashlytics mapping file upload. This feature should only be
// enabled if a Firebase backend is available and configured in // enabled if a Firebase backend is available and configured in
// google-services.json. // google-services.json.
buildType.configure<CrashlyticsExtension> { configure<CrashlyticsExtension> {
mappingFileUploadEnabled = false mappingFileUploadEnabled = false
} }
} }
@ -55,4 +54,3 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
} }
} }
} }
}

Loading…
Cancel
Save