Remove Scaffold from BookmarksScreen

pull/1837/head
Don Turner 3 years ago
parent afa5c2eecd
commit 58d67a170b

@ -70,44 +70,37 @@ fun BookmarksScreen(
removeFromBookmarks: (String) -> Unit, removeFromBookmarks: (String) -> Unit,
modifier: Modifier = Modifier modifier: Modifier = Modifier
) { ) {
Scaffold( val scrollableState = rememberLazyGridState()
containerColor = Color.Transparent, TrackScrollJank(scrollableState = scrollableState, stateName = "bookmarks:grid")
contentWindowInsets = WindowInsets(0, 0, 0, 0) LazyVerticalGrid(
) { innerPadding -> columns = Adaptive(300.dp),
val scrollableState = rememberLazyGridState() contentPadding = PaddingValues(16.dp),
TrackScrollJank(scrollableState = scrollableState, stateName = "bookmarks:grid") horizontalArrangement = Arrangement.spacedBy(32.dp),
LazyVerticalGrid( verticalArrangement = Arrangement.spacedBy(24.dp),
columns = Adaptive(300.dp), state = scrollableState,
contentPadding = PaddingValues(16.dp), modifier = modifier
horizontalArrangement = Arrangement.spacedBy(32.dp), .fillMaxSize()
verticalArrangement = Arrangement.spacedBy(24.dp), .testTag("bookmarks:feed")
state = scrollableState, ) {
modifier = modifier if (feedState is NewsFeedUiState.Loading) {
.fillMaxSize() item(span = { GridItemSpan(maxLineSpan) }) {
.testTag("bookmarks:feed") NiaLoadingWheel(
.padding(innerPadding) modifier = Modifier
.consumedWindowInsets(innerPadding) .fillMaxWidth()
) { .wrapContentSize()
if (feedState is NewsFeedUiState.Loading) { .testTag("forYou:loading"),
item(span = { GridItemSpan(maxLineSpan) }) { contentDesc = stringResource(id = R.string.saved_loading),
NiaLoadingWheel( )
modifier = Modifier
.fillMaxWidth()
.wrapContentSize()
.testTag("forYou:loading"),
contentDesc = stringResource(id = R.string.saved_loading),
)
}
} }
}
newsFeed( newsFeed(
feedState = feedState, feedState = feedState,
onNewsResourcesCheckedChanged = { id, _ -> removeFromBookmarks(id) }, onNewsResourcesCheckedChanged = { id, _ -> removeFromBookmarks(id) },
) )
item(span = { GridItemSpan(maxLineSpan) }) { item(span = { GridItemSpan(maxLineSpan) }) {
Spacer(Modifier.windowInsetsBottomHeight(WindowInsets.safeDrawing)) Spacer(Modifier.windowInsetsBottomHeight(WindowInsets.safeDrawing))
}
} }
} }
} }

Loading…
Cancel
Save