fix: review notes

pull/850/head
qamarelsafadi 1 year ago
parent 8a197800c5
commit 57025e7587

@ -72,6 +72,7 @@ import kotlinx.datetime.Instant
import kotlinx.datetime.toJavaInstant import kotlinx.datetime.toJavaInstant
import java.time.ZoneId import java.time.ZoneId
import java.time.format.DateTimeFormatter import java.time.format.DateTimeFormatter
import java.time.format.FormatStyle
import java.util.Locale import java.util.Locale
import com.google.samples.apps.nowinandroid.core.designsystem.R as DesignsystemR import com.google.samples.apps.nowinandroid.core.designsystem.R as DesignsystemR
@ -157,15 +158,11 @@ fun NewsResourceHeaderImage(
// TODO b/226661685: Investigate using alt text of image to populate content description // TODO b/226661685: Investigate using alt text of image to populate content description
contentDescription = null, // decorative image, contentDescription = null, // decorative image,
error = { error = {
if (LocalInspectionMode.current) {
Image( Image(
painter = painter =
painterResource(DesignsystemR.drawable.ic_placeholder_default), painterResource(DesignsystemR.drawable.ic_placeholder_default),
contentDescription = "placeholder image", contentDescription = "placeholder image",
) )
} else {
null
}
}, },
loading = { loading = {
Box( Box(
@ -248,8 +245,12 @@ fun dateFormatted(publishDate: Instant): String {
} }
} }
return DateTimeFormatter.ofPattern("MMM d, yyyy") return DateTimeFormatter
.withZone(zoneId).format(publishDate.toJavaInstant()) .ofLocalizedDate(FormatStyle.MEDIUM)
.withLocale(Locale.getDefault())
.withZone(zoneId)
.format(publishDate.toJavaInstant())
} }
@Composable @Composable

Loading…
Cancel
Save