fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt

1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
pull/706/head
gururani-abhishek 1 year ago
parent d905701028
commit 51379a249d

@ -31,23 +31,18 @@ import com.google.samples.apps.nowinandroid.core.model.data.UserNewsResource
* [UserNewsResource]s. * [UserNewsResource]s.
* *
* [onToggleBookmark] defines the action invoked when a user wishes to bookmark an item * [onToggleBookmark] defines the action invoked when a user wishes to bookmark an item
* [onItemClick] optional parameter for action to be performed when the card is clicked. The * Default action launches an intent matching the card.
* default action launches an intent matching the card.
*/ */
fun LazyListScope.userNewsResourceCardItems( fun LazyListScope.userNewsResourceCardItems(
items: List<UserNewsResource>, items: List<UserNewsResource>,
onToggleBookmark: (item: UserNewsResource) -> Unit, onToggleBookmark: (item: UserNewsResource) -> Unit,
onNewsResourceViewed: (String) -> Unit, onNewsResourceViewed: (String) -> Unit,
onItemClick: ((item: UserNewsResource) -> Unit)? = null,
onTopicClick: (String) -> Unit, onTopicClick: (String) -> Unit,
itemModifier: Modifier = Modifier, itemModifier: Modifier = Modifier,
) = items( ) = items(
items = items, items = items,
key = { it.id }, key = { it.id },
itemContent = { userNewsResource -> itemContent = { userNewsResource ->
val resourceUrl = Uri.parse(userNewsResource.url)
val backgroundColor = MaterialTheme.colorScheme.background.toArgb()
val context = LocalContext.current
val analyticsHelper = LocalAnalyticsHelper.current val analyticsHelper = LocalAnalyticsHelper.current
NewsResourceCardExpanded( NewsResourceCardExpanded(
@ -59,10 +54,6 @@ fun LazyListScope.userNewsResourceCardItems(
analyticsHelper.logNewsResourceOpened( analyticsHelper.logNewsResourceOpened(
newsResourceId = userNewsResource.id, newsResourceId = userNewsResource.id,
) )
when (onItemClick) {
null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)
else -> onItemClick(userNewsResource)
}
onNewsResourceViewed(userNewsResource.id) onNewsResourceViewed(userNewsResource.id)
}, },
onTopicClick = onTopicClick, onTopicClick = onTopicClick,

Loading…
Cancel
Save