Merge pull request #203 from necatisozer/patch-1

Put some modifiers in correct order to respect official API guidelines
pull/227/head
Jolanda Verhoef 2 years ago committed by GitHub
commit 48bd8d713e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -389,8 +389,8 @@ private fun SingleTopicButton(
@Composable @Composable
fun TopicIcon( fun TopicIcon(
modifier: Modifier = Modifier, imageUrl: String,
imageUrl: String modifier: Modifier = Modifier
) { ) {
AsyncImage( AsyncImage(
// TODO b/228077205, show loading image visual instead of static placeholder // TODO b/228077205, show loading image visual instead of static placeholder

@ -49,9 +49,9 @@ import com.google.samples.apps.nowinandroid.core.ui.JankMetricDisposableEffect
@OptIn(ExperimentalLifecycleComposeApi::class) @OptIn(ExperimentalLifecycleComposeApi::class)
@Composable @Composable
fun InterestsRoute( fun InterestsRoute(
modifier: Modifier = Modifier,
navigateToAuthor: (String) -> Unit, navigateToAuthor: (String) -> Unit,
navigateToTopic: (String) -> Unit, navigateToTopic: (String) -> Unit,
modifier: Modifier = Modifier,
viewModel: InterestsViewModel = hiltViewModel() viewModel: InterestsViewModel = hiltViewModel()
) { ) {
val uiState by viewModel.uiState.collectAsStateWithLifecycle() val uiState by viewModel.uiState.collectAsStateWithLifecycle()

Loading…
Cancel
Save