Revert AGP's APIs change workarounds with `.apply{}` to reduce visual changes as requested

pull/1959/head
Simon Marquis 10 months ago
parent 06fe6698f3
commit 1e7095d76a
No known key found for this signature in database

@ -31,7 +31,9 @@ internal fun Project.configureAndroidCompose(
commonExtension: CommonExtension, commonExtension: CommonExtension,
) { ) {
commonExtension.apply { commonExtension.apply {
buildFeatures.compose = true buildFeatures.apply {
compose = true
}
dependencies { dependencies {
val bom = libs.findLibrary("androidx-compose-bom").get() val bom = libs.findLibrary("androidx-compose-bom").get()

@ -35,7 +35,8 @@ internal fun configureGradleManagedDevices(
val ciDevices = listOf(pixel4, pixelC) val ciDevices = listOf(pixel4, pixelC)
commonExtension.testOptions.managedDevices { commonExtension.testOptions.apply {
managedDevices {
allDevices { allDevices {
allDevices.forEach { deviceConfig -> allDevices.forEach { deviceConfig ->
maybeCreate(deviceConfig.taskName, ManagedVirtualDevice::class.java).apply { maybeCreate(deviceConfig.taskName, ManagedVirtualDevice::class.java).apply {
@ -54,6 +55,7 @@ internal fun configureGradleManagedDevices(
} }
} }
} }
}
private data class DeviceConfig( private data class DeviceConfig(
val device: String, val device: String,

@ -37,13 +37,17 @@ internal fun Project.configureKotlinAndroid(
commonExtension.apply { commonExtension.apply {
compileSdk = 35 compileSdk = 35
defaultConfig.minSdk = 23 defaultConfig.apply {
minSdk = 23
}
compileOptions.apply {
// Up to Java 11 APIs are available through desugaring // Up to Java 11 APIs are available through desugaring
// https://developer.android.com/studio/write/java11-minimal-support-table // https://developer.android.com/studio/write/java11-minimal-support-table
compileOptions.sourceCompatibility = JavaVersion.VERSION_11 sourceCompatibility = JavaVersion.VERSION_11
compileOptions.targetCompatibility = JavaVersion.VERSION_11 targetCompatibility = JavaVersion.VERSION_11
compileOptions.isCoreLibraryDesugaringEnabled = true isCoreLibraryDesugaringEnabled = true
}
} }
configureKotlin<KotlinAndroidProjectExtension>() configureKotlin<KotlinAndroidProjectExtension>()

@ -28,8 +28,9 @@ fun configureFlavors(
flavorDimensions += flavorDimension.name flavorDimensions += flavorDimension.name
} }
productFlavors.apply {
NiaFlavor.values().forEach { niaFlavor -> NiaFlavor.values().forEach { niaFlavor ->
productFlavors.register(niaFlavor.name) { register(niaFlavor.name) {
dimension = niaFlavor.dimension.name dimension = niaFlavor.dimension.name
flavorConfigurationBlock(this, niaFlavor) flavorConfigurationBlock(this, niaFlavor)
if (this@apply is ApplicationExtension && this is ApplicationProductFlavor) { if (this@apply is ApplicationExtension && this is ApplicationProductFlavor) {
@ -41,3 +42,4 @@ fun configureFlavors(
} }
} }
} }
}

Loading…
Cancel
Save