Replace unused variable with simpler method calls

pull/667/head
Simon Marquis 2 years ago
parent 459717f8ba
commit 1341f7c2c5

@ -55,7 +55,7 @@ android {
namespace = "com.google.samples.apps.niacatalog" namespace = "com.google.samples.apps.niacatalog"
buildTypes { buildTypes {
val release by getting { release {
// To publish on the Play store a private signing key is required, but to allow anyone // To publish on the Play store a private signing key is required, but to allow anyone
// who clones the code to sign and run the release variant, use the debug signing key. // who clones the code to sign and run the release variant, use the debug signing key.
// TODO: Abstract the signing configuration to a separate file to avoid hardcoding this. // TODO: Abstract the signing configuration to a separate file to avoid hardcoding this.

@ -39,7 +39,7 @@ android {
} }
buildTypes { buildTypes {
val debug by getting { debug {
applicationIdSuffix = NiaBuildType.DEBUG.applicationIdSuffix applicationIdSuffix = NiaBuildType.DEBUG.applicationIdSuffix
} }
val release by getting { val release by getting {
@ -52,7 +52,7 @@ android {
// TODO: Abstract the signing configuration to a separate file to avoid hardcoding this. // TODO: Abstract the signing configuration to a separate file to avoid hardcoding this.
signingConfig = signingConfigs.getByName("debug") signingConfig = signingConfigs.getByName("debug")
} }
val benchmark by creating { create("benchmark") {
// Enable all the optimizations from release build through initWith(release). // Enable all the optimizations from release build through initWith(release).
initWith(release) initWith(release)
matchingFallbacks.add("release") matchingFallbacks.add("release")

@ -39,7 +39,7 @@ android {
// This benchmark buildType is used for benchmarking, and should function like your // This benchmark buildType is used for benchmarking, and should function like your
// release build (for example, with minification on). It's signed with a debug key // release build (for example, with minification on). It's signed with a debug key
// for easy local/CI testing. // for easy local/CI testing.
val benchmark by creating { create("benchmark") {
// Keep the build type debuggable so we can attach a debugger if needed. // Keep the build type debuggable so we can attach a debugger if needed.
isDebuggable = true isDebuggable = true
signingConfig = signingConfigs.getByName("debug") signingConfig = signingConfigs.getByName("debug")

@ -41,10 +41,10 @@ protobuf {
generateProtoTasks { generateProtoTasks {
all().forEach { task -> all().forEach { task ->
task.builtins { task.builtins {
val java by registering { register("java") {
option("lite") option("lite")
} }
val kotlin by registering { register("kotlin") {
option("lite") option("lite")
} }
} }

Loading…
Cancel
Save