addressing PR feedback

pull/1208/head
Andres Sandoval 2 years ago
parent 7b2ac2bbc3
commit 0f3e29820b

@ -144,10 +144,7 @@ jobs:
timeout-minutes: 90 timeout-minutes: 90
strategy: strategy:
matrix: matrix:
device-config: [ "pixel4api30aospatd","pixel6api31aosp","pixelCapi30aospatd", device-config: [ "pixel4api30aospatd","pixel6api31aosp","pixelCapi30aospatd" ]
"pixel4api30aospatd","pixel6api31aosp","pixelCapi30aospatd",
"pixel4api30aospatd","pixel6api31aosp","pixelCapi30aospatd",
"pixel4api30aospatd","pixel6api31aosp","pixelCapi30aospatd" ]
steps: steps:
- name: Delete unnecessary tools 🔧 - name: Delete unnecessary tools 🔧

@ -85,7 +85,7 @@ com.google.dagger:dagger-lint-aar:2.51
com.google.dagger:dagger:2.51 com.google.dagger:dagger:2.51
com.google.dagger:hilt-android:2.51 com.google.dagger:hilt-android:2.51
com.google.dagger:hilt-core:2.51 com.google.dagger:hilt-core:2.51
com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava com.google.guava:listenablefuture:1.0
com.squareup.okhttp3:okhttp:4.12.0 com.squareup.okhttp3:okhttp:4.12.0
com.squareup.okio:okio-jvm:3.8.0 com.squareup.okio:okio-jvm:3.8.0
com.squareup.okio:okio:3.8.0 com.squareup.okio:okio:3.8.0

@ -34,8 +34,7 @@ internal fun Project.configureAndroidCompose(
} }
composeOptions { composeOptions {
kotlinCompilerExtensionVersion = kotlinCompilerExtensionVersion = libs.findVersion("androidxComposeCompiler").get().toString()
libs.findVersion("androidxComposeCompiler").get().toString()
} }
dependencies { dependencies {
@ -82,7 +81,7 @@ private fun Project.buildComposeMetricsParameters(): List<String> {
val reportsFolder = buildDir.resolve("compose-reports").resolve(relativePath) val reportsFolder = buildDir.resolve("compose-reports").resolve(relativePath)
metricParameters.add("-P") metricParameters.add("-P")
metricParameters.add( metricParameters.add(
"plugin:androidx.compose.compiler.plugins.kotlin:reportsDestination=" + reportsFolder.absolutePath, "plugin:androidx.compose.compiler.plugins.kotlin:reportsDestination=" + reportsFolder.absolutePath
) )
} }
return metricParameters.toList() return metricParameters.toList()

@ -21,7 +21,7 @@ enum class NiaFlavor(val dimension: FlavorDimension, val applicationIdSuffix: St
fun configureFlavors( fun configureFlavors(
commonExtension: CommonExtension<*, *, *, *, *, *>, commonExtension: CommonExtension<*, *, *, *, *, *>,
flavorConfigurationBlock: ProductFlavor.(flavor: NiaFlavor) -> Unit = {}, flavorConfigurationBlock: ProductFlavor.(flavor: NiaFlavor) -> Unit = {}
) { ) {
commonExtension.apply { commonExtension.apply {
flavorDimensions += FlavorDimension.contentType.name flavorDimensions += FlavorDimension.contentType.name

@ -33,7 +33,6 @@ dependencies {
api(projects.core.model) api(projects.core.model)
implementation(libs.kotlinx.datetime) implementation(libs.kotlinx.datetime)
implementation("com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava")
androidTestImplementation(projects.core.testing) androidTestImplementation(projects.core.testing)
} }

@ -38,7 +38,6 @@ dependencies {
api(libs.androidx.compose.ui.util) api(libs.androidx.compose.ui.util)
implementation(libs.coil.kt.compose) implementation(libs.coil.kt.compose)
implementation("com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava")
testImplementation(libs.androidx.compose.ui.test) testImplementation(libs.androidx.compose.ui.test)
testImplementation(libs.accompanist.testharness) testImplementation(libs.accompanist.testharness)

@ -2,7 +2,7 @@
accompanist = "0.32.0" accompanist = "0.32.0"
androidDesugarJdkLibs = "2.0.4" androidDesugarJdkLibs = "2.0.4"
# AGP and tools should be updated together # AGP and tools should be updated together
androidGradlePlugin = "8.4.0-alpha08" androidGradlePlugin = "8.4.0-alpha10"
androidTools = "31.3.0" androidTools = "31.3.0"
androidxActivity = "1.8.0" androidxActivity = "1.8.0"
androidxAppCompat = "1.6.1" androidxAppCompat = "1.6.1"

Loading…
Cancel
Save