style: remove extra else block

Ommiting extra else block makes it a little more readable
pull/13/head
Arifur Rahman 3 years ago
parent d9b12ab77b
commit f19513235b

@ -88,8 +88,8 @@ class RoleController extends Controller {
//don't allow changing the admin slug, because it will make the routes inaccessbile due to faile ability check //don't allow changing the admin slug, because it will make the routes inaccessbile due to faile ability check
$role->delete(); $role->delete();
return response(['error' => 0, 'message' => 'role has been deleted']); return response(['error' => 0, 'message' => 'role has been deleted']);
} else {
return response(['error' => 1, 'message' => 'you cannot delete this role'], 422);
} }
return response(['error' => 1, 'message' => 'you cannot delete this role'], 422);
} }
} }

@ -31,10 +31,9 @@ class UserRoleController extends Controller {
$role = Role::find($data['role_id']); $role = Role::find($data['role_id']);
if (!$user->roles()->find($data['role_id'])) { if (!$user->roles()->find($data['role_id'])) {
$user->roles()->attach($role); $user->roles()->attach($role);
return $user->load('roles');
} else {
return $user->load('roles');
} }
return $user->load('roles');
} }
/** /**

Loading…
Cancel
Save