Simplify data structure and remove useless verification

hippo4j-core/src/main/java/cn/hippo4j/core/plugin/impl/TaskTimeRecordPlugin.java

@@ -22,7 +22,8 @@ import cn.hippo4j.core.plugin.PluginRuntime;
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 
-import java.util.ArrayList;
+import java.lang.reflect.Array;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.concurrent.locks.Lock;
@@ -38,7 +39,7 @@ import java.util.stream.Collectors;
  */
 public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
 
-    static final int MAXIMUM_CAPACITY = 1 << 30;
+    private static final int MAXIMUM_CAPACITY = 1 << 30;
     public static final String PLUGIN_NAME = "task-time-record-plugin";
 
     /**
@@ -49,7 +50,7 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
     /**
      * timers
      */
-    public final List<Timer> timerTable;
+    public final Timer[] timerTable;
 
     /**
      * Create a {@link TaskTimeRecordPlugin}
@@ -59,9 +60,9 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
     public TaskTimeRecordPlugin(int initialCapacity) {
         Assert.isTrue(initialCapacity >= 1, "count must great then 0");
         initialCapacity = tableSizeFor(initialCapacity);
-        timerTable = new ArrayList<>(initialCapacity);
+        timerTable = (Timer[]) Array.newInstance(Timer.class, initialCapacity);
-        for (int i = 0; i < initialCapacity; i++) {
+        for (int i = 0; i < timerTable.length; i++) {
-            timerTable.add(new Timer());
+            timerTable[i] = new Timer();
         }
         modulo = initialCapacity - 1;
     }
@@ -117,7 +118,7 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
      */
     public Summary summarize() {
         // ignore unused timers
-        List<Summary> summaries = timerTable.stream()
+        List<Summary> summaries = Arrays.stream(timerTable)
                 .map(Timer::summarize)
                 .filter(s -> s.getTaskCount() > 0)
                 .collect(Collectors.toList());
@@ -143,12 +144,12 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
 
     private Timer getTimerForCurrentThread() {
         /*
-         * use table tableSize - 1 to take modulus for tid, and the remainder obtained is the subscript of the timer corresponding to the thread in the table. eg: tid = 10086, tableSize = 8, 10086 &
+         * use table tableSize - 1 to take modulus for tid, and the remainder obtained is the subscript of the timer corresponding to the thread in the table. eg: tid = 10086, tableSize = 8, then we
-         * (8 - 1) = 4
+         * get 10086 & (8 - 1) = 4
          */
         long threadId = Thread.currentThread().getId();
         int index = (int) (threadId & modulo);
-        return timerTable.get(index);
+        return timerTable[index];
     }
 
     /**
@@ -161,9 +162,6 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
         n |= n >>> 4;
         n |= n >>> 8;
         n |= n >>> 16;
-        if (n < 0) {
-            return 1;
-        }
         return n >= MAXIMUM_CAPACITY ? MAXIMUM_CAPACITY : n + 1;
     }
 
@@ -207,12 +205,12 @@ public class TaskTimeRecordPlugin extends AbstractTaskTimerPlugin {
             Lock writeLock = lock.writeLock();
             writeLock.lock();
             try {
-                if (taskCount == 0) {
+                if (taskCount > 0) {
-                    maxTaskTimeMillis = taskExecuteTime;
-                    minTaskTimeMillis = taskExecuteTime;
-                } else {
                     maxTaskTimeMillis = Math.max(taskExecuteTime, maxTaskTimeMillis);
                     minTaskTimeMillis = Math.min(taskExecuteTime, minTaskTimeMillis);
+                } else {
+                    maxTaskTimeMillis = taskExecuteTime;
+                    minTaskTimeMillis = taskExecuteTime;
                 }
                 taskCount = taskCount + 1;
                 totalTaskTimeMillis += taskExecuteTime;

hippo4j-core/src/test/java/cn/hippo4j/core/plugin/impl/TaskTimeRecordPluginTest.java

@@ -54,6 +54,7 @@ public class TaskTimeRecordPluginTest {
         executor.submit(() -> ThreadUtil.sleep(1000L));
         executor.submit(() -> ThreadUtil.sleep(3000L));
         executor.submit(() -> ThreadUtil.sleep(2000L));
+        executor.submit(() -> ThreadUtil.sleep(2000L));
 
         // waiting for shutdown
         executor.shutdown();
@@ -63,6 +64,6 @@ public class TaskTimeRecordPluginTest {
         Assert.assertEquals(1, summary.getMinTaskTimeMillis() / 1000L);
         Assert.assertEquals(3, summary.getMaxTaskTimeMillis() / 1000L);
         Assert.assertEquals(2, summary.getAvgTaskTimeMillis() / 1000L);
-        Assert.assertEquals(6, summary.getTotalTaskTimeMillis() / 1000L);
+        Assert.assertEquals(8, summary.getTotalTaskTimeMillis() / 1000L);
     }
 }