change method signatures in LogMessage tests #1331

pull/1343/head
annippolito 2 years ago
parent ad4d839962
commit 12b6e60b03

@ -1,3 +1,20 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package cn.hippo4j.common.extension.design; package cn.hippo4j.common.extension.design;
import lombok.Getter; import lombok.Getter;
@ -13,8 +30,7 @@ import java.util.concurrent.atomic.AtomicInteger;
public class AbstractSubjectCenterTest { public class AbstractSubjectCenterTest {
private Map<String, List<Observer>> OBSERVERS_MAP;
private Map<String, List<Observer>> OBSERVERS_MAP ;
private SubjectNotifyListener subjectNotifyListener; private SubjectNotifyListener subjectNotifyListener;
@ -130,13 +146,14 @@ public class AbstractSubjectCenterTest {
@Getter @Getter
private static final class NotifyMessage { private static final class NotifyMessage {
private final AtomicInteger count = new AtomicInteger(0); private final AtomicInteger count = new AtomicInteger(0);
} }
/** /**
* Subject Response Listener * Subject Response Listener
*/ */
private static final class SubjectNotifyListener implements Observer<NotifyMessage>{ private static final class SubjectNotifyListener implements Observer<NotifyMessage> {
@Override @Override
public void accept(ObserverMessage<NotifyMessage> observerMessage) { public void accept(ObserverMessage<NotifyMessage> observerMessage) {

@ -39,25 +39,25 @@ class LogMessageTest {
} }
@Test @Test
void getInstance_shouldReturnANewLogMessageInstance() { void testGetInstanceShouldReturnANewLogMessageInstance() {
final LogMessage newInstance = LogMessage.getInstance(); final LogMessage newInstance = LogMessage.getInstance();
assertNotNull(newInstance); assertNotNull(newInstance);
assertNotSame(logMessage, newInstance); assertNotSame(logMessage, newInstance);
} }
@Test @Test
void getInstance_shouldHaveAnEmptyMessage() { void testToStringShouldHaveAnEmptyMessage() {
assertEquals(Strings.EMPTY, logMessage.toString()); assertEquals(Strings.EMPTY, logMessage.toString());
} }
@Test @Test
void setMsg_shouldSetAnewMessageInLogMessage() { void testSetMsgShouldSetAnewMessageInLogMessage() {
logMessage.setMsg(MESSAGE); logMessage.setMsg(MESSAGE);
assertEquals(MESSAGE, logMessage.toString()); assertEquals(MESSAGE, logMessage.toString());
} }
@Test @Test
void msg_shouldContainsMessageAndThrowableMessage() { void testMsgShouldContainsMessageAndThrowableMessage() {
final String message = logMessage.msg(MESSAGE, new Throwable(THROWABLE_MESSAGE)); final String message = logMessage.msg(MESSAGE, new Throwable(THROWABLE_MESSAGE));
assertNotNull(message); assertNotNull(message);
assertTrue(message.contains(MESSAGE)); assertTrue(message.contains(MESSAGE));
@ -65,20 +65,20 @@ class LogMessageTest {
} }
@Test @Test
void toString_shouldPrintKeyAndValueWhenSet() { void testKvShouldPutKeyAndValue() {
logMessage.kv("key", "value"); logMessage.kv("key", "value");
assertEquals("key=value", logMessage.toString()); assertEquals("key=value", logMessage.toString());
} }
@Test @Test
void toString_shouldPrintAllKeyAndValuePairs() { void testKvShouldPutAllKeyAndValuePairs() {
logMessage.kv("key1", "value1"); logMessage.kv("key1", "value1");
logMessage.kv("key2", "value2"); logMessage.kv("key2", "value2");
assertEquals("key1=value1||key2=value2", logMessage.toString()); assertEquals("key1=value1||key2=value2", logMessage.toString());
} }
@Test @Test
void toString_shouldPrintMessageAndAllKeyAndValuePairs() { void testToStringShouldPrintMessageAndAllKeyAndValuePairs() {
logMessage.setMsg(MESSAGE); logMessage.setMsg(MESSAGE);
logMessage.kv("key1", "value1"); logMessage.kv("key1", "value1");
logMessage.kv("key2", "value2"); logMessage.kv("key2", "value2");
@ -86,7 +86,7 @@ class LogMessageTest {
} }
@Test @Test
void kv2String_shouldPrintMessageAndAllKeyAndValuePairs() { void testKv2StringShouldPrintMessageAndAllKeyAndValuePairs() {
String result = logMessage.kv2String("key", "value"); String result = logMessage.kv2String("key", "value");
assertEquals("key=value", result); assertEquals("key=value", result);
} }

Loading…
Cancel
Save