04cad46100
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
bc9f8a2d8b
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
f6f8700a53
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
(cherry picked from commit a18a52e898
4 months ago
4da701593f
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit b07ab77da3
4 months ago
1a8507fd5a
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit c225c124ac
4 months ago
015531ca4f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit c33215d765
4 months ago
9db1a120f9
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit f552b67230
4 months ago
e8bfa0eed6
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit dce60adb51
4 months ago
24b44902a2
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit cda0865d64
4 months ago
7e8f53421a
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 5d9d9a0fb8
4 months ago
ea04cea48b
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
(cherry picked from commit c0f3ace52d
4 months ago
bec66098fd
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit c5249c1f8d
4 months ago
cc58e3f5a3
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.32.3` | `0.33.0` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.32.3` | `0.33.0` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.32.3` | `0.33.0` |
Updates `k8s.io/api` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/api/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiserver` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/cli-runtime` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/client-go` from 0.32.3 to 0.33.0
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/kubectl` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.3...v0.33.0 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 502c0d5f5b
4 months ago
bf1436baf3
fix: govulncheck workflow
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
(cherry picked from commit 6b15f26bd4
4 months ago
d8edc2aebc
bump version to v3.18.0
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
aa7cdae3af
Merge pull request #30818 from TerryHowe/fix-dev-v3-proxy
...
fix:add proxy support when mTLS configured
5 months ago
48377fe451
fix:add proxy support when mTLS configured
...
Signed-off-by: Rongrong Liu <lori.rongrong.liu@gmail.com>
5 months ago
adf8430f28
Merge pull request #30805 from TerryHowe/note-about-fallback
...
docs: Note about http fallback for OCI registries
5 months ago
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
5339003a66
Merge pull request #30791 from benoittgt/fix-30780
...
Bump net package to avoid CVE on dev-v3
5 months ago
f9ab8f772a
Bump net package to avoid CVE on dev-v3
...
Closes : #30780
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
5 months ago
845fb3eb86
Merge pull request #30776 from benoittgt/bump-dev-tom-dev-v3
...
[v3 backport] Bump toml
5 months ago
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
91800728e4
Merge pull request #30771 from dongjiang1989/backport-30677-to-dev-v3
...
[v3 backport] chore: Update Golang to v1.24
5 months ago
85ec62f5c8
Merge pull request #30769 from helm/dependabot/go_modules/dev-v3/github.com/rubenv/sql-migrate-1.8.0
...
build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0
5 months ago
2a5f83b960
backport #30677to dev3
...
Signed-off-by: dongjiang <dongjiang1989@126.com>
5 months ago
5df2f3018a
build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0
...
Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate ) from 1.7.2 to 1.8.0.
- [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: github.com/rubenv/sql-migrate
dependency-version: 1.8.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 months ago
9dbc049dc3
Merge pull request #30756 from helm/dependabot/go_modules/dev-v3/github.com/rubenv/sql-migrate-1.7.2
...
build(deps): bump github.com/rubenv/sql-migrate from 1.7.1 to 1.7.2
5 months ago
3538c2a677
build(deps): bump github.com/rubenv/sql-migrate from 1.7.1 to 1.7.2
...
Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate ) from 1.7.1 to 1.7.2.
- [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.1...v1.7.2 )
---
updated-dependencies:
- dependency-name: github.com/rubenv/sql-migrate
dependency-version: 1.7.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
63dd5691dc
Merge pull request #30753 from helm/dependabot/go_modules/dev-v3/golang.org/x/crypto-0.37.0
...
build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0
5 months ago
6fa95c805e
build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.36.0 to 0.37.0.
- [Commits](https://github.com/golang/crypto/compare/v0.36.0...v0.37.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.37.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
0c106e7500
Merge pull request #30750 from helm/dependabot/go_modules/dev-v3/golang.org/x/term-0.31.0
...
build(deps): bump golang.org/x/term from 0.30.0 to 0.31.0
5 months ago
741b5beeb9
build(deps): bump golang.org/x/term from 0.30.0 to 0.31.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.30.0 to 0.31.0.
- [Commits](https://github.com/golang/term/compare/v0.30.0...v0.31.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.31.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
0109c050a7
Merge pull request #30745 from benoittgt/testing-vuln
...
Bump text package with minimal impact
6 months ago
017f9fad2b
Testing text bump
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
3d490e197e
Merge pull request #30740 from benoittgt/bump-distribution-v3
...
Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0
6 months ago
666725202b
Permit more Go version and not only 1.23.8
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
4ad1ccd8fb
Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0
...
```
$ go mod download 130 ↵
go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
f494115bf0
Merge commit from fork
...
Unarchiving fix [v3]
6 months ago
3ce10e4f81
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
6 months ago
78a052cb96
Merge pull request #30689 from benoittgt/report-time-waited-v3
...
Report as debug log, the time spent waiting for resources
6 months ago
422c58e4a2
Fix typo
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
5e7f12d4c3
Report as debug log, the time spent waiting for resources
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
07a57c6073
Merge pull request #30678 from helm/dependabot/go_modules/dev-v3/github.com/containerd/containerd-1.7.27
...
build(deps): bump github.com/containerd/containerd from 1.7.26 to 1.7.27
6 months ago
dcc286ca56
build(deps): bump github.com/containerd/containerd from 1.7.26 to 1.7.27
...
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd ) from 1.7.26 to 1.7.27.
- [Release notes](https://github.com/containerd/containerd/releases )
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md )
- [Commits](https://github.com/containerd/containerd/compare/v1.7.26...v1.7.27 )
---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
009da9e5c2
Merge pull request #30296 from TerryHowe/orasv2-v3-backport
...
[v3 backport] Oras v2 v3 backport with http fallback
7 months ago
1435ec7c77
Update pkg/registry/fallback.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
Matt Farina
Brandt Keller
Brandt Keller
Benoit Tigeot
Benoit Tigeot
Scott Rigby
Matt Farina
dependabot[bot]
Matthieu MOREL
Robert Sirchia
Rongrong Liu
George Jenkins
dongjiang
Evans Mungai
Patrick Seidensal