Matt Farina
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
...
fix(lint): prevent segmentation violation on only comment yaml in multidoc
1 month ago
George Jenkins
dfa1e3c3c5
Merge pull request #31562 from atombrella/feature/modernize
...
Use modernize to use newer Golang features.
1 month ago
George Jenkins
51076a073a
Merge pull request #31519 from TerryHowe/chore-add-warning-for-registry-login
...
chore: add warning for registry login with namespace
1 month ago
Robert Sirchia
dbd07fa16c
Merge pull request #31577 from megha1906/main
...
chore: fix typo in pkg/downloader/chart_downloader.go
1 month ago
megha1906
e71a29ce4f
chore: fix typo in pkg/downloader/chart_downloader.go
...
Signed-off-by: megha1906 <meghabansal135@gmail.com>
1 month ago
Robert Sirchia
722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
1 month ago
Robert Sirchia
e824d94f74
Merge pull request #31557 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.1.0
...
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
1 month ago
Scott Rigby
4d54bea5ff
Merge pull request #31491 from benoittgt/31490-plugin-name-helper
...
feat: improve plugin name validation error messages and field name detection (v1)
1 month ago
George Jenkins
00e12b8477
Merge pull request #31560 from mattfarina/fix-kube-client-logging
...
Fix kube client logging
1 month ago
Mads Jensen
6cceead399
Use modernize to use newer Golang features.
...
The rangeint suggestion is faster.
The maps.Copy and slices.Contains are just syntatic sugar.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
Mads Jensen
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
Matt Farina
936cd328ac
Fix kube client logging
...
The kube client logging is based on the actionConfig logging. This
is setup to use slog.Default() before the logging flags are parsed
and logging is setup.
newRootCmdWithConfig changes the logging but it wasn't picked up
for actionConfig or the kube client. This change updates the logging
to include any changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Matt Farina
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
1 month ago
Matt Farina
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
1 month ago
dependabot[bot]
cb35947ae6
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](0a35821d5c...e7fa5ac41e )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-version: 9.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
bd9425c00b
Merge pull request #31550 from helm/dependabot/github_actions/main/actions/setup-go-6.1.0
...
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
1 month ago
Matt Farina
2a614eeeab
Merge pull request #31551 from helm/dependabot/github_actions/main/actions/checkout-6.0.0
...
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
1 month ago
dependabot[bot]
4fddc64678
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](93cb6efe18...1af3b93b68 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
dependabot[bot]
b87f2da2f8
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.5.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](d35c59abb0...4dc6199c7b )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: 6.1.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Benoit Tigeot
81d244ca21
fix: prevent segmentation violation on empty yaml in multidoc
...
Fixes: https://github.com/helm/helm/issues/31544
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
Matt Farina
df6aafeeee
Merge pull request #31462 from mattfarina/load-archive
...
Adding a LoadArchive to common loader
1 month ago
Matt Farina
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
1 month ago
Robert Sirchia
eb3da36e2e
Merge pull request #31530 from shuv0id/improve-debug-logging
...
fix: add missing context to debug logs
1 month ago
Robert Sirchia
47e940341f
Merge pull request #31527 from helm/dependabot/github_actions/main/actions/checkout-5.0.1
...
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
1 month ago
Robert Sirchia
c185492188
Merge pull request #31540 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.6.1
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.6.0 to 0.6.1
1 month ago
Robert Sirchia
02000f4710
Merge pull request #31542 from helm/dependabot/go_modules/golang.org/x/crypto-0.45.0
...
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
1 month ago
dependabot[bot]
c2405ce8c2
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.44.0 to 0.45.0.
- [Commits](https://github.com/golang/crypto/compare/v0.44.0...v0.45.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.45.0
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
dependabot[bot]
28baa972c1
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.6.0...v0.6.1 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.6.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
George Jenkins
63dcb5c74c
Merge pull request #31464 from benoittgt/fix-test
...
Properly test error messages on pull command's test
1 month ago
George Jenkins
a7ba4fc80e
Merge pull request #31514 from yxxhero/fix-helm-plugin-cmd-args-env-issues
...
Refactor environment variable expansion in PrepareCommands and update tests
1 month ago
Matt Farina
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
shuv0id
2dc5864f44
fix: add missing context to debug logs
...
Adds chart name to dependency logs, namespace to resource waiting logs,
and confirmation message when all resources are ready.
Addresses #31520
Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com>
1 month ago
dependabot[bot]
f6ceae9b74
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](08c6903cd8...93cb6efe18 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 5.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 months ago
George Jenkins
f8a49f1852
fixup test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
George Jenkins
a9cdc78116
logs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
George Jenkins
b1a976073f
fix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
Terry Howe
5f3c617940
chore: add warning for registry login with namespace
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 months ago
Robert Sirchia
a75fcc2948
Merge pull request #31478 from promalert/main
...
refactor: use strings.Builder to improve performance
2 months ago
Benoit Tigeot
71591ee63e
style: linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
b296cbef6c
test: split tests between valid and invalid
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
9b242dd9ed
test: convert tests to table drive tests
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Benoit Tigeot
c81a09b89a
test: refactor TestMetadataLegacyValidate to be more generic
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
yxxhero
8c87024860
update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2 months ago
George Jenkins
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
Scott Rigby
ebd5f53fc3
Merge pull request #31421 from benoittgt/improve-doc-wait-strategy
...
Unify --wait strategy inputs, clarify defaults and docs; avoid SDK timeout footgun
2 months ago
George Jenkins
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
yxxhero
2d49f0cb4a
Refactor environment variable expansion in PrepareCommands and update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2 months ago
George Jenkins
3e06a8a440
Merge pull request #31512 from benoittgt/31508-client-go
...
fix: correct LDFLAGS path for default Kubernetes version
2 months ago
Scott Rigby
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
2 months ago
Benoit Tigeot
b6a8c65216
fix: correct LDFLAGS path for default Kubernetes version
...
The Makefile LDFLAGS were pointing to an incorrect package path
(helm.sh/helm/v4/pkg/chart/common/util) that doesn't exist, causing
the k8sVersionMajor and k8sVersionMinor variables to silently fail
to be set. This left the hardcoded defaults (1.20) in place.
After this fix, `helm template` now correctly defaults to Kubernetes
v1.34.0 (matching the bundled client-go version) instead of v1.20.0,
ensuring charts render with current stable API versions.
Testing scenario:
```sh
cat > /tmp/test-chart/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart
version: 1.0.0
kubeVersion: ">= 1.28.0-0"
EOF
./bin/helm template test-release /tmp/test-chart
cat > /tmp/test-chart-fail/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart-fail
version: 1.0.0
kubeVersion: ">= 1.35.0-0"
EOF
./bin/helm template test-release /tmp/test-chart-fail
Exit code 1
Error: chart requires kubeVersion: >= 1.35.0-0 which is incompatible with Kubernetes v1.34.0
```
Fixes #31508
Closes #31501
Closes #31502
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago