Robert Sirchia
f5decfc28d
Merge pull request #30737 from rpolishchuk/investigation-pr-30610
...
fix: order dependent test
7 months ago
Robert Sirchia
90608174c5
Merge pull request #30741 from benoittgt/bump-distribution-v4
...
Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0
7 months ago
Matt Farina
7a1eb77e77
Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog
...
Migrate pkg to slog
7 months ago
Matt Farina
8c6c0d8a37
Merge pull request #30686 from mattfarina/remove-deprecated-code
...
Remove deprecated code
7 months ago
Benoit Tigeot
365340b092
Follow distribution package requirement
...
go: github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Benoit Tigeot
0d43534ab7
Testing without bump go version
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Benoit Tigeot
00db8d6d96
Go mod tidy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Benoit Tigeot
483789ac86
Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0
...
```
» go mod download
go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8
```
We need to update Go, because of https://github.com/distribution/distribution/pull/4601
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
Matt Farina
ed005f5c32
Removing deprecation notice for this function.
...
While the constructor is not used by Helm itself, it is used by SDK
users and there is currently no alternative way to expose this.
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
Matt Farina
7938662f95
Remove ValidName regex
...
This regex was already deprecated.
Validation happens inside the Metadata Validate function for the
name instead of using this regex.
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
Benoit Tigeot
68440d7b29
Prefer using slog.Any when displaying errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
c05bcbd498
Fix nil pointer dereference in ready test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
7f02e89a7a
No longer log call location using flag, it will need to be done in slog
...
Some ideas here: https://www.reddit.com/r/golang/comments/15nwnkl/achieve_lshortfile_with_slog/
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
6b5fa33633
debug log level is dynamic and set after Logger creation
...
So we should use dynamic handler to set the log level after. With this
patch we can clearly see the output. Before we were always stuck in log
level "info" and not seeing debug log level
```
bin/helm upgrade --install --debug --wait frontend \
--namespace test \
--set replicaCount=2 \
--set backend=http://backend-podinfo:9898/echo \
podinfo/podinfo
level=DEBUG msg="getting history for release" release=frontend
level=DEBUG msg="preparing upgrade" name=frontend
level=DEBUG msg="performing update" name=frontend
level=DEBUG msg="creating upgraded release" name=frontend
level=DEBUG msg="checking resources for changes" resources=2
level=DEBUG msg="no changes detected" kind=Service name=frontend-podinfo
level=DEBUG msg="patching resource" kind=Deployment name=frontend-podinfo namespace=test
level=DEBUG msg="waiting for resources" count=2 timeout=5m0s
level=DEBUG msg="waiting for resource" name=frontend-podinfo kind=Deployment expectedStatus=Current actualStatus=Unknown
level=DEBUG msg="updating status for upgraded release" name=frontend
Release "frontend" has been upgraded. Happy Helming!
NAME: frontend
LAST DEPLOYED: Thu Apr 10 09:56:25 2025
NAMESPACE: test
STATUS: deployed
REVISION: 6
DESCRIPTION: Upgrade complete
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Rostyslav Polishchuk
55eb53e3a0
fix: order dependent test
...
TestInstallRelease_Atomic_Interrupted needs the same wait
as TestInstallRelease_Wait_Interrupted (see helm/helm#12088 ).
The installation goroutine started by
TestInstallRelease_Atomic_Interrupted proceeds in the background and
may interfere with other tests (see helm/helm#30610 )
Also see helm/helm#12086 and helm/helm#12109 which are describe and address the root
cause.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
8 months ago
Matt Farina
d8ca55fc66
Merge commit from fork
...
Fix for DOS when unarchiving charts
8 months ago
Matt Farina
bbf6a91454
Merge pull request #30730 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.37.0
...
build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0
8 months ago
dependabot[bot]
db76da32ac
build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.36.0 to 0.37.0.
- [Commits](https://github.com/golang/crypto/compare/v0.36.0...v0.37.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.37.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
8 months ago
Robert Sirchia
748b78ee84
Merge pull request #30736 from robertsirc/updating-go-mod
...
manually updating go.mod file
8 months ago
Robert Sirchia
b29bc3a44d
manually updating go.mod file
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
Matt Farina
0740dfc7a9
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
8 months ago
Scott Rigby
5442c6b9cb
Merge pull request #9318 from wahabmk/fix-httpgetter
...
Fix issue with helm pull failing if pulling from a repository that redirects to another domain
8 months ago
Benoit Tigeot
0c85456788
Leverage slog.Any for errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
5c746037b3
Prevent redefining verbose flags
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
710770eed4
Linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
3e4e78378e
Go the slog way
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
6ce967391d
Trick slog to return the full error
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
5580f61157
Properly reproduce the nopLogger as before
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
baa597c567
Do not remove the functionality to print log in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
b6adbbb227
Enforce error style with others
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
83a5a14826
Properly discard by default logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
947658a96e
Explain why we ignore the timestamp
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
3db7ebc591
Fix missing logger to SQL in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
ede73860c1
Fix call to kube log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
3a22df9731
Deal with linting errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
394ba2d55e
Properly use DefaultLogger
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
eb2dfe7dbf
Some interesting rephrasing by Terry Howe
...
See: https://github.com/helm/helm/pull/30698#discussion_r2012394228
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
227d270788
Extra comment + Default logger fallback
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
b642bca8f6
Provide an adapter to easily pass a slog.Default()
...
```
helmClient.Log = NewSlogAdapter(slog.Default())
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
d6d7cff417
Try to make log more common and more easily grepable
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
8d30464f2c
Do no mask warning alerts
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
dfaf249221
Remove unreachable error
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Benoit Tigeot
f4631bf3d8
Migrate kube package to slog
...
As for helm v4. We want to migrate logs to slog.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago