Ayush Tiwari
e63cbae886
added cmd.ErrOrStderr()
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
7 months ago
Ayush Tiwari
95328ea0a6
removed error import
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
7 months ago
Ayush Tiwari
058bc083a8
changed Error to print
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
7 months ago
Robert Sirchia
ed475f286e
Merge pull request #30835 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.38.0
...
build(deps): bump golang.org/x/crypto from 0.37.0 to 0.38.0
7 months ago
dependabot[bot]
01c049c106
build(deps): bump golang.org/x/crypto from 0.37.0 to 0.38.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.37.0 to 0.38.0.
- [Commits](https://github.com/golang/crypto/compare/v0.37.0...v0.38.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.38.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
7 months ago
Robert Sirchia
76fbba2de8
Merge pull request #30836 from helm/dependabot/go_modules/main/golang.org/x/text-0.25.0
...
build(deps): bump golang.org/x/text from 0.24.0 to 0.25.0
7 months ago
George Jenkins
bff04b9606
Merge pull request #30827 from findnature/main
...
refactor: use slices.Contains to simplify code
7 months ago
dependabot[bot]
c3b83c3c40
build(deps): bump golangci/golangci-lint-action from 7.0.0 to 8.0.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](1481404843...4afd733a84 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-version: 8.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
7 months ago
dependabot[bot]
19997805a2
build(deps): bump golang.org/x/text from 0.24.0 to 0.25.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.24.0 to 0.25.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.24.0...v0.25.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.25.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
7 months ago
Matt Farina
6128122714
Merge pull request #30824 from adharsh277/fix-bug
...
Fix bug in .golangci.yml configuration
7 months ago
Adharsh
7801588957
Fix bug in .golangci.yml configuration
...
The initial configuration was missing rules that caused the linter to skip
certain important checks. This update adds the missing rules to ensure the
code quality checks are correctly enforced across the repository.
Signed-off-by: Adharsh <adharshunni0007@gmail.com>
7 months ago
Terry Howe
da579a7aa6
chore: add test coverage for time package
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
7 months ago
Terry Howe
f754e6a23b
chore: increase test coverage of time pkg
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
George Jenkins
31e22b9866
Merge pull request #30800 from mmorel-35/fix-dep-fs
...
fix: dep fs errors
7 months ago
Matthieu MOREL
15b83a9959
fix: dep fs errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Matt Farina
ab15810701
Merge pull request #30786 from mmorel-35/clean-up
...
refactor: reorganize .golangci.yml for better clarity and structure
7 months ago
Robert Sirchia
4161d77aba
Merge pull request #30803 from mattfarina/fix-errors-windows
...
Fixing windows build
7 months ago
Matt Farina
ed356cfca8
Fixing windows build
...
The package github.com/pkg/errors was removed via the pull request #13460 .
This change did not correctly handle the case in the windows code and CI
did not exercise this to find the error.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
George Jenkins
e865a0f540
Merge pull request #30801 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-0.36.0-flux.13
...
build(deps): bump github.com/fluxcd/cli-utils from 0.36.0-flux.12 to 0.36.0-flux.13
7 months ago
dependabot[bot]
ef64468187
build(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.36.0-flux.12 to 0.36.0-flux.13.
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.36.0-flux.12...v0.36.0-flux.13 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 0.36.0-flux.13
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
7 months ago
Matthieu MOREL
3270d35d3f
refactor: reorganize .golangci.yml for better clarity and structure
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
George Jenkins
ecf1730689
Merge pull request #13460 from justenstall/stdlib-errors-2
...
fix: replace "github.com/pkg/errors" with stdlib "errors" package
7 months ago
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Matt Farina
fcd37bcea7
Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence
...
fix: chart icon presence test
7 months ago
Robert Sirchia
d9bc0a948c
Merge pull request #30777 from ryanhockstad/merge-fix
...
fix: null merge. closes #30587
7 months ago
Scott Rigby
a911aa2112
Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing
...
fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
7 months ago
Joe Julian
dd0d80d246
Merge pull request #30788 from stephenpmurray/refactor/chart-not-found-error-type
...
ref(helm): Export Chart Not Found error
7 months ago
Robert Sirchia
789ce7fd10
Merge pull request #30785 from mmorel-35/fix-govulncheck
...
fix: govulncheck workflow
7 months ago
Daniel Strobusch
b183eccfc4
copy dependency metadata on aliasing to avoid sharing imported values
...
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases.
By copying the dependency objects in the metadata values can be imported correctly.
Supersedes #10174
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
7 months ago
Daniel Strobusch
df7befd208
copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
...
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.
Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.
Closes #9150
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
7 months ago
Stephen Murray
1682895636
ref(helm): Export Chart Not Found error
...
Closes #30746
Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
7 months ago
Rostyslav Polishchuk
1c8d1e375f
fix: chart icon presence test
...
The `TestValidateChartIconPresence` test fails when run after
`TestValidateChartIconURL` as they both are using a global
variable `badChart.Icon`
```
: go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 1
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
=== RUN TestValidateChartIconPresence
chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error
--- FAIL: TestValidateChartIconPresence (0.00s)
FAIL
FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s
FAIL
: go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 2
=== RUN TestValidateChartIconPresence
--- PASS: TestValidateChartIconPresence (0.00s)
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
PASS
ok helm.sh/helm/v4/pkg/lint/rules 0.050s
```
This commit:
1. Remove dependency on global variable
2. Explicitly set the state of the test object.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
7 months ago
Justen Stall
700103d76a
chore: add depguard rule for github.com/pkg/errors
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
18aae5a121
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Matthieu MOREL
a0c84b9246
fix: govulncheck workflow
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Scott Rigby
9c0d90a291
Merge pull request #30781 from mmorel-35/github.com/hashicorp/go-multierror
...
chore: remove `github.com/hashicorp/go-multierror` dependency
7 months ago
Robert Sirchia
9609005d2c
Merge pull request #30784 from scottrigby/add-terryhowe-triage-maintainer
...
chore(OWNERS): Add TerryHowe as Triage Maintainer
7 months ago
Scott Rigby
33f5e9d0f4
chore(OWNERS): Add TerryHowe as Triage Maintainer
...
Adding @TerryHowe to OWNERS file as Triage Maintainer, as agreed by
supermajority vote by core maintainers.
- Nomination email (public Helm mailing list):
https://lists.cncf.io/g/cncf-helm/topic/nominating_terry_howe_as_a/112379173
- Voting email (provate Helm core mailing list):
https://lists.cncf.io/g/cncf-helm-core-maintainers/topic/voting_for_terry_howe_as/112379286
Welcome, @TerryHowe! Glad to have you on board ☺️
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Justen Stall
fc6c5e5edb
remove WaitAndGetCompletedPodPhase function
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
73545f9a3e
one more test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
4a6092bd6c
update another test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
6c3fc1d755
Merge pull request #1 from justenstall/stdlib-errors-2-lint-issues
...
Fix lint issues
7 months ago
Matthieu MOREL
d3eeb2c942
chore: remove github.com/hashicorp/go-multierror dependency
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
7 months ago
Scott Rigby
eb6e240cfe
Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs
...
feat(pkg/engine): add support for custom template funcs
7 months ago