rohansood10
dbfbea91e3
fix: correct import comment in statuswait.go from v3 to v4
...
The import comment in pkg/kube/statuswait.go still referenced
helm.sh/helm/v3/pkg/kube while all other files in the package
correctly reference helm.sh/helm/v4/pkg/kube. This mismatch
causes downstream processing errors (e.g. kythe) when vendoring
Helm.
Fixes #31846
Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
(cherry picked from commit c59c140ce0 )
1 month ago
dependabot[bot]
099192c285
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.35.0` | `0.35.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.35.0` | `0.35.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.35.0` | `0.35.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.35.0` | `0.35.1` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.35.0` | `0.35.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.35.0` | `0.35.1` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.35.0` | `0.35.1` |
Updates `k8s.io/api` from 0.35.0 to 0.35.1
- [Commits](https://github.com/kubernetes/api/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/apiextensions-apiserver` from 0.35.0 to 0.35.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/apimachinery` from 0.35.0 to 0.35.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/apiserver` from 0.35.0 to 0.35.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/cli-runtime` from 0.35.0 to 0.35.1
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/client-go` from 0.35.0 to 0.35.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.0...v0.35.1 )
Updates `k8s.io/kubectl` from 0.35.0 to 0.35.1
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.35.0...v0.35.1 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.35.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 0b134362f4 )
1 month ago
Pedro Tôrres
4967ead762
add image index test
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
(cherry picked from commit e8f386b5aa )
1 month ago
Pedro Tôrres
2fe6b106e6
fix pulling charts from OCI indices
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
(cherry picked from commit d983696e35 )
1 month ago
Evans Mungai
e3e2d01ef4
fix: handle OCI digest algorithm prefix in chart downloader ( #31601 )
...
* fix: strip digest algorithm prefix before hex decoding
OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add cmd test for OCI references with tag+digest
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Move oci registry push result to a struct
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Review comments from PR review
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Fix failing test
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
(cherry picked from commit ee018608f6 )
1 month ago
Manuel Alonso
c15e7114dc
fix(install): check nil for restClientGetter and fix tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 9817a68618 )
1 month ago
Manuel Alonso
df82e68ce1
chore(refactor): better testing and functionality for installing crd
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 6501ef490a )
1 month ago
Manuel Alonso
4b896ca82f
fix(test): fix tests and check nil for restclient
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 0f949a92c1 )
1 month ago
Manuel Alonso Gonzalez
3fc79399c8
fix(test): merge fix correctly
...
Signed-off-by: Manuel Alonso Gonzalez <434575+manute@users.noreply.github.com>
Signed-off-by: Manuel Alonso Gonzalez <m.alonso@Manuels-MacBook-Pro.local>
(cherry picked from commit 561410ae1d )
Signed-off-by: Scott Rigby <scott@r6by.com>
1 month ago
Manuel Alonso
6017d2b470
fix(install): add more tests and check nil file data
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 00f0a48a7d )
1 month ago
Manuel Alonso
f451967ab5
fix(test): no check empty resources
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 0357e8d0f7 )
1 month ago
Manuel Alonso
fdadff59eb
fix(install): check lenght and file nil, add tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 52235cc0bf )
1 month ago
Manuel Alonso
10d6067265
fix(action): crd resources can be empty
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 268593bf2e )
1 month ago
Mujib Ahasan
0fec40f9b6
fix: casing issue fixed
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 170911459b )
1 month ago
Mujib Ahasan
263749874c
fix: error handled correctly
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 94860626ce )
1 month ago
Mujib Ahasan
961d7d7cd6
fix: doc string added
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 12e8b715aa )
1 month ago
Mujib Ahasan
29e45067f3
update: test coverage added for helper function validateNameAndGenerateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 115409976b )
1 month ago
Mujib Ahasan
d55b0b9022
update: helper function added for the business logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 522d2fe615 )
1 month ago
Mujib Ahasan
c1c090e8ce
generateName is also considered in logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 6769fb6fb6 )
1 month ago
Mujib Ahasan
5e093136f4
update: business logic respected for skipping object missing name
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit b357bcae86 )
1 month ago
Mujib Ahasan
f289d1605c
fixed: --dry-run=server now respect generateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
(cherry picked from commit 2820ebe8c9 )
1 month ago
Orgad Shaneh
bfac7393e4
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
(cherry picked from commit 76eb37c01a )
1 month ago
Matheus Pimenta
5caf0044d4
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Matheus Pimenta
2519a88b0b
bugfix(kstatus): do not wait forever on failed resources
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Matheus Pimenta
b2c487c436
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Philipp Born
261387a112
fix(copystructure): handle nil elements in slice copying
...
When copying slices containing nil interface{} elements, the copyValue
function would panic with 'reflect: call of reflect.Value.Set on zero
Value'. This occurred because reflect.ValueOf(nil) returns a zero Value
that cannot be set.
This issue was introduced in v4.1.0 when replacing mitchellh/copystructure
with an internal implementation. The fix mirrors the existing nil handling
logic used for map values.
Fixes helm template panic when processing charts with YAML like:
extraArgs:
-
Added test case to verify slice elements with nil values are properly
handled during deep copy operations.
Signed-off-by: Philipp Born <git@pborn.eu>
3 months ago
Scott Rigby
4553a0a96e
Merge pull request #31706 from matheuscscp/custom-kstatus-readers
...
pkg/kube: introduce support for custom kstatus readers
3 months ago
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Evans Mungai
3120e88f9b
Merge pull request #31713 from helm/dependabot/go_modules/main/golang.org/x/term-0.39.0
...
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
3 months ago
dependabot[bot]
de0becdc57
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/term/compare/v0.38.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.39.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Evans Mungai
951c630e2c
Merge pull request #31712 from helm/dependabot/go_modules/main/golang.org/x/text-0.33.0
...
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
3 months ago
dependabot[bot]
46e52649ea
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.32.0...v0.33.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Evans Mungai
b07261c045
Merge pull request #31710 from banjoh/em/fix-test-compilation-error
...
fix(release): fix test compilation error
3 months ago
Evans Mungai
e751a70e84
fix(release): fix test compilation error
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Evans Mungai
2e2cb05855
Merge pull request #31427 from tisonkun/resolve-todo
...
Check plugin name is not used
3 months ago
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
...
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
3 months ago
Evans Mungai
c3a0d3b860
Merge pull request #31698 from sarfraj89/fix-shellcheck-lint
...
Lint sync-repo.sh with ShellCheck
3 months ago
Sarfraj Khan
9125b84f45
Suppress SC2154 without changing behavior
...
Signed-off-by: Sarfraj Khan <try.sarfraj@gmail.com>
3 months ago
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
3 months ago
Terry Howe
8fcb7d1f63
Merge pull request #31700 from helm/dependabot/go_modules/main/github.com/foxcpp/go-mockdns-1.2.0
...
chore(deps): bump github.com/foxcpp/go-mockdns from 1.1.0 to 1.2.0
3 months ago
dependabot[bot]
0e0c02e6a7
chore(deps): bump github.com/foxcpp/go-mockdns from 1.1.0 to 1.2.0
...
Bumps [github.com/foxcpp/go-mockdns](https://github.com/foxcpp/go-mockdns ) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/foxcpp/go-mockdns/releases )
- [Commits](https://github.com/foxcpp/go-mockdns/compare/v1.1.0...v1.2.0 )
---
updated-dependencies:
- dependency-name: github.com/foxcpp/go-mockdns
dependency-version: 1.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
sarfraj89
d4a2787fca
Lint sync-repo.sh with ShellCheck
...
Signed-off-by: sarfraj89 <try.sarfraj@gmail.com>
4 months ago
Terry Howe
08f17fc947
Merge pull request #31683 from majiayu000/fix-13198---api-versions-is-undocumented-1230-2329
...
fix: `--api-versions` is undocumented
4 months ago
George Jenkins
90a550098b
Merge pull request #31673 from jylenhof/main
...
docs(README): add mise alternate installation documentation
4 months ago
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
Add tests to action package to improve coverage
4 months ago
Terry Howe
ca45f8c719
Merge pull request #31685 from atombrella/feature/reflect_pointer
...
Replace reflect.Ptr with reflect.Pointer
4 months ago
Scott Rigby
9de23eada9
Merge pull request #31687 from banjoh/em/move-evans-from-triage-to-maintainers
4 months ago
Terry Howe
bed5b732ba
Merge pull request #31684 from Skarlso/fix-function-naming
...
fix: typo in the function names
4 months ago
Evans Mungai
fd090cce0c
chore: move Evans Mungai from triage to maintainers
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago