She Jiayu
d141593d83
Avoid hardcoded container port in default notes
...
Signed-off-by: She Jiayu <shejiayu1998@qq.com>
4 years ago
Martin Hickey
241785c70f
Merge pull request #8476 from sshine/sshine-happy-helming
...
Alter whitespace in "Update Complete" output
4 years ago
Simon Shine
844e575d2a
Alter whitespace in "Update Complete" output
...
Most places say "Happy Helming!".
But pkg/downloader/manager.go also says "⎈Happy Helming!⎈"
Signed-off-by: Simon Shine <simon@simonshine.dk>
4 years ago
Matt Farina
6a536661fc
Merge pull request #8462 from donggangcj/master
...
fix(create): update the hook name of test-connection pod
4 years ago
Martin Hickey
ae8fcf445d
Merge pull request #8425 from wawa0210/feature-8370
...
Rollback command support for max history
4 years ago
Dong Gang
9777925a2a
fix(create): update the hook name of test-connection pod
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
4 years ago
Matthew Fisher
e31818f2ef
Merge pull request #8452 from bridgetkromhout/reinstate-comment
...
Reinstating comment that is still accurate
4 years ago
Bridget Kromhout
c709e10b32
Reinstating comment that is still accurate
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Matt Farina
bf96db7e8a
Merge pull request #8443 from bridgetkromhout/clarify-comments
...
Clarify comments to match practice
4 years ago
Matt Farina
a2d11c9288
Merge pull request #8444 from bridgetkromhout/capabilities
...
Fixing version and spelling errors
4 years ago
Matt Farina
325bed7268
Merge pull request #8445 from bridgetkromhout/fix-makefile
...
Correct make target in Makefile
4 years ago
wawa0210
4be3804c50
Rollback command support for max history
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Matthew Fisher
9c0fca9aeb
Merge pull request #7322 from cristiklein/fix/less-corruption-with-concurrent-executions
...
fix(helm): Avoid corrupting storage via a lock
4 years ago
Cristian Klein
0d70c63396
fix(helm): Update test during pending install
...
Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
4 years ago
Bridget Kromhout
08517a9ec0
Correct make target in Makefile
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Cristian Klein
20fb7bac4e
fix(helm): Added test for concurrent upgrades
...
Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
4 years ago
Cristian Klein
9a4f4ec64b
fix(helm): Avoid corrupting storage via a lock
...
If two `helm upgrade`s are executed at the exact same time, then one of
the invocations will fail with "already exists".
If one `helm upgrade` is executed and a second one is started while the
first is in `pending-upgrade`, then the second invocation will create a
new release. Effectively, two helm invocations will simultaneously
change the state of Kubernetes resources -- which is scary -- then two
releases will be in `deployed` state -- which can cause other issues.
This commit fixes the corrupted storage problem, by introducting a poor
person's lock. If the last release is in a pending state, then helm will
abort. If the last release is in a pending state, due to a previously
killed helm, then the user is expected to do `helm rollback`.
Closes #7274
Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
4 years ago
Bridget Kromhout
5684c86490
Fixing version and spelling errors
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Bridget Kromhout
fe40c4bf84
Clarify comments to match practice
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Martin Hickey
298f574606
Merge pull request #8437 from hiddeco/kube/log-printf
...
fix(kube): use logger instead of fmt.Printf
4 years ago
Michelle Noorali
f90e5ba316
Merge pull request #8414 from michelleN/emeritus
...
chore(OWNERS): move michelleN to emeritus
4 years ago
Hidde Beydals
8217aba4a6
fix(kube): use logger instead of fmt.Printf
...
Signed-off-by: Hidde Beydals <hello@hidde.co>
4 years ago
Matthew Fisher
7dd42d7c06
Merge pull request #8432 from jrweldon/fix/windows-build-failure
...
fix windows build failure caused by #8431
4 years ago
Jack Weldon
7ba8343b8d
fix windows build failure caused by #8431
...
No longer using the 'syscall' package, as further reading into this
issue has shown that 'syscall' is deprecated/locked down. Additional
issues posted on Golang's github indicates that the newer preferred
mechanism to get the file descriptor for stdin is: int(os.Stdin.Fd())
Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
4 years ago
Matthew Fisher
0f43a819c5
Merge pull request #8431 from jrweldon/feat/prompt-for-password
...
feat(helm): prompt for password with helm repo add
4 years ago
Jack Weldon
ac1a25517b
address PR comment, adding whitespace for formatting
...
Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
4 years ago
Jack Weldon
971c9215d1
feat(helm): prompt for password with helm repo add
...
Previously in Helm 2, 'helm repo add' would prompt for your password if
you only provided the --username flag. This helps prevent someone's
credentials from being logged in their shell's history, from showing
up in process lists, and from being seen by others nearby.
Closes #7174
Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
4 years ago
Matt Butcher
2750e4d781
Lint dependencies ( #7970 )
...
* feat: add dependency tests
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* replaced on-disk fixtures with in-memory fixtures
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Martin Hickey
bd09f1fbec
Merge pull request #8369 from wawa0210/fix-8367
...
Environment variable for setting the max history for an environment
4 years ago
wawa0210
637a5c6494
Environment variable for setting the max history for an environment
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Michelle Noorali
ebe6abd660
chore(OWNERS): move michelleN to emeritus
...
Thank you.
Signed-off-by: Michelle Noorali <michellemolu@gmail.com>
4 years ago
Matthew Fisher
bf9c64f48e
Merge pull request #7013 from SimonAlling/isChartInstallable
...
Simplify chart installable check
4 years ago
Matthew Fisher
3c9099290b
Merge pull request #7184 from zwwhdls/fix6116
...
fix stack overflow error in helm template.
4 years ago
Matthew Fisher
bdce9739da
Merge pull request #8411 from bacongobbler/bump-version-v3.3
...
bump version to v3.3
4 years ago
Matthew Fisher
fc4a11c131
bump version to v3.3
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
(cherry picked from commit 5c2dfaad84
)
4 years ago
Matthew Fisher
d61aaf3fd7
Merge pull request #7235 from karuppiah7890/fix-lint
...
Show errors when linting for Chart.yaml version and appVersion fields of type non-string
4 years ago
Matthew Fisher
fc6d6d3605
Merge pull request #6979 from lindhe/explain_revision_version_in_get
...
Add comments about release Version variable
4 years ago
Matthew Fisher
e7ab975112
Merge pull request #8142 from technosophos/feat/1990-match-labels-lint
...
feat: Detect missing selector during lint
4 years ago
DongGang
ceff32d5f8
fix(template):Issue:helm template with --output-dir ( #8156 )
...
* fix(template):Issue:helm template with --output-dir doesn't write template with a hook to file
Close #7836
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
* fix go file style
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
* fix go file style
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
4 years ago
Matthew Fisher
e0c0233515
Merge pull request #8270 from ShenXinKang/master
...
fix template command use --show-only flags error in windows environment
4 years ago
Matthew Fisher
1eebcf3ef6
Merge pull request #8314 from VilledeMontreal/feat/completionSubcommands
...
feat(cmd): Subcommands for the completion command
4 years ago
Matthew Fisher
cac773bcff
Merge pull request #8364 from VilledeMontreal/feat/compRollbackRev
...
Complete revision parameter for rollback command
4 years ago
Matthew Fisher
c92dea210b
Merge pull request #8403 from bridgetkromhout/milestone-update
...
Updating for today's actual milestone practices
4 years ago
Bridget Kromhout
3d05f96b7e
Adding v4 link
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
Bridget Kromhout
4ad76e1be2
Updating for today's actual milestone practices
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4 years ago
zwwhdls
d58a984878
fix conflict
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
4 years ago
zwwhdls
1b39857ac3
add test case
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
4 years ago
zwwhdls
4532485fd0
fix another extreme case
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
4 years ago
zwwhdls
c41c72cee9
add test case
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
4 years ago
zwwhdls
5396df2e28
fix #6116
...
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
4 years ago