Mathieu Parent
dbb4eb6b75
Ensure RawPath match Path when resolving reference
...
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
4 years ago
Josh Dolitsky
cd27cf660f
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
17ed9c4cd3
tweak basic handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 years ago
Josh Dolitsky
4e7a01fa7a
Merge branch 'main' of github.com:helm/helm into hip-6
4 years ago
Martin Hickey
281380f31c
Merge pull request #9659 from mladedav/feature/upgrade-dep-up
...
Feature/upgrade dep up
4 years ago
Martin Hickey
ed7b6c4761
Merge pull request #8470 from mikeshng/sql-query-fix
...
fix(sql storage): Query() should return ErrReleaseNotFound immediately when no records are found
4 years ago
Josh Dolitsky
00985cad6b
Implement changes proposed in HIP 6
...
For more information, please see the following URL:
https://github.com/helm/community/blob/main/hips/hip-0006.md
Note: OCI support remains experimental, and you are still
required to set HELM_EXPERIMENTAL_OCI=1 in your environment.
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
yxxhero
20e2aec793
Add a more friendly prompt when index.yaml is empty.
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Martin Hickey
dffc2a30c7
Merge pull request #9035 from wizbit/fail-message
...
Fail message is now the same as the required message.
4 years ago
Martin Hickey
699ea6dcef
Merge pull request #9066 from scaat/fix-specification
...
[FIX]Unified go specification
4 years ago
Martin Hickey
599c071ac7
Merge pull request #9681 from cndoit18/add-max-col-width-parameters
...
support max-col-width parameters
4 years ago
Martin Hickey
e87f815637
Merge pull request #9756 from codeJack/fix-issue-9749
...
Fix coalesce globals to prevent subchart globals to leak upstream
4 years ago
Martin Hickey
c1d4cf0861
Merge pull request #9030 from yxxhero/helm_dep_build_update_inherit_insecure_skip_tls_verify_from_helm_repo_add
...
fix helm dep build/update doesn't inherit --insecure-skip-tls-verify from helm repo add
4 years ago
Giacomo Margaria
3b68afc1c8
Fix coalesce globals to prevent subchart globals to leak upstream
...
Signed-off-by: Giacomo Margaria <giacomo.margaria@gmail.com>
4 years ago
Matt Farina
3415b6e7b8
bump version to v3.6.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit af0feeddd91c729aa97327f33c9e3e3109b13561)
4 years ago
Matt Farina
d4cc130fa9
Merge pull request #9621 from sagikazarmark/ingress-v1
...
Ingress v1 template
4 years ago
Matt Farina
8f4989054c
Merge pull request #9040 from thatsmydoing/helm3-kube-version
...
feat(helm): Support setting --kube-version
4 years ago
Matt Farina
3f283c7c35
Merge pull request #9425 from joelanford/pkg-ready
...
Add ReadyChecker to decouple ready check logic from --wait
4 years ago
cndoit18
a79cad5539
support max-col-width parameters
...
support commands:
- helm chart list
- helm dependency list
Signed-off-by: cndoit18 <cndoit18@outlook.com>
4 years ago
David Mládek
d6eab46876
Add --udpate-dependencies to upgrade command
...
Signed-off-by: David Mládek <david.mladek.cz@gmail.com>
4 years ago
Mark Sagi-Kazar
d5b4e1c5b8
chore: update testdata to use the new ingress template
...
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
4 years ago
Mark Sagi-Kazar
6d9e15bd1a
feat: add networking.k8s.io/v1 support to ingress template
...
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
4 years ago
Cookie Wang
8959d93711
Add error check to avoid panic
...
Signed-off-by: Cookie Wang <wangchl01@inspur.com>
4 years ago
shoubhik
257a427866
upgrade to kubernetes 1.21
...
Signed-off-by: shoubhik <shbose@redhat.com>
4 years ago
Thomas Dy
0156ca61ca
Fix capabilities changes leaking into other tests
...
Signed-off-by: Thomas Dy <thatsmydoing@gmail.com>
4 years ago
Thomas Dy
538670fda6
Add tests for template --kube-version
...
Signed-off-by: Thomas Dy <thatsmydoing@gmail.com>
4 years ago
Thomas Dy
47c8f48f20
feat(helm): Support setting --kube-version
...
Signed-off-by: Thomas Dy <thatsmydoing@gmail.com>
4 years ago
Adam Reese
db2aa1a8d6
fix(ci) update ci to use main branch
...
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Joe Lanford
98d98369ed
Add ReadyChecker to decouple ready check logic from --wait
...
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
4 years ago
Adam Reese
213a7df2dc
Merge pull request #9416 from croomes/resource-name-validation
...
Add name validation rules for different object kinds
4 years ago
Simon Croome
c50372a8c1
Add/update deprecation notices
...
Signed-off-by: Simon Croome <simon.croome@storageos.com>
4 years ago
Simon Croome
6c82c83b3a
Wrap validation error instead of recreating
...
Signed-off-by: Simon Croome <simon.croome@storageos.com>
4 years ago
Simon Croome
54de1c1f25
Move default to avoid nil check
...
Signed-off-by: Simon Croome <simon.croome@storageos.com>
4 years ago
Simon Croome
ba325bdf7e
Add name validation rules for object kinds
...
Signed-off-by: Simon Croome <simon@croome.org>
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Simon Croome <simon.croome@storageos.com>
4 years ago
Josh Dolitsky
617c9e1b12
Merge pull request #9313 from jmcelwain/master
...
wait-for-job with backoff limit 0
4 years ago
Josh Soref
2bf8fdf45d
chore: Spelling ( #9410 )
...
* spelling: annotate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: asserts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: behavior
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: binary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contain
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: copied
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: depending
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: deprecated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesn't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: donot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: github
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: inputting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabberwocky
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: length
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mismatch
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: outputs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: panicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: plugins
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: porthos
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: regular
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resource
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: strict
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: string
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
4 years ago
yxxhero
f735a240b6
fix helm dep build/update doesn't inherit --insecure-skip-tls-verify from helm repo add
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Matt Farina
bfb6bb7af9
Merge pull request #9381 from joelanford/darwin-arm64
...
Add darwin/arm64 (Apple Silicon) support
4 years ago
Matthew Luckam
592c338242
updated unit tests to conform with helm best practices
...
Signed-off-by: Matthew Luckam <Matthew.Luckam@peraton.com>
4 years ago
Matthew Luckam
f402994461
corrected order of helm lint coalescing of multiple values files
...
Signed-off-by: Matthew Luckam <Matthew.Luckam@peraton.com>
4 years ago
Josh Dolitsky
158d7df5f5
Merge pull request #9409 from searsaw/fix/ocigetter-registryclient
...
initialize registry client in oci getter
4 years ago
Martin Hickey
3e31983a37
Merge pull request #8559 from zsuzhengdu/f/improve-console-output-for-resource-policy-keep
...
Improve the console output for resource policy keep to align with helm2.
4 years ago
Alex Sears
1c377f8c62
add test to ensure OCIGetter registryClient is set
...
Signed-off-by: Alex Sears <me@alexsears.com>
4 years ago
Alex Sears
2d16a8135b
initialize registry client in oci getter
...
Signed-off-by: Alex Sears <me@alexsears.com>
4 years ago
Marc Khouzam
593b267ed5
feat(comp): Add descriptions for output format
...
Ref: HIP 0008
When completing output formats, extra information will be shown
for shells that support completions (fish, zsh). For example:
$ helm status -o <TAB>
json -- Output result in JSON format
table -- Output result in human-readable format
yaml -- Output result in YAML format
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
Matt Farina
85794cfc6e
Merge pull request #9131 from dlipovetsky/check-cleanup-error
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Joe Lanford
f57c01cd93
update test expectation for new template error string
...
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
4 years ago
Adam Reese
6ce9ba60b7
Merge pull request from GHSA-c38g-469g-cmgx
...
fix(*): Validate metadata semver and printable characters
4 years ago
Adam Reese
657ce552cb
fix(*): Validate metadata semver and printable characters
...
ref: https://github.com/helm/helm/security/advisories/GHSA-c38g-469g-cmgx
* Skip invalid chart versions when reading the repository index file or
when programmatically adding a chart version.
* Adds semver validation and strips non-printable characters and
normalizes spaces for string fields in Metadata.Validate()
* Fixes a unit test that was pulling a remote repo. Now uses a local
repo.
* Fixes ignored error in repo update command
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
James McElwain
54410194a6
closes #9312
...
Because backOffLimit can be 0, a zero value for pod status failed will
always cause the condition to return true.
Signed-off-by: James McElwain <jmcelwain@gmail.com>
4 years ago
Josh Dolitsky
0b2fec08ac
Upgrade to oras v0.9.0 ( #9269 )
...
* Upgrade to oras v0.9.0
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
* fix test-style
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Nick Jones
042567808f
Update default ingress values section to correspond with template
...
This commit updates the default section in values.yaml for the example
ingress definition to correspond with the template.
Signed-off-by: Nick Jones <nick@dischord.org>
4 years ago
Matt Farina
e8ac5b0aeb
Merge pull request #9200 from mattfarina/fix-dep-build
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
1135392b48
Fix dep build with OCI based charts
...
The recent addition of oci:// to specify dependencies in the
Chart.yaml dependencies and with helm pull missed handling for the
dependency build command. This command was failing to handle OCI.
This change adds support for the dep build command following the
same pattern used to add oci:// functionality.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
4bbdd5cb8f
Merge pull request #9195 from mattfarina/bump-version-3.5
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Guangwen Feng
fee2257e34
Fix typo in comment
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
4 years ago
Matt Farina
8082f6db45
bump version to
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit f546ebb1ac
)
4 years ago
Joe Julian
fdcd22ef58
Reduce linting severity for users of out-of-date kubernetes ( #8608 )
...
* Reduce linting severity for users of out-of-date kubernetes
Fixes #8596
Signed-off-by: Joe Julian <me@joejulian.name>
* add more verbose deprecation info
Signed-off-by: Joe Julian <me@joejulian.name>
* use new upstream deprecations
Signed-off-by: Joe Julian <me@joejulian.name>
* do not error for custom resources
Signed-off-by: Joe Julian <me@joejulian.name>
* Define deprecation version in lint rules by LDFLAG
Signed-off-by: Joe Julian <me@joejulian.name>
* make comment clearer
Signed-off-by: Joe Julian <me@joejulian.name>
* Extend the k8s version discovery and constants to chartutil
Signed-off-by: Joe Julian <me@joejulian.name>
* remove awk dependency
Signed-off-by: Joe Julian <me@joejulian.name>
* align k8s version constant names between capabilities.go and deprecations.go
Signed-off-by: Joe Julian <me@joejulian.name>
* show the error if the unexpected happens
Signed-off-by: Joe Julian <me@joejulian.name>
* bump k8sVersionMinor and golden chart templates for k8s 1.20
Signed-off-by: Joe Julian <me@joejulian.name>
* bump for tests to match 1.20.1
Signed-off-by: Joe Julian <me@joejulian.name>
4 years ago
Matt Farina
49f895db6b
Merge pull request #8843 from bloodorangeio/oci-pull
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Daniel Lipovetsky
1da2212a9d
Add explanatory comments to action.List and action.History
...
While the comments may seem to state the obvious to someone with helm CLI
experience, an SDK-first user may find these comments helpful.
Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
4 years ago
Daniel Lipovetsky
00cf10d360
fix(pkg/storage): If storage.Create fails to clean up recent release versions, return an error
...
Previously, storage.Create was ignoring the error. This meant that a user that
relied on the recent release version cleanup would not be notified if that
cleanup failed, and release versions could grow without bound.
Closes #9145
Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
4 years ago
Daniel Lipovetsky
8c28da6567
test(pkg/storage): Verify that storage.Create returns an error if it fails to clean up least-recent release versions
...
Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
4 years ago
Peter Engelbert
beda5e1e2b
Address error on deletion of old dependencies
...
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
4 years ago
Martin Hickey
ba9cad9379
Merge pull request #8484 from chriswells0/subset
...
feat: Allow helm test to run a subset of tests
4 years ago
Matt Farina
f5ef87b96e
Merge pull request #8363 from zh168654/master
...
helm upgrade with --wait support jobs in manifest to be completed
4 years ago
Dinu Mathai
a202fb0c0b
Fixed bug - The flags --cert-file/--key-file where ignored when --insecure-skip-tls-verify flag is set ( #9070 )
...
* fix: Fixed bug - The flags --cert-file/--key-file where ignored when --insecure-skip-tls-verify flag is set
Signed-off-by: Dinu Mathai <Dinu.Mathai1@T-Mobile.com>
* fix: Added unit test
Signed-off-by: Dinu Mathai <Dinu.Mathai1@T-Mobile.com>
4 years ago
Marc Khouzam
bed1a42a39
fix(pkg/chartutil): Remove warning for nils
...
Nil tables should not be reported as non-tables.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
Matt Farina
fb0345a07f
Updating to sprig 3.2.0
...
Note, randInt is now a function in sprig so the failing test needed
to be updated to a function that does not exist.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Peter Engelbert
f666fceb30
Remove OCI boolean from struct
...
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
4 years ago
Peter Engelbert
3028c55858
Clean up imports and add doc comments
...
Additionally, revert `NewPull()` to its existing signature.
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
4 years ago
Peter Engelbert
3ad08f3ea9
Implement `helm pull` for OCI registries
...
* Implement `helm dep update` for oci dependencies
* New unit tests
* Remove `helm chart pull` command
* New `helm pull` does not depend on registry cache
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
4 years ago
Lüchinger Dominic
cc1d2d62e9
Adds the option kube-cafile and env variable HELM_KUBECAFILE for a overwrite of the certificate authority file
...
Signed-off-by: Lüchinger Dominic <dev@snowgarden.ch>
4 years ago
Marcus Speight
7a663a56c2
Fixed Test
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
Signed-off-by: Marcus Speight <marcus@pmconnect.co.uk>
4 years ago
Marcus Speight
8aa42824f9
Added test for lint mode
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Matthew Fisher
976d668dec
Merge pull request #9048 from MaXinjian/install
...
Cleanup tempfiles introduced by unit tests under pkg/
4 years ago
Matthew Fisher
f228a7c36c
Merge pull request #9057 from ssalaues/fix/ingress-templating-error
...
fix: ingress path issue
4 years ago
rimas
f30badd570
Fix test
...
Signed-off-by: rimas <rmocius@gmail.com>
4 years ago
rimas
ce1a46899f
Fixes #9083
...
Signed-off-by: rimas <rmocius@gmail.com>
4 years ago
Scaat Feng
89f2f84a02
[FIX]error string should not be capitalized
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
9020c95fb1
[FIX]comment should start with whitespace
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
f1f2e6ff4c
[FIX]comment should start with whitespace
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
1852694a65
[FIX]comment should start with whitespace
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
14f6bde04a
[FIX]error string should not be capitalized
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
0de89685d4
[COMMENT]fix comment
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
b6bd8d7363
[FIX]'rest' collides with imported package name
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Scaat Feng
5c14eec3a3
[FIX]receiver names are different
...
Signed-off-by: Scaat Feng <scaat.feng@gmail.com>
4 years ago
Jon Huhn
5d08a0d00e
Fix typo
...
Signed-off-by: Jon Huhn <huhnjon@gmail.com>
4 years ago
Salim Salaues
50144aad03
fix: ingress path issue
...
Signed-off-by: Salim Salaues <salim@openinvest.co>
4 years ago
Ma Xinjian
1aa6e928ce
Cleanup tempfiles introduced by unit tests under pkg/
...
Signed-off-by: Ma Xinjian <maxj.fnst@cn.fujitsu.com>
4 years ago
Marcus Speight
7a0739a863
Fail message is now the same as the required message.
...
Fixed #8973 Helm function 'fail' should not fail when doing 'helm lint'
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
4 years ago
Matt Farina
1cd749359c
Merge pull request #9009 from mattfarina/tests-for-8948
...
Tests for 8948
4 years ago
Matt Farina
a374fffdd9
Merge pull request #8948 from gy-lehel/#7696
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
82002c3cfb
Added tests for PR 8948
...
LoadFiles needs to load the Chart.yaml file first. When later files
are loaded there are checks for metadata. If that is not loaded
the checks could be handled incorrectly.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Martin Hickey
0ba4fcba87
Merge pull request #8862 from banzaicloud/linter-multiple-documents
...
lint: lint all documents in a multi-doc yaml file
4 years ago
Martin Hickey
6696a9fa5f
Merge pull request #8970 from zerefwayne/patch-8965
...
Add remaining tests in TestDependentChartAliases
4 years ago
Nandor Kracser
dfb5a5e8cc
lint: lint all documents in a multi-doc yaml file
...
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
4 years ago
Martin Hickey
6ca989e777
Merge pull request #8913 from cvila84/fork-lint-bug
...
do not check YAML if nothing was parsed
4 years ago
Marc Khouzam
e16d26717b
fix(helm): flag descriptions start with lowercase
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
Martin Hickey
9c97dc8fa2
Merge pull request #8933 from wawa0210/fix-helm-package-escape-invalid-version
...
Fix invalid semver version number of the helm package command will escape
4 years ago
zh168654
bfc575dec2
add waitwithjobs instead of changing wait api
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
957d2a2bf9
add wait-for-jobs flag
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zhangye15
bd03e1b5c7
fix style conformance
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zhangye15
c96dc48f21
fix test-style error
...
Signed-off-by: zhangye15 <zhangye15@baidu.com>
4 years ago
zh168654
8d498d58e7
add test cases
...
Signed-off-by: zh168654 <zhangye.168@163.com>
4 years ago
zh168654
5825112a8b
helm upgrade with --wait support jobs in manifest to be completed
...
Signed-off-by: zh168654 <zhangye15@baidu.com>
4 years ago
Aayush Joglekar
babc8c9a70
Add remaining tests in TestDependentChartAliases
...
Signed-off-by: Aayush Joglekar <aayushjog@gmail.com>
4 years ago
Martin Hickey
9aa0fbee6c
Merge pull request #8879 from hickeyma/fix/incorrect-lint-msg
...
fix(lint): Lint error message for valid names
4 years ago
Chris Wells
2a7a98ae5a
feat: Allow helm test to run a subset of tests
...
Signed-off-by: Chris Wells <chriswells0@users.noreply.github.com>
4 years ago
wawa0210
2c19838295
Fix that the invalid version number of the helm package command will escape
...
Signed-off-by: wawa0210 <xiaozhang0210@hotmail.com>
4 years ago
Du Zheng
87040536fb
Improve the console output for resource policy keep to align with helm2.
...
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
4 years ago
Matt Farina
43b0ef5f20
Merge pull request #8855 from janario/fix/reusabe-kube-client
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
af2d3021f4
Merge pull request #8952 from mattfarina/fix-8940
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
c0d3877231
Merge pull request #8915 from zheng1/master
...
Bugfix: panic when chart contains requirements.lock
4 years ago
Zhengyi Lai
9cc00eea24
Add test case for LoadFiles
...
Signed-off-by: Zhengyi Lai <zheng1@yunify.com>
4 years ago
Matt Farina
882db2543c
Fixes Error: could not find protocol handler for
...
A previous update to automate finding charts in repos when update
was run did not take into account the case for no repo being
specified. This fixes that situation.
Closes #8940
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Lehel Gyuro
27807e1bb5
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
Christophe VILA
8a4c0bc7b1
added test for https://github.com/helm/helm/pull/8913 related to https://github.com/helm/helm/issues/8621
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Lehel Gyuro
8abb44f218
[ #7696 ] Avoid crash in chart loader on unexpected file sequence
...
Make sure, that chart metadata is initialized by the time the processing
of the chart is started.
Signed-off-by: Lehel Gyuro <lehel@freemail.hu>
4 years ago
Martin Hickey
b83632e757
Update err message to use the regex pattern directly
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Martin Hickey
5785dd6d49
Fix the lint error message for valid names
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Christophe VILA
f736af95eb
do not check YAML if nothing was parsed
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Matt Farina
ce4fa95868
bump version to v3.4.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7090a89efc
)
4 years ago
Matt Farina
75b7aeaeeb
Merge pull request #7024 from jan25/issue-6972
...
v3: Prettify Updated time in helm list
4 years ago
Matt Butcher
fe2d7f7792
this rewrites a whole bunch of old repo URLs to the new repo URL ( #8902 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
5f3e560029
improved user-facing error messages to explain the underlying problem ( #8731 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Martin Hickey
8667aa4f98
Merge pull request #8874 from consideRatio/pr/helm-create-template-indentation
...
helm create: make generated YAML indentation more consistent
4 years ago
Matthew Fisher
e73af10d0b
Merge pull request #8696 from f0rmiga/patch-1
...
fix: boilerplate template indentation
4 years ago
Erik Sundell
1d9767fea2
helm create: make generated YAML indentation more consistent
...
Signed-off-by: Erik Sundell <erik@sundellopensource.se>
4 years ago
Janario Oliveira
cf3870a57f
Adjusted import
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Janario Oliveira
10a29d1662
Reuse kube-client
...
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
4 years ago
Matt Farina
6297c021cb
Merge pull request #8795 from mattfarina/feat-8767
...
Adding annotation to index.yaml file
4 years ago
Mikuláš Dítě
6aa54eacc5
feat(install): add requested version to error
...
Signed-off-by: Mikuláš Dítě <dite@mangoweb.cz>
4 years ago
Matt Farina
593fec6868
Merge pull request #8807 from mattfarina/feat-8806
...
Adding support for k8s 1.19
4 years ago
zouyu
a167b3fc87
Fix wrong function's name in comment
...
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
4 years ago
Matt Farina
b7c38c879a
Adding support for k8s 1.19
...
Closes #8806
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Abhilash Gnan
3ca46f3b23
remove redudant time func
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Abhilash Gnan
c5e9732a9f
rename to time format flag
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Abhilash Gnan
f61332f379
add time-format flag to list command
...
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
4 years ago
Matt Farina
4c121c3085
Adding annotation to index.yaml file
...
Chart.yaml files have an annotation field that allow a chart to
have custom information similar to the way Kubernetes annotations
work.
In an index.yaml file each chart version can have annotations in
a similar manner to the Chart.yaml file. It is derived from the
same underlying struct.
These enable extension points where people can add their own info.
One thing missing is the ability to extend the top level of an
index file. This change adds annotations to the top level of an
index.yaml file. This would provide top level support for vendors
to extent index.yaml files.
Closes #8767
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Mike Ng
3be333b73b
keep existing behavior of returning ErrReleaseNotFound when release(s) failed to decode
...
Signed-off-by: Mike Ng <ming@redhat.com>
4 years ago
Matthew Fisher
b0fdb5461f
Merge pull request #8244 from carlpett/report-findcharturl-error
...
Report what cause finding chart to fail
4 years ago
Sebastian Sdorra
467bd49bb0
support passing signing passphrase from file or stdin ( #8394 )
...
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
4 years ago
Matthew Fisher
f19acbdc94
fix: allow serverInfo field on index files
...
A recent change merged into Helm fixes a number of security issues related to parsing malformed index files. Unfortunately, it also broke the ability for users to load index files from chartmuseum, which adds a "server info" field to add additional metadata.
This commit adds that field so that index files from chartmuseum can be validated. Since Helm does not use this field for anything, the information is discarded and unused.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
6eeec4a002
switched to stricter YAML parsing on plugin metadata files
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matt Butcher
809e2d999e
Merge pull request from GHSA-m54r-vrmv-hw33
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
055dd41cbe
Merge pull request from GHSA-jm56-5h66-w453
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
59d5b94d35
Merge pull request from GHSA-9vp5-m38w-j776
4 years ago
Matthew Fisher
aa5431ab71
Merge pull request #8751 from technosophos/fix/helm-create-overwrite
...
fixed bug that caused helm create to not overwrite modified files
4 years ago
Matthew Fisher
2a74204508
go fmt
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
84de24edc9
Merge pull request #8752 from technosophos/fix/better-http-plugin-checks
...
improve the HTTP detection for tar archives
4 years ago
Matt Farina
7953adb06c
Merge branch 'master' into fix/helm-create-overwrite
4 years ago
Matt Butcher
e2da16f514
improve the HTTP detection for tar archives
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
b5daf5a484
Merge pull request #8753 from technosophos/fix/dependency-status
...
handle case where dependency name collisions break dependency resolution
4 years ago
Matt Farina
11f75e420c
Merge pull request #8750 from technosophos/fix/helm-create-name
...
validate the name passed in during helm create
4 years ago
Matt Butcher
40b7800287
handle case where dependency name collisions break dependency resolution
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
106f1fb45c
fixed bug that caused helm create to not overwrite modified files
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
ed5fba5142
refactor the release name validation to be consistent across Helm
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Thulio Ferraz Assis
b4bb73d8ce
fix: if not .Values.autoscaling.enabled indent
...
Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
4 years ago
Matt Butcher
c4ef82be13
validate the name passed in during helm create
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matthew Fisher
55fbd985dd
Merge pull request #8707 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
4 years ago
Matthew Fisher
dafeb1541b
Merge pull request #8493 from yxxhero/fix-insecure-skip-tls-verify-flag-not-work-on-helm-install
...
fix insecure-skip-tls-verify flag does't work on helm install
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Li Zhijian
4258e8664e
Use T.cleanup() to cleanup cmdtest_temp file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
d9ad9153c8
Use RemoveAll to remove a non-empty directory
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
cccc2867ea
mark NewTempServer as Deprecated
...
Please use NewTempServerWithCleanup instead
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
35c5268d9d
Use T.Cleanup() to cleanup temp dir helm-repotest
...
For backward compatibility, as suggested by @bacongobbler, we introduce
a new API NewTempServerWithCleanup
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
leigh capili
9429af8b39
Support impersonation via flags similar to kubectl --as="user"
...
Signed-off-by: leigh capili <leigh@null.net>
4 years ago
Li Zhijian
ba4c8029c2
Use T.cleanup() to cleanup helm-action-test
...
T.Cleanup() is introduced since go-1.14
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Thulio Ferraz Assis
6766017d38
fix: with .Values.podAnnotations indent template
...
Signed-off-by: Thulio Ferraz Assis <thulio.assis@suse.com>
4 years ago
Martin Hickey
daa104d60e
Revert PR 8562
...
Revert of PR 8562 as the container version may not represent the
application version.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4 years ago
Matt Farina
e454e6a910
Merge pull request #8682 from liuming-dev/remove-duplicate-variable-definition
...
Remove duplicate variable definition
4 years ago
Martin Hickey
2a9ef6d3b0
Merge pull request #8529 from lingsamuel/status-show-desc
...
feat: add flag `--show-desc` to display description for `helm status`
4 years ago
Ling Samuel
da6878dc0f
feat: status command display description
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
4 years ago
Liu Ming
317616482c
Remove duplicate variable definition
...
Variable values `helm.sh/resource-policy` and `keep` are duplicately
defined in resource_policy.go (`resourcePolicyAnno` `keepPolicy`) and
resource_policy.go (`ResourcePolicyAnno` `KeepPolicy`), remove the
varibales in resource_policy.go to keep the code clean.
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
4 years ago
Matt Butcher
04fb35814f
Fixed a variable name collision caused by two PR merges ( #8681 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
70d03e5cef
Fix/8467 linter failing ( #8496 )
...
* add output to get debug info on linter failing
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* trap cases where the YAML indent is incorrect.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
96d9ab9663
fix name length check on lint ( #8543 )
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Zhou Hao
0669f40e81
cleanup tempfiles for load_test
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
4 years ago
Matt Farina
3fc88f2492
Fixing failing CI for windows
...
A fix introduced in #8631 caused a bug in Windows builds due to
a type difference between POSIX and Windows environments. This
change corrects that problem and provides a code comment to warn
others.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
0a28e5cbff
Merge pull request #8631 from mrueg/sem-fixes
...
pkg/*: Small linting fixes
4 years ago
Matt Farina
c7b5f5f88f
Merge pull request #8627 from mattfarina/fix-6418
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Manuel Rüger
4abcdc40ef
pkg/*: Small linting fixes
...
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
4 years ago
Matthew Fisher
0941e3e345
Merge pull request #8613 from tariq1890/if-optimise
...
optimise if condition in service ready logic
4 years ago
Matt Farina
11f658e223
Fixing linting of templates on Windows
...
When the engine stored templates in the map the keys were generated
based on path and not filepath. filepath was being used in the linter
when retrieving content from the keys. On Windows the keys ended up
being different.
This change is to use path joins to create the lookup key. Since the
name path was used in the code it needed to be changed in order to
import the package.
Tests already exist and were failing on windows. This got in because
CI is not run on Windows.
Closes #6418
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
198f403688
Merge pull request #8590 from Foxboron/morten/fix-go1.15
...
release/mock: Ensure conversion from int to string yields a string
4 years ago
Tariq Ibrahim
b07b2589fb
optimise if condition in service ready logic
...
Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
4 years ago
Matthew Fisher
bb33b9264f
Merge pull request #8507 from rajatjindal/fix-watch-timeout-error
...
fix watch error due to elb/proxy timeout
4 years ago
Martin Hickey
273d0364be
Merge pull request #8532 from dm3ch/labels-selector
...
Adding filtering of helm releases for configmap and secret backends during list command
4 years ago
Morten Linderud
83a5e620d0
release/mock: Ensure conversion from int to string yields a string
...
With the release of go 1.15, the test-suite doesn't pass as `go test` got
a new warning for improper `string(x)` usage.
https://golang.org/doc/go1.15#vet
$ make test-unit
# helm.sh/helm/v3/pkg/release
pkg/release/mock.go:56:27: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
[snip]
make: *** [Makefile:82: test-unit] Error 2
This patch changes ensures we are utilizing `fmt.Sprint` instead as
recommended.
Signed-off-by: Morten Linderud <morten@linderud.pw>
4 years ago
Martin Hickey
91094186eb
Merge pull request #8562 from andytom/chore/update_starter_chart
...
Update Common Lables template in starter chart
4 years ago
Thomas O'Donnell
4b1fa60d58
Update Common Lables template in starter chart
...
Have update the Common Labels template in the starter chart so that the
value for the `app.kubernetes.io/version` is set to the same value as
the image tag used in the deployment.
Signed-off-by: Thomas O'Donnell <andy.tom@gmail.com>
4 years ago
Martin Hickey
621c2020c6
Merge pull request #8505 from jiayushe/master
...
Avoid hardcoded container port in default notes
4 years ago
Martin Hickey
a5047b2f6c
Merge pull request #8438 from donggangcj/feature/support-jsonpath
...
feature(show): support jsonpath output for `helm show value`
4 years ago
yxxhero
0674d93609
add helm v4 todo comments for FindChartInAuthAndTLSRepoURL.
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Dong Gang
df4708a9de
polish the error handler
...
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
4 years ago
Dmitry Chepurovskiy
266c74f390
Move selector filtering after latest release version filtering
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago
Dmitry Chepurovskiy
2ea8f805b9
Added testing for list action with selector
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago
Dmitry Chepurovskiy
09172b468a
Fix linting issues
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago
Dmitry Chepurovskiy
357a0785bc
Added selector filtering
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago
Dmitry Chepurovskiy
99bd709530
Pass labels from secret/configmap to release object
...
Signed-off-by: Dmitry Chepurovskiy <dm3ch@dm3ch.net>
4 years ago