Eng Zer Jun
2e3e22a003
test: use `T.TempDir` to create temporary test directory
...
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
3 years ago
stephanECD
0361dc8568
Add IngressClass to manifests to be (un)installed
...
Signed-off-by: StephanECD <87023735+stephanECD@users.noreply.github.com>
3 years ago
Martin Hickey
df7c1c39bc
Merge pull request #10514 from tanguofu/main
...
fea(#10511 ): add --post-renderer-args to support assign args to PostR…
3 years ago
Matt Farina
1ec0aacb88
Merge pull request #10486 from gridai/fix-install-leak
...
Fix install memory/goroutine leak
3 years ago
Josh Dolitsky
59dbda915f
Merge pull request #10558 from sabre1041/bearer-token-oci
...
Management of bearer tokens for tag listing
3 years ago
guofutan
04e79e936d
fix: fix args name in postrender/exec_test.go and error if order in postRendererArgsSlice
...
Signed-off-by: guofutan <guofutan@tencent.com>
3 years ago
guofutan
d12170b3f2
fix: change postRendererArgs to Slice Type and use args...
...
Signed-off-by: guofutan <guofutan@tencent.com>
3 years ago
guofutan
44423fb2ca
fix: keep the API: postrender.NewExec and Add NewExecWithArgs
...
Signed-off-by: guofutan <guofutan@tencent.com>
3 years ago
guofutan
1aab7eb3a1
fix: keep the API: postrender.NewExec and Add NewExecWithArgs
...
Signed-off-by: guofutan <guofutan@tencent.com>
3 years ago
guofutan
46222c5c00
fea( #10511 ): add --post-renderer-args to support assign args to PostRenderer exec
...
Signed-off-by: guofutan <guofutan@tencent.com>
3 years ago
Martin Hickey
9975d62525
Handle Hungarian notation issue
...
Issue with smallCaps combination e.g. kCaFile
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
3 years ago
Martin Hickey
f0fd37d2c5
Replace golint with revive
...
golint which is used as one of the sublinters in golangci-lint is deprecated.
It is replaced with revive which is a drop-in replacement.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Co-authored-by: Martin Mulholland <mmulholl@redhat.com>
3 years ago
Josh Dolitsky
86a94f2f53
Merge pull request #10578 from sabre1041/oci-tag-evaluation
...
Limits need to call tag API when explicit version specified
3 years ago
Andrew Block
0677a156bc
Limits need to call tag API when explicit version specified
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Martin Hickey
21952fccc4
Merge pull request #10574 from Juneezee/refactor/os.ReadDir
...
refactor: use `os.ReadDir` for lightweight directory reading
3 years ago
Eng Zer Jun
e12f3570b5
refactor: use `os.ReadDir` for lightweight directory reading
...
`os.ReadDir` was added in Go 1.16 as part of the deprecation of `ioutil`
package. It is a more efficient implementation than `ioutil.ReadDir` as
stated here https://pkg.go.dev/io/ioutil#ReadDir .
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
3 years ago
Andrew Block
c8a2559236
Management of bearer tokens for tag listing
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Matt Farina
0c8320b685
bump version to v3.8.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit d493f29c32
)
3 years ago
David Peraza
9661e39dce
Moving uploader and pusher out of action into pkg
...
Signed-off-by: David Peraza <dperaza@redhat.com>
3 years ago
David Peraza
7cab1a09e3
Move all the remainder module out of experimental.
...
All the experimental modules were moved to pkg/action
Signed-off-by: David Peraza <dperaza@redhat.com>
3 years ago
David Peraza
9f869c6b21
Removing all the checks for oci experimental flag
...
Signed-off-by: David Peraza <dperaza@redhat.com>
3 years ago
Thomas Runyon
91a46ad14f
move paths for updated directory location
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
3 years ago
Thomas Runyon
353d74e967
refactor internal/experimental/registry to pkg/registry
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
3 years ago
Matt Farina
548ec55cf9
Fix panic with OCI for install, upgrade, and show
...
When range support for OCI went in via #10527 it created a situation
where some lookups for a chart could cause a panic. This change
makes sure the registry client is available to lookup OCI charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Scott Rigby
ee382eb169
Remove unneeded assignment
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
1a9cb93551
Handling name of OCI file
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
23989f9e24
Updates to chart downloader
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
ba4020770e
Fix linting
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
4d50526a2b
Move OCI tag semver range logic from OCIGetter to ChartDownloader
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Matt Farina
c7b2a9d487
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
1fabbabae9
Fix Trim to TrimPrefix
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
39792b5ad0
Revert "It appears we never got to this block below. Quick rec by Farina. Untested if necessary"
...
This reverts commit f616a01808da3428c6191e5196f32ca72eb22254.
Removing for now until we know we need it.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
16453c372c
It appears we never got to this block below. Quick rec by Farina. Untested if necessary
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Martin Hickey
292368a64d
Merge pull request #10209 from yxxhero/fix_sa_issue
...
Add more debug msg when helm upgrade
3 years ago
yxxhero
f82896b0b5
add more debug msg when helm upgrade
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
Matt Farina
ee73a0263c
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
mengjiao.liu
160da867d0
validate release name during install
...
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
3 years ago
jayonlau
55bb6c307a
lean up extra spaces
...
Although these errors are not important, they affect the code specification.
Signed-off-by: jayonlau <jayonlau@gmail.com>
3 years ago
Neven Miculinic
5059ae843e
Fix install memory/goroutine leak
...
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
3 years ago
Jerome Küttner
9a492f8240
Channel should remain open if there is still a routine that wants to write into it
...
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Jerome Küttner
ad3d2cc8ef
Fix memory leak in upgrade action
...
fixes helm/helm#10439
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
Matthew Fisher
5d47255a3d
Merge pull request #10230 from yxxhero/fix_sdk_namespace_issue
...
add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
3 years ago
Matthew Fisher
67f92d63fa
Merge pull request #9640 from wangchenglong01/wangchl01
...
Add error check to avoid panic
3 years ago