cfe8cef46f
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
f17db66a34
Merge pull request #30906 from TerryHowe/backport-tag-fix
...
[v3 backport] Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
9 months ago
c33215d765
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
f552b67230
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow
...
fix(client): allow layer selection permissive
10 months ago
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url
...
Fix 3.18.0 regression: registry login with scheme
10 months ago
a18a52e898
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
10 months ago
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
10 months ago
c225c124ac
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
10 months ago
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987
...
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
10 months ago
d5391ea603
Merge pull request #30886 from benoittgt/fix-30876
...
Log warning when platformCommand|Hook and Command|Hook are set
10 months ago
dce60adb51
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
10 months ago
cda0865d64
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
10 months ago
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
10 months ago
e6122aba27
Merge pull request #30870 from helm/dependabot/go_modules/dev-v3/k8s-io-d6f802ad31
...
build(deps): bump the k8s-io group with 7 updates
10 months ago
5b0520d6b3
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.33.0` | `0.33.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.33.0` | `0.33.1` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.33.0` | `0.33.1` |
Updates `k8s.io/api` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/api/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiextensions-apiserver` from 0.33.0 to 0.33.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apimachinery` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiserver` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/cli-runtime` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/client-go` from 0.33.0 to 0.33.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/kubectl` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.33.0...v0.33.1 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
dc9d5c0cfc
Merge pull request #30852 from shfc/fix/add-warning
...
fix: add warning when ignore repo flag
10 months ago
afefca8b2d
chore: update generalization warning message
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
10 months ago
29571c5592
Merge pull request #30858 from helm/dependabot/go_modules/dev-v3/oras.land/oras-go/v2-2.6.0
...
build(deps): bump oras.land/oras-go/v2 from 2.5.0 to 2.6.0
10 months ago
8d6d27c26a
build(deps): bump oras.land/oras-go/v2 from 2.5.0 to 2.6.0
...
Bumps [oras.land/oras-go/v2](https://github.com/oras-project/oras-go ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/oras-project/oras-go/releases )
- [Commits](https://github.com/oras-project/oras-go/compare/v2.5.0...v2.6.0 )
---
updated-dependencies:
- dependency-name: oras.land/oras-go/v2
dependency-version: 2.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
86fd0fdb69
Merge pull request #30797 from helm/dependabot/go_modules/dev-v3/k8s-io-1e1c2be46d
...
build(deps): bump the k8s-io group with 7 updates
10 months ago
502c0d5f5b
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.32.3` | `0.33.0` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.32.3` | `0.33.0` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.32.3` | `0.33.0` |
Updates `k8s.io/api` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/api/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiserver` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/cli-runtime` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/client-go` from 0.32.3 to 0.33.0
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/kubectl` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.3...v0.33.0 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
e5ac62b510
Merge pull request #30840 from helm/dependabot/go_modules/dev-v3/golang.org/x/crypto-0.38.0
...
build(deps): bump golang.org/x/crypto from 0.37.0 to 0.38.0
10 months ago
92be9ac0c8
build(deps): bump golang.org/x/crypto from 0.37.0 to 0.38.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.37.0 to 0.38.0.
- [Commits](https://github.com/golang/crypto/compare/v0.37.0...v0.38.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.38.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
27ce355907
Merge pull request #30856 from gjenkins8/gjenkins/backport_30785
...
fix: govulncheck workflow [v3 backport]
10 months ago
eb5b6d5047
fix: move warning to top of block
...
Emit the warning first to ensure it's always logged. This clarifies that any following errors are due to using a local chart instead of a remote repository.
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
10 months ago
6b15f26bd4
fix: govulncheck workflow
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
10 months ago
6b5c94475d
fix: replace fmt warning with slog
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
10 months ago
247bf7c2e0
fix: add warning when ignore repo flag
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
10 months ago
b4e06a11d2
Merge pull request #30658 from helm/gjenkins/backport_12912
...
[v3 backport] feat: add httproute from gateway-api to create chart template
10 months ago
a69eaf6098
Merge pull request #30764 from nvanthao/backport-30673
...
v3 backport: Process all hook deletions on failure
10 months ago
021bcada55
Merge pull request #30834 from helm/bump-version-v3.18
...
bump version to v3.18.0
10 months ago
94044595c7
bump version to v3.18.0
...
(cherry picked from commit 74c3d1dc0de0335f941362c80447871e7d6bc78e)
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
10 months ago
aa7cdae3af
Merge pull request #30818 from TerryHowe/fix-dev-v3-proxy
...
fix:add proxy support when mTLS configured
10 months ago
48377fe451
fix:add proxy support when mTLS configured
...
Signed-off-by: Rongrong Liu <lori.rongrong.liu@gmail.com>
10 months ago
adf8430f28
Merge pull request #30805 from TerryHowe/note-about-fallback
...
docs: Note about http fallback for OCI registries
10 months ago
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
5339003a66
Merge pull request #30791 from benoittgt/fix-30780
...
Bump net package to avoid CVE on dev-v3
11 months ago
f9ab8f772a
Bump net package to avoid CVE on dev-v3
...
Closes : #30780
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
11 months ago
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
11 months ago
845fb3eb86
Merge pull request #30776 from benoittgt/bump-dev-tom-dev-v3
...
[v3 backport] Bump toml
11 months ago
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
11 months ago
91800728e4
Merge pull request #30771 from dongjiang1989/backport-30677-to-dev-v3
...
[v3 backport] chore: Update Golang to v1.24
11 months ago
85ec62f5c8
Merge pull request #30769 from helm/dependabot/go_modules/dev-v3/github.com/rubenv/sql-migrate-1.8.0
...
build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0
11 months ago
2a5f83b960
backport #30677to dev3
...
Signed-off-by: dongjiang <dongjiang1989@126.com>
11 months ago
5df2f3018a
build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0
...
Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate ) from 1.7.2 to 1.8.0.
- [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: github.com/rubenv/sql-migrate
dependency-version: 1.8.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
11 months ago
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
11 months ago
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
11 months ago
Matt Farina
George Jenkins
Benoit Tigeot
Scott Rigby
Brandt Keller
Brandt Keller
Robert Sirchia
Benoit Tigeot
Matt Farina
dependabot[bot]
Feng Cao
Matthieu MOREL
Rongrong Liu
Terry Howe
dongjiang
Evans Mungai
Patrick Seidensal