msb-public/helm - helm - 马士兵教育代码仓库

Commit Graph

Author	SHA1	Message	Date
Matt Farina	ca8eae9361	Reproducible chart archive builds Building the same chart into an archive multiple times will have the same sha256 hash. Perviously, the time in the headers for a file was time.Now() which changed each time. The time is now collected from the operating system when the file is loaded and this time is used. Fixes: #3612 Signed-off-by: Matt Farina <matt.farina@suse.com>	6 months ago
Scott Rigby	f4c5220d99	Merge pull request #31411 from banjoh/em/reinstate-logger-param feat: reinstate logger parameter to actions package	6 months ago
Evans Mungai	2ddeb50fa6	Set default logger in Configuration constructor Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	a112bf5aa6	Remove non-reachable code Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Matt Farina	1da2b0a6d4	Merge pull request #31204 from benoittgt/fix-31202 Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema	6 months ago
Robert Sirchia	25ad74f5a7	Merge pull request #31337 from rachelvweber/rawo/fixingWaitStrategy Fixing rollback and uninstall client WaitStrategy	6 months ago
Evans Mungai	aed687eaa1	Add config options to NewConfiguration() Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	b6eca1c0f1	Refactor logging functionality to use slog.Handler Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	5ab4ca5490	Embed logging functionality to DRY code Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	9c32e34d60	Add logger to sql driver and ensure storage has logger Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	50e43f4017	nil logger should be handled by discard handler Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	7a5816b106	Self review changes Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Evans Mungai	0f90c83118	Merge remote-tracking branch 'upstream/main' into em/reinstate-logger-param	6 months ago
Evans Mungai	b1d4dc680d	feat: reinstate logger parameter to actions package Fixes: #31399 Signed-off-by: Evans Mungai <mbuevans@gmail.com>	6 months ago
Matt Farina	76e6b7a6fe	Merge pull request #31390 from TerryHowe/chore-increase-helm-list-test-coverage fix: improve pkg/cmd/list test coverage	6 months ago
Matt Farina	2cfd41ec28	Merge pull request #31351 from gjenkins8/gjenkins/helm_version_kubeversion feat: `helm version` print Kubernetes (client-go) version	6 months ago
Matt Farina	752354074c	Merge pull request #31393 from benoittgt/12299 Return errors during upgrade when the deletion of resources fails	6 months ago
Matt Farina	37de51428c	Merge pull request #31376 from benoittgt/accept-yaml-yml Do not ignore .yml file on linting while accepting .yaml	6 months ago
Matt Farina	b0247ce8bf	Merge pull request #31395 from wyrapeseed/main chore: fix some comment format	6 months ago
Jesse Simpson	3f860e83fb	fix: use empty results instead of nil Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	7 months ago
Jesse Simpson	96b4c363c8	fix: Update returns nil on error, test should reflect this Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	7 months ago
Terry Howe	917822cfca	refactor: remove unused err from pkg/registry/client.go Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
wyrapeseed	b9eadd3186	chore: fix some comment format Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>	7 months ago
Benoit Tigeot	7097c8e2e5	Replicate as unit test case where we fail once a resource deletion Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	7 months ago
Benoit Tigeot	054eabddd7	Return errors on upgrade when deletion fails This is a rebase of https://github.com/helm/helm/pull/12299 as the pull request was tagged for Helm v4. Closes: https://github.com/helm/helm/issues/11375 Related: https://github.com/helm/helm/pull/7929 It was a pain to reproduce, here is a script: ``` set -u NS=default RELEASE=test-release CHART=./test-chart SA=limited-helm-sa HELM=${HELM:-./bin/helm} echo "Helm: $($HELM version)" echo "Cleaning…" $HELM uninstall "$RELEASE" -n "$NS" >/dev/null 2>&1 \|\| true kubectl -n "$NS" delete sa "$SA" role "${SA}-role" rolebinding "${SA}-rb" >/dev/null 2>&1 \|\| true kubectl -n "$NS" delete cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1 \|\| true rm -rf "$CHART" /tmp/limited-helm-kubeconfig echo "Create minimal chart with only a CronJob" $HELM create "$CHART" >/dev/null rm -f "$CHART"/templates/{deployment.yaml,service.yaml,hpa.yaml,tests/test-connection.yaml,serviceaccount.yaml} cat > "$CHART/templates/cronjob.yaml" <<'YAML' apiVersion: batch/v1 kind: CronJob metadata: name: {{ include "test-chart.fullname" . }}-cronjob spec: schedule: "/5 * * " jobTemplate: spec: template: spec: restartPolicy: OnFailure containers: - name: hello image: busybox command: ["/bin/sh","-c","date; echo Hello from CronJob"] YAML echo "RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs" kubectl -n "$NS" apply -f - >/dev/null <<EOF apiVersion: v1 kind: ServiceAccount metadata: name: $SA --- apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: name: ${SA}-role rules: - apiGroups: [""] resources: ["secrets","configmaps"] verbs: ["get","list","watch","create","patch","update","delete"] - apiGroups: [""] resources: ["pods","events"] verbs: ["get","list","watch"] - apiGroups: ["batch"] resources: ["cronjobs"] verbs: ["get","list","watch","create","patch","update"] EOF kubectl -n "$NS" apply -f - >/dev/null <<EOF apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: name: ${SA}-rb subjects: - kind: ServiceAccount name: $SA roleRef: apiGroup: rbac.authorization.k8s.io kind: Role name: ${SA}-role EOF echo "Create kubeconfig for that SA" TOKEN=$(kubectl -n "$NS" create token "$SA") SERVER=$(kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}') CA_DATA=$(kubectl config view --minify --raw -o jsonpath='{.clusters[0].cluster.certificate-authority-data}') KCFG=/tmp/limited-helm-kubeconfig cat > "$KCFG" <<EOF apiVersion: v1 kind: Config clusters: - name: local cluster: server: $SERVER certificate-authority-data: $CA_DATA contexts: - name: limited context: cluster: local namespace: $NS user: $SA current-context: limited users: - name: $SA user: token: $TOKEN EOF set +e echo "Install (as limited SA)" KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS" --wait echo "CronJob after install:" kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" \|\| true echo "Remove CronJob from chart and add a small ConfigMap to force an upgrade" rm -f "$CHART/templates/cronjob.yaml" cat > "$CHART/templates/configmap.yaml" <<'YAML' apiVersion: v1 kind: ConfigMap metadata: name: {{ include "test-chart.fullname" . }}-config data: hello: world YAML echo "Upgrade without CronJob (as limited SA)" KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS" RC=$? echo "Post-upgrade verification" if kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1; then echo "OK: Stale CronJob still present: $RELEASE-test-chart-cronjob" else echo "NO_OK: CronJob deleted" fi echo "Helm exit code: $RC" exit 0 ``` With the current build: ```sh ./reproduce-helm-issue.sh Helm: version.BuildInfo{Version:"v4.0+unreleased", GitCommit:"f19bb9cd4c99943f7a4980d6670de44affe3e472", GitTreeState:"dirty", GoVersion:"go1.24.0"} Cleaning… Create minimal chart with CronJob + ConfigMap (we will remove both in v2) RBAC: allow Helm storage + delete for configmaps, but NO delete on cronjobs Create kubeconfig for that SA Install v1 (as limited SA) Release "test-release" does not exist. Installing it now. NAME: test-release LAST DEPLOYED: Tue Oct 14 18:55:57 2025 NAMESPACE: default STATUS: deployed REVISION: 1 DESCRIPTION: Install complete TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT Verify v1 objects exist NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE test-release-test-chart-cronjob /5 * * * * <none> False 0 <none> 0s NAME DATA AGE test-release-test-chart-config 1 0s Prepare v2: remove BOTH CronJob and ConfigMap from the chart Upgrade to v2 (as limited SA) — expecting CronJob delete first, then ConfigMap - CronJob delete should FAIL (no delete permission) - ConfigMap delete should SUCCEED (delete allowed) — proves 'continue on error' and inverted order level=DEBUG msg="getting history for release" release=test-release level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="preparing upgrade" name=test-release level=DEBUG msg="getting last revision" name=test-release level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="number of dependencies in the chart" dependencies=0 level=DEBUG msg="determined release apply method" server_side_apply=true previous_release_apply_method=ssa level=DEBUG msg="performing update" name=test-release level=DEBUG msg="creating upgraded release" name=test-release level=DEBUG msg="creating release" key=sh.helm.release.v1.test-release.v2 level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="using server-side apply for resource update" forceConflicts=false dryRun=false fieldValidationDirective=Strict upgradeClientSideFieldManager=false level=DEBUG msg="checking resources for changes" resources=0 level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-config kind=ConfigMap level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob level=DEBUG msg="failed to delete resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob error="cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\"" level=INFO msg="update completed" created=0 updated=0 deleted=1 level=WARN msg="update completed with errors" errors=1 level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v1 level=WARN msg="upgrade failed" name=test-release error="failed to delete resource test-release-test-chart-cronjob: cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\"" level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v2 Error: UPGRADE FAILED: failed to delete resource test-release-test-chart-cronjob: cronjobs.batch "test-release-test-chart-cronjob" is forbidden: User "system:serviceaccount:default:limited-helm-sa" cannot delete resource "cronjobs" in API group "batch" in the namespace "default" Post-upgrade verification Stale CronJob still present: test-release-test-chart-cronjob (expected if delete is forbidden) ConfigMap deleted as expected: test-release-test-chart-config (and after CronJob attempt) Helm exit code: 1 ``` With last version v3.19: ``` HELM=/usr/local/bin/helm ./reproduce-helm-issue.sh Helm: version.BuildInfo{Version:"v3.19.0", GitCommit:"3d8990f0836691f0229297773f3524598f46bda6", GitTreeState:"clean", GoVersion:"go1.24.7"} Cleaning… Create minimal chart with only a CronJob RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs Create kubeconfig for that SA Install (as limited SA) Release "test-release" does not exist. Installing it now. NAME: test-release LAST DEPLOYED: Tue Oct 14 19:07:01 2025 NAMESPACE: default STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT CronJob after install: NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE test-release-test-chart-cronjob /5 * * * <none> False 0 <none> 0s Remove CronJob from chart and add a small ConfigMap to force an upgrade Upgrade without CronJob (as limited SA) Release "test-release" has been upgraded. Happy Helming! NAME: test-release LAST DEPLOYED: Tue Oct 14 19:07:01 2025 NAMESPACE: default STATUS: deployed REVISION: 2 TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT Post-upgrade verification OK: Stale CronJob still present: test-release-test-chart-cronjob Helm exit code: 0 ``` Co-authored-by: dayeguilaiye <979014041@qq.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	7 months ago
Terry Howe	3b2fd17799	chore: rename test registry Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Terry Howe	379b0899b3	fix: increase helm list test coverage Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
George Jenkins	7dd2484aed	Merge pull request #31295 from TerryHowe/fix-make-helm-list-show-all-by-default Fix make helm list show all by default	7 months ago
Scott Rigby	f0530309f0	Merge pull request #31302 from TerryHowe/fix-helm-verify-signature fix: helm verify Run signature	7 months ago
Scott Rigby	f9d4373ea4	Merge pull request #31270 from TerryHowe/chore-registry-clean-up chore: registry utils clean up	7 months ago
Terry Howe	abdf6603c0	fix test for rebase Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Matt Farina	a03e8c9541	Merge pull request #31375 from TerryHowe/fix-release-info-time fix: release info time parsing	7 months ago
Terry Howe	f6e60138e8	Update pkg/cmd/list.go Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Terry Howe	c3aa5c51e6	chore: clean up for comments Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
copilot-swe-agent[bot]	b4f932a715	Fix test by making date sorting stable and updating golden files Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Terry Howe	8a73d97984	fix: make helm list show all by default Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Dirk Müller	9cd40c612a	Avoid accessing .Items on nil object When listing fails for whatever reason, the return value is nil, err. so handle err explicitly. Signed-off-by: Dirk Müller <dirk@dmllr.de>	7 months ago
Benoit Tigeot	06188f9dfe	Add test for isYamlFileExtension functions Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	7 months ago
Terry Howe	20eb6e9b04	fix: empty time values Signed-off-by: Terry Howe <terrylhowe@gmail.com>	7 months ago
Matt Farina	fbf02e494e	Merge pull request #30980 from gjenkins8/gjenkins/cleanup_kubeclient_interfaces cleanup: Remove/consolidate redundant kube client Interfaces	7 months ago
Matt Farina	78cd44bd75	Merge pull request #30712 from gjenkins8/gjenkins/cleanup_lint_template cleanup: Remove extra lint/rules.Template functions	7 months ago
Matt Farina	24159ec8b6	Moving new default accessor functions to internal per feedback Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	fb20e96a56	Adding a test/example for the release accessor Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	ab6e7fa58b	Removing debug statement Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	a229bf6529	Ensure the release interface is used in actions instead of the type Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	9c958dec76	Making uninstall response generic Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	f80cbe43d0	Moved release objects to enable versioning Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	2247a0074b	Move all the get commands to the new release interface Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Matt Farina	94bfe9ba12	Move action get metadata to chart interfaces Signed-off-by: Matt Farina <matt.farina@suse.com>	7 months ago
Benoit Tigeot	4a944230ea	Do not ignore .yml file on linting while accepting .yaml From : https://github.com/helm/helm/pull/30712/files#r2417446037 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	7 months ago

1 2 3 4 5 ...

3531 Commits (ca8eae936113de27730405d5834295ac452548ca)