This is the fix for only one particular, but important case.
The case when a new resource has been added to the chart and
there is an error in the chart, which leads to release failure.
In this case after first failed release upgrade new resource will be
created in the cluster. On the next release upgrade there will be the error:
`no RESOURCE with the name NAME found` for this newly created resource
from the previous release upgrade.
The root of this problem is in the side effect of the first release process,
Release invariant says: if resouce exists in the kubernetes cluster, then
it should exist in the release storage. But this invariant has been broken
by helm itself -- because helm created new resources as side effect and not
adopted them into release storage.
To maintain release invariant for such case during release upgrade operation
all newly *successfully* created resources will be deleted in the case
of an error in the subsequent resources update.
This behaviour will be enabled only when `--cleanup-on-fail` option used
for `helm upgrade` or `helm rollback`.
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
In the quickstart guide, --max-history is recommended as parameter for helm init. The actual name of the parameter is --history-max.
Signed-off-by: Jens Frank <jf@mormo.org>
Correct some words spelling for reading more easily.
Signed-off-by: Nguyen Quang Huy <huynq0911@gmail.com>
Co-Authored-By: Nguyen Van Trung <trungnvfet@outlook.com>
Although it is spelling mistakes, it might make an affects
while reading.
Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
* Improve language describing deletion of hooks
The existing language was somewhat confusing and grammatically poor.
Closes#5035
Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
* Improve language describing deletion of hooks
The existing language was somewhat confusing and grammatically poor.
Closes#5035
Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
* Fix incorrect flow example and improve operator documentation
Signed-off-by: Alex <login@sneaksneak.org>
* Use golang comment format
Signed-off-by: Alex <login@sneaksneak.org>
* Update using_helm.md
In docs/using_helm.md, it says on line 214 that you can pass in a YAML formatted file, but the example commands following that sentence create JSON code but names the file with a .yml extension. For clarity, I propose saying that it will accept JSON or YAML but clarify in the code that for the example we're making a JSON file.
Signed-off-by: Pablo Canseco <p@blocanse.co>
* update using_helm.md to accurately say that helm install -f only takes a yaml-formatted file.
Signed-off-by: Pablo Canseco <p@blocanse.co>
* updated wording to reflect the fact that -f / --values only accepts YAML
Signed-off-by: Pablo Canseco <p@blocanse.co>
While deving at a Microsoft Open Hack my group discovered this useful piece of information in this issue comment: https://github.com/helm/helm/issues/1796#issuecomment-311385728
We found it very useful for our Blue Green CD pipeline and thought others might find it useful as well.
Signed-off-by: Ethan Arrowood <ethan.arrowood@gmail.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
As stated by @schollii in https://github.com/helm/helm/issues/4505#issuecomment-415886732 "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.
Signed-off-by: Nahuel Lascano <nlascano@eryx.co>
* update nginx example to work multi-arch
Signed-off-by: Patrick Lang <patrick.lang@hotmail.com>
* Fix alpine to use a multiarch tag
Signed-off-by: Patrick Lang <patrick.lang@hotmail.com>
Matt Farina
dieutth
Kenta Iso
Matthew Fisher
Taylor Thomas
Sergey Kozlov
Arvind Kumar
Xiangxuan Liu
Timofey Kirillov
robertavram
Jens Frank
Martin Hickey
anton
Jacob LeGrone
Nguyen Quang Huy
Vu Cong Tuan
hnwolf
Nguyen Hai Truong
Nguyen Hai Truong
Nguyen Van Trung
Josh Dolitsky
Henry Nash
Aaron Roydhouse
adshmh
Jecho
Alex Speaks
Dean Coakley
Jacob Silva
Pablo M. Canseco
Patrick Stegmann
Laski
Christian Hildebrando Hercules
Maor Friedman
Marcin Kłopotek
Alexander Nesterenko
shibataka000
Patrick Lang
Michelle Noorali