While adding the test, noticed a race in the repo update code, due to
multiple go routines potentially incrementing the error counter.
Included the required mutex in the repo update code in the same commit,
since the new test uncovered the race condition.
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
* added warning and set default image for unreleased versions of helm
* changed to BuildMetadata
* changed to BuildMetadata
* added check for clientOnly flag
* Fix incorrect flow example and improve operator documentation
Signed-off-by: Alex <login@sneaksneak.org>
* Use golang comment format
Signed-off-by: Alex <login@sneaksneak.org>
* added test for zero values
Signed-off-by: Flavian <flavian.sierk@gmail.com>
* implemented case for zero values
Signed-off-by: Flavian <flavian.sierk@gmail.com>
* Update using_helm.md
In docs/using_helm.md, it says on line 214 that you can pass in a YAML formatted file, but the example commands following that sentence create JSON code but names the file with a .yml extension. For clarity, I propose saying that it will accept JSON or YAML but clarify in the code that for the example we're making a JSON file.
Signed-off-by: Pablo Canseco <p@blocanse.co>
* update using_helm.md to accurately say that helm install -f only takes a yaml-formatted file.
Signed-off-by: Pablo Canseco <p@blocanse.co>
* updated wording to reflect the fact that -f / --values only accepts YAML
Signed-off-by: Pablo Canseco <p@blocanse.co>
While deving at a Microsoft Open Hack my group discovered this useful piece of information in this issue comment: https://github.com/helm/helm/issues/1796#issuecomment-311385728
We found it very useful for our Blue Green CD pipeline and thought others might find it useful as well.
Signed-off-by: Ethan Arrowood <ethan.arrowood@gmail.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Don't delete a resource on upgrade if it is annotated with
helm.io/resource-policy=keep. This can cause data loss for users if the
annotation is ignored (e.g. for a PVC).
Closes#3673
Signed-off-by: James Ravn <james@r-vn.org>
As stated by @schollii in https://github.com/helm/helm/issues/4505#issuecomment-415886732 "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.
Signed-off-by: Nahuel Lascano <nlascano@eryx.co>
Add possibility to put "--safe" argument to install and
upgrade command that restores the state of cluster in
case of failed install/upgrade attempt
Signed-off-by: Alexander Nesterenko <nestorf250@gmail.com>
* update nginx example to work multi-arch
Signed-off-by: Patrick Lang <patrick.lang@hotmail.com>
* Fix alpine to use a multiarch tag
Signed-off-by: Patrick Lang <patrick.lang@hotmail.com>
As noted in Slack by a community member, release names with periods are
considered usable. Switching to RFC 1123 subdomain verification
continues to block bad release names like BAD_NAME, but allows names
like good.name to continue working.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
* fix: perform extra validation on paths in tar archives
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: Cover a few Windows cases and also remove a duplicate tar reader
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: removed debug output
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: Expand again preserves the files verbatim
Also added tests for Expand
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fix: add license block and remove println
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
adshmh
Aaron Roydhouse
Jecho
Alexander Matyushentsev
Ryan Hartje
Alex Speaks
Flavian
ahmadali shafiee
lIuDuI
JoeWrightss
Dean Coakley
Marcin Kłopotek
Jacob Silva
Pablo M. Canseco
Patrick Stegmann
Matthew Fisher
James Ravn
Amim Knabben
Laski
Peter Stalman
Christian Hildebrando Hercules
Maor Friedman
Bort Verwilst
Taylor Thomas
Alexander Nesterenko
shibataka000
Michelle Noorali
Adam Reese
Geoff Baskwill
Patrick Lang
Koichi Shiraishi
Martin Hickey
Deepak Sattiraju
Jon Leonard
Matt Butcher
Axel Köhler