9ee32fa7df
Update pkg/action/install_test.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
df05b58892
Make --dry-run=server validation to not differ from what a real install/upgrade would send to the API server
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
95c7eee576
Applied feedback from review pt. 3
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
7a5092efb7
Applied feedback pt.1
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
f41d249e3f
Remove unneeded comments
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
597ceb6802
fix(action): enable server-side validation for dry-run=server
...
When using --dry-run=server with --server-side=true, Helm now properly
validates manifests against the Kubernetes API server. Previously, the
dry-run would return early without calling the API, missing validation
errors like unknown fields in the spec.
This fix ensures that DryRunServer mode calls KubeClient.Create/Update
with the dry-run option, matching the behavior of kubectl apply
--dry-run=server.
Fixes : helm/helm#31505
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
1 week ago
1ea6f4649a
Merge pull request #32450 from helm/dependabot/go_modules/google.golang.org/grpc-1.82.1
...
chore(deps): bump google.golang.org/grpc from 1.80.0 to 1.82.1
1 week ago
fe3f98b564
chore(deps): bump google.golang.org/grpc from 1.80.0 to 1.82.1
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.80.0 to 1.82.1.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.80.0...v1.82.1 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-version: 1.82.1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
7e1b187e6b
Merge pull request #32442 from helm/dependabot/github_actions/main/github/codeql-action/analyze-4.37.2
...
chore(deps): bump github/codeql-action/analyze from 4.37.1 to 4.37.2
1 week ago
014772fed1
Merge pull request #32443 from helm/dependabot/github_actions/main/github/codeql-action/init-4.37.2
...
chore(deps): bump github/codeql-action/init from 4.37.1 to 4.37.2
1 week ago
e69402cc79
Merge pull request #32444 from helm/dependabot/github_actions/main/github/codeql-action/autobuild-4.37.2
...
chore(deps): bump github/codeql-action/autobuild from 4.37.1 to 4.37.2
1 week ago
ce13e3b658
Merge pull request #32417 from mmorel-35/testifylint-manual-assert-pkg-3
...
chore(pkg): refactor: convert tests to testify assert/require part 3
2 weeks ago
ed246e29f7
chore(deps): bump actions/labeler from 6.2.0 to 7.0.0 ( #32441 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 6.2.0 to 7.0.0.
- [Release notes](https://github.com/actions/labeler/releases )
- [Commits](b8dd2d9be0...bf12e9b00b
2 weeks ago
5223ceacda
chore(deps): bump github/codeql-action/upload-sarif ( #32440 )
...
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ) from 4.37.1 to 4.37.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](7188fc3636...e0647621c2
2 weeks ago
a0f954e277
chore(deps): bump github/codeql-action/autobuild from 4.37.1 to 4.37.2
...
Bumps [github/codeql-action/autobuild](https://github.com/github/codeql-action ) from 4.37.1 to 4.37.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](7188fc3636...e0647621c2
2 weeks ago
cdccef4818
chore(deps): bump github/codeql-action/init from 4.37.1 to 4.37.2
...
Bumps [github/codeql-action/init](https://github.com/github/codeql-action ) from 4.37.1 to 4.37.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](7188fc3636...e0647621c2
2 weeks ago
065d3a6a3d
chore(deps): bump github/codeql-action/analyze from 4.37.1 to 4.37.2
...
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action ) from 4.37.1 to 4.37.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](7188fc3636...e0647621c2
2 weeks ago
2bdbea6fe2
Merge pull request #32416 from mmorel-35/testifylint-manual-assert-pkg-2
...
chore(pkg): refactor: convert tests to testify assert/require part 2
2 weeks ago
a6ca94494b
Merge pull request #32407 from mmorel-35/testifylint-manual-assert-internal-3
...
chore(internal): refactor: convert tests to testify assert/require part 3
2 weeks ago
29cdf6bd41
Merge pull request #31907 from LarytheLord/fix/test-kubeconfig-isolation-31470
...
test(cli): make User-Agent REST config test hermetic
2 weeks ago
178c9f6ade
Merge pull request #32406 from mmorel-35/testifylint-manual-assert-internal-2
...
chore(internal): refactor: convert tests to testify assert/require part 2
2 weeks ago
440cc223c5
Merge pull request #32405 from mmorel-35/testifylint-manual-assert-internal-1
...
chore(internal): refactor: convert tests to testify assert/require part 1
2 weeks ago
715888a5eb
Merge pull request #32410 from mmorel-35/testifylint-manual-assert-internal-6
...
chore(internal): refactor: convert tests to testify assert/require part 6
2 weeks ago
e126cd327a
Merge pull request #32409 from mmorel-35/testifylint-manual-assert-internal-5
...
chore(internal): refactor: convert tests to testify assert/require part 5
2 weeks ago
c9d9428e78
Merge pull request #32415 from mmorel-35/testifylint-manual-assert-pkg-1
...
chore(pkg): refactor: convert tests to testify assert/require part 1
2 weeks ago
0daa77fa9b
chore(pkg): refactor: convert tests to testify assert/require part 2
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
3f1f55c4c8
Merge pull request #32420 from mmorel-35/testifylint-manual-assert-pkg-6
...
chore(pkg): refactor: convert tests to testify assert/require part 6
2 weeks ago
90669b3a78
Merge pull request #32419 from mmorel-35/testifylint-manual-assert-pkg-5
...
chore(pkg): refactor: convert tests to testify assert/require part 5
2 weeks ago
b100b44bef
Merge pull request #32418 from mmorel-35/testifylint-manual-assert-pkg-4
...
chore(pkg): refactor: convert tests to testify assert/require part 4
2 weeks ago
d4ec8e9b87
chore(pkg): refactor: convert tests to testify assert/require part 1
...
refactor: convert tests to testify assert/require in pkg/engine
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
0844b3b8b5
chore(pkg): refactor: convert tests to testify assert/require part 6
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
3ff05c835e
chore(pkg): refactor: convert tests to testify assert/require part 5
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
658a8fac15
chore(pkg): refactor: convert tests to testify assert/require part 4
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
df2d013517
chore(pkg): refactor: convert tests to testify assert/require part 3
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
8c7f3a14d2
chore(deps): bump actions/checkout from 7.0.0 to 7.0.1 ( #32411 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](9c091bb21b...3d3c42e5aa
2 weeks ago
6c45810119
chore(internal): refactor: convert tests to testify assert/require part 4 ( #32408 )
...
refactor: convert tests to testify assert/require in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
668e7e580a
chore(internal): refactor: convert tests to testify assert/require part 3
...
refactor: convert tests to testify assert/require in internal
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
f1d5979e7d
chore(internal): refactor: convert tests to testify assert/require part 5
...
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
f3402c1cd6
chore(internal): refactor: convert tests to testify assert/require part 6
...
refactor: convert tests to testify assert/require in internal/plugin
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
ba31ca0c0b
chore(internal): refactor: convert tests to testify assert/require part 1
...
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
615a299876
chore(internal): refactor: convert tests to testify assert/require part 2
...
#### Description
refactor: convert tests to testify assert/require in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
06978bd8c5
Merge pull request #32371 from benoittgt/ci/tag-v4
...
ci: auto-label PRs targeting main with v4.x
2 weeks ago
ccb8f595ab
Merge pull request #32374 from helm/dependabot/github_actions/main/github/codeql-action/autobuild-4.37.1
...
chore(deps): bump github/codeql-action (init, autobuild, analyze) to 4.37.1
2 weeks ago
3bcf965f99
perf: enable concurrent status computation to prevent multi-minute delays ( #32043 )
...
* fix: enable concurrent status computation to prevent multi-minute delays
Set StatusComputeWorkers=8 on DefaultStatusWatcher for Wait,
WaitWithJobs, and WatchUntilReady. This opts in to the async status
computation added in fluxcd/cli-utils#20 , preventing the informer
notification pipeline from being blocked by slow API calls when many
resources are updated simultaneously.
Without this, status computation for resources like Deployments (which
require additional LIST ReplicaSets/Pods calls) runs serially inside
the informer, causing growing delays of 1-3+ minutes when upgrading
many resources at once (e.g., ~20 Deployments via Helm).
Signed-off-by: maplemiao <maplemiao@tencent.com>
* refactor(kube): expose StatusComputeWorkers as a WaitOption
Replace the package-level DefaultStatusComputeWorkers variable with a
WithStatusComputeWorkers WaitOption threaded through waitOptions into
the statusWaiter. This removes global mutable state from pkg/kube and
lets callers opt in explicitly.
SDK consumers (e.g. helm-controller) inherit the zero value, which
preserves the upstream cli-utils synchronous behavior and avoids an
unexpected fan-out of status-compute goroutines when many releases
reconcile concurrently. The Helm CLI continues to enable 8 workers by
default via a shared pkg/cmd/flags.go helper, so install/upgrade/
rollback/uninstall/test users still get the fix for multi-minute
informer stalls out of the box.
Signed-off-by: maplemiao <maplemiao@tencent.com>
* refactor(kube): clamp negative StatusComputeWorkers values to zero
Address review feedback: when a caller passes a negative value to
WithStatusComputeWorkers, coerce it to zero rather than propagating
it to the underlying cli-utils watcher, where the behavior is
undefined. Zero is the safe default and matches the SDK opt-in
contract.
Signed-off-by: maplemiao <maplemiao@tencent.com>
---------
Signed-off-by: maplemiao <maplemiao@tencent.com>
Signed-off-by: Maple Miao <maplemiao@yunzhanghu.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2 weeks ago
82be04d7f2
remove legacy import comments from remaining packages ( #31933 )
...
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.
Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver
Follows up on #31931 and #31932 which addressed pkg/kube.
Fixes #31846
Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2 weeks ago
c2fda5ac58
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 weeks ago
a2b1a60d51
fix: enhance error handling and improve test assertions ( #32352 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
0563162dd9
chore(deps): bump github/codeql-action init and analyze to 4.37.1
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 weeks ago
06b95860dc
chore(deps): bump github/codeql-action/upload-sarif ( #32378 )
...
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ) from 4.37.0 to 4.37.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](99df26d4f1...7188fc3636
2 weeks ago
a494169853
chore(deps): bump actions/setup-go from 6.5.0 to 7.0.0 ( #32376 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.5.0 to 7.0.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](924ae3a1cd...b7ad1dad31
2 weeks ago
MrJack
Terry Howe
dependabot[bot]
George Jenkins
Matt Farina
Matthieu MOREL
Zhaofeng Miao
Abhay Chaurasiya