Orgad Shaneh
76eb37c01a
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
3 months ago
Terry Howe
1468449ff5
Merge pull request #31794 from mmorel-35/modernize-pkg-1-f9be97c
...
chore(pkg): fix modernize linter
3 months ago
Evans Mungai
5aac32077f
feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) ( #31592 )
...
* feat(create): add hidden --chart-api-version flag
Add --chart-api-version flag to helm create command to allow selecting
chart API version (v2 or v3) when creating a new chart.
- Default is v2 (existing behavior unchanged)
- v3 uses internal/chart/v3 scaffold generator
- Invalid versions return clear error message
- Works with --starter flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add HELM_EXPERIMENTAL_CHART_V3 feature gate to create command
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* make chartv3 private and use loader to load the chart
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Hide chart-api-version flag until chart v3 is officially released
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Conditionally hide the --chart-api-version flag if chart v3 is not enabled
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add internal gates package for internal feature gates
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add doc for internal/gates package
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matthieu MOREL
ba38159313
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Robert Sirchia
fbb8de54be
Merge pull request #31773 from helm/dependabot/go_modules/main/github.com/lib/pq-1.11.1
...
chore(deps): bump github.com/lib/pq from 1.10.9 to 1.11.1
3 months ago
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
...
fix(values): preserve nil values when chart default is empty map
3 months ago
dependabot[bot]
9c9c3a6b5c
chore(deps): bump github.com/lib/pq from 1.10.9 to 1.11.1
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.10.9 to 1.11.1.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.10.9...v1.11.1 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.11.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
George Jenkins
e685076bc0
Merge pull request #31772 from matheuscscp/revert-12581
...
Revert "Consider GroupVersionKind when matching resources"
3 months ago
Matheus Pimenta
787b61cedb
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Matt Farina
75880fa498
Merge pull request #31751 from gitgrave/fix-31750
...
fix(copystructure): handle nil elements in slice copying
3 months ago
Matt Farina
72c0c28207
Merge pull request #31753 from helm/dependabot/github_actions/main/actions/checkout-6.0.2
...
chore(deps): bump actions/checkout from 6.0.1 to 6.0.2
3 months ago
Matt Farina
a586a05474
Merge pull request #31754 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-0.37.1-flux.1
...
chore(deps): bump github.com/fluxcd/cli-utils from 0.37.0-flux.1 to 0.37.1-flux.1
3 months ago
Matt Farina
1650c26f5d
Merge pull request #31765 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.23.1
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.23.0 to 0.23.1
3 months ago
dependabot[bot]
becf9bf7e3
chore(deps): bump sigs.k8s.io/controller-runtime from 0.23.0 to 0.23.1
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.23.0 to 0.23.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.23.0...v0.23.1 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.23.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Scott Rigby
f928025cdb
Merge pull request #31717 from AustinAbro321/use-logger-with-waiter
...
fix: use kube logger with status waiter
3 months ago
Evans Mungai
9211dfef6a
Merge pull request #31743 from banjoh/em/document-uninstall-using-cascade
...
docs: document uninstall using cascade foreground flag
3 months ago
dependabot[bot]
b53198e7ee
chore(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.37.0-flux.1 to 0.37.1-flux.1.
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.37.0-flux.1...v0.37.1-flux.1 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 0.37.1-flux.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
dependabot[bot]
b59e533b76
chore(deps): bump actions/checkout from 6.0.1 to 6.0.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8e8c483db8...de0fac2e45 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Austin Abro
ec0726523e
whitespace
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
Philipp Born
e3829ebbbb
fix(copystructure): handle nil elements in slice copying
...
When copying slices containing nil interface{} elements, the copyValue
function would panic with 'reflect: call of reflect.Value.Set on zero
Value'. This occurred because reflect.ValueOf(nil) returns a zero Value
that cannot be set.
This issue was introduced in v4.1.0 when replacing mitchellh/copystructure
with an internal implementation. The fix mirrors the existing nil handling
logic used for map values.
Fixes helm template panic when processing charts with YAML like:
extraArgs:
-
Added test case to verify slice elements with nil values are properly
handled during deep copy operations.
Signed-off-by: Philipp Born <git@pborn.eu>
3 months ago
Austin Abro
63b40a7a5e
use logger with waiter
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
George Jenkins
340b06d8f3
Merge pull request #31739 from gjenkins8/gjenkins/tidy_helmv3_contributing
...
Modernize Helm v3 CONTRIBUTING.md
3 months ago
Matt Farina
83e1f2f547
Merge pull request #31742 from JeevanYewale/remove-legacy-sync-script
...
Remove legacy sync-repo.sh script
3 months ago
George Jenkins
f9db0ca185
Merge pull request #31735 from matheuscscp/fine-grained-wait-ctx
...
feat(kstatus): fine-grained context options for waiting
3 months ago
Matheus Pimenta
b0b35f1231
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
George Jenkins
26e28e846a
Apply suggestions from code review
...
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Robert Sirchia
11dd6ec0c4
Merge pull request #31744 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.23.0
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0
3 months ago
Jeevan Yewale
97fd00786f
Remove legacy sync-repo.sh script
...
Signed-off-by: Jeevan Yewale <jeevanyewale4@gmial.com>
3 months ago
dependabot[bot]
52620076e2
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.22.4 to 0.23.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.22.4...v0.23.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.23.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Scott Rigby
6e38e303c3
Merge pull request #31730 from matheuscscp/fix-kstatus-failed
...
bugfix(kstatus): do not wait forever on failed resources
3 months ago
Evans Mungai
e70d59de7c
docs: document uninstall using cascade foreground flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matheus Pimenta
bbec77c1f7
bugfix(kstatus): do not wait forever on failed resources
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
George Jenkins
50546ef665
Merge pull request #31723 from matheuscscp/fix-storage-logger
...
bugfix(logging): fix storage not getting logger from driver
3 months ago
George Jenkins
443a2a6924
Modernize Helm v3 CONTRIBUTING.md
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
1dffc817e5
Merge pull request #31732 from matheuscscp/ssa-defaults
...
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
3 months ago
Matheus Pimenta
c1cc625323
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Scott Rigby
edbb47474c
Merge pull request #31726 from banjoh/em/improve-wait-flag-description
...
chore: clarify --wait flag help text
3 months ago
Terry Howe
be74616eaf
Merge pull request #31725 from helm/dependabot/github_actions/main/actions/setup-go-6.2.0
...
chore(deps): bump actions/setup-go from 6.1.0 to 6.2.0
3 months ago
Evans Mungai
828038a8fe
chore: clarify --wait flag help text
...
Improve the description to explain the three usage scenarios:
- --wait alone defaults to 'watcher' strategy
- --wait=<value> uses the specified strategy
- flag omitted defaults to 'hookOnly'
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
dependabot[bot]
e22377124d
chore(deps): bump actions/setup-go from 6.1.0 to 6.2.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](4dc6199c7b...7a3fe6cf4c )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: 6.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Matheus Pimenta
a8eb527847
bugfix(storage): fix storage not getting logger from driver
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Evans Mungai
40a9de1086
Merge pull request #31412 from fmuyassarov/devel/rollback
...
Fix rollback for missing resources
3 months ago
Terry Howe
8f1bbb30cf
Merge pull request #31720 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.47.0
...
chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.47.0
3 months ago
dependabot[bot]
da1d68adea
chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.47.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.46.0 to 0.47.0.
- [Commits](https://github.com/golang/crypto/compare/v0.46.0...v0.47.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.47.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Scott Rigby
4553a0a96e
Merge pull request #31706 from matheuscscp/custom-kstatus-readers
...
pkg/kube: introduce support for custom kstatus readers
3 months ago
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Evans Mungai
3120e88f9b
Merge pull request #31713 from helm/dependabot/go_modules/main/golang.org/x/term-0.39.0
...
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
3 months ago
dependabot[bot]
de0becdc57
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/term/compare/v0.38.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.39.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Evans Mungai
951c630e2c
Merge pull request #31712 from helm/dependabot/go_modules/main/golang.org/x/text-0.33.0
...
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
3 months ago