34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 days ago
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
5 days ago
c36e4d52bd
test: use assert.Empty for zero-length assertions in validate_test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 days ago
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
5 days ago
422773cd49
Merge pull request #32129 from gregory-m/fix-test-logs-non-pod-hooks
6 days ago
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
2 weeks ago
a6179d0dd1
Merge branch 'main' into em/check-ownership-before-delete
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 weeks ago
1b360574a9
Merge branch 'helm:main' into feature/rollback-revision-history
3 weeks ago
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
3 weeks ago
488c4a805d
Fix empty and len testifylint violations across test files
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
d374e823b2
Merge pull request #32086 from mmorel-35/error-is-as
...
testifylint: enable error-is-as and error-nil rules
4 weeks ago
291a1a3b26
Merge branch 'helm:main' into feature/rollback-revision-history
1 month ago
1a1ec6e3cc
fix: skip non-Pod test hooks in GetPodLogs
...
Before this change, hooks with `helm.sh/hook: test` but Kind != Pod
(ConfigMap, Secret, ...) led to `helm test --logs` fail with
`unable to get pod <name>`.
Signed-off-by: Gregory Man <man.gregory@gmail.com>
1 month ago
432fc8a217
refactor: use slices.Backward to simplify the code
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
1 month ago
03a65a71f7
Fix lint errors
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
007713087b
fix: address Copilot review on ownership-verified uninstall
...
- Distinguish unowned resources from those whose ownership could not be
verified (e.g. RBAC/network errors). Unverifiable resources are now
returned in a separate list with the underlying error so log output
and the "kept" summary describe what actually happened.
- Only prefix the kept summary with the resource-policy header when
there are policy-kept resources, so users with only ownership-skipped
resources don't see a misleading header.
- Update verifyOwnershipBeforeDelete doc comment to reflect that
not-found resources are excluded from all returned lists.
- Assert success of Releases.Create in uninstall tests so fixture
setup failures are surfaced immediately.
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
9728c5af31
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
ed5789cbda
Merge remote-tracking branch 'origin/main' into em/check-ownership-before-delete
2 months ago
922558fc1a
fix: address review feedback
...
- Close log stream after reading (prevents connection/fd leak)
- Strengthen tests to assert on output headers rather than error paths
- Remove unused import
Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
2 months ago
854f7f6b72
fix: fetch logs from all containers in test pods
...
When a test pod contains multiple containers (e.g. Istio/Consul/Vault
sidecars), 'helm test --logs' failed with 'a container name must be
specified'. This happened because GetPodLogs called the Kubernetes log
API without specifying a container name.
The fix fetches the pod spec first, then iterates over all containers
(init containers + regular containers) and requests logs for each one
explicitly. Errors from individual containers are collected and returned
together via errors.Join rather than aborting on the first failure.
Also fixes a typo: hooksByWight -> hooksByWeight.
Closes #6902
Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
2 months ago
dc04059ea3
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
f8ba28bb17
testifylint: enable error-is-as and error-nil rules
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
2 months ago
8f56f24d63
fix(templating): hooks conflicting with templates in post-renderers ( #32049 )
...
* fix(templating): hooks conflicting with templates in post-renderers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* fix(templating): allow disabling hooks from postrenderers entirely
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
3838d2d2dd
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
66e5049405
Merge pull request #32008 from rhysmcneill/bugfix/helm-upgrade-err-variable-defect
...
fix(action): return correct error variable in prepareUpgrade
2 months ago
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
16c6662566
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
a27f1add79
fix(templating): fix wrong YAML separator parsing for post-renderers ( #31941 )
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 months ago
8ef2d45934
fix(action): return correct error variable in prepareUpgrade
...
When Deployed() succeeds but releaserToV1Release() fails, prepareUpgrade
returned err (nil) instead of cerr (the conversion error), causing a
silent nil return that could lead to nil pointer dereferences downstream.
Closes #32007
Signed-off-by: Rhys McNeill <rhysmcneill7@hotmail.co.uk>
3 months ago
42db90d9e8
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
071558d69f
chore: fix bool-compare issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
...
chore(pkg): fix perfsprint linter issues part 6
3 months ago
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
3 months ago
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
...
chore(pkg): fix perfsprint linter issues part 5
3 months ago
a753caca76
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
3e7b38fd04
Merge pull request #31868 from matheuscscp/fix-31867
...
fix: insert newline after doc separators glued to content by template trimming
4 months ago
af94abf976
fix: insert newline after doc separators glued to content by template trimming
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 months ago
643e6d581d
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
...
chore(pkg): fix perfsprint linter issues part 3
4 months ago
4f9f18c453
Merge pull request #31875 from mmorel-35/perfsprint-pkg-2-0e1acbc
...
chore(pkg): fix perfsprint linter issues part 2
4 months ago
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
...
Replace non-format use of t.Fatalf with t.Fatal
4 months ago
dc0e3f10c3
chore(pkg): fix perfsprint linter issues part 6
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
1d2d63cc43
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
63f03c0f5c
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
c25c988cfb
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/registry
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
0fecfd04c2
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
Terry Howe
George Jenkins
Evans Mungai
MrJack
Gregory Man
box4wangjing
Sebastien Tardif
Matheus Pimenta
Rhys McNeill