Terry Howe
74fa4fceb8
Merge pull request #31862 from mmorel-35/context
...
chore: enable contextcheck, fatcontext and noctx linters
3 days ago
Matthieu MOREL
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 days ago
Terry Howe
be45213874
Merge pull request #32238 from helm/dependabot/github_actions/main/actions/checkout-7.0.0
...
chore(deps): bump actions/checkout from 6.0.3 to 7.0.0
5 days ago
Terry Howe
5a64a89e99
Merge pull request #32241 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.7.0
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.6.1 to 0.7.0
5 days ago
dependabot[bot]
a0c7d1e1f5
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.6.1 to 0.7.0.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.6.1...v0.7.0 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.7.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 days ago
dependabot[bot]
5848047c6b
chore(deps): bump actions/checkout from 6.0.3 to 7.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](df4cb1c069...9c091bb21b )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 7.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
5 days ago
Terry Howe
05b2746081
Merge pull request #32184 from atkrad/fix/kube-isreachable-nil-panic
...
fix panic on repeated IsReachable calls
5 days ago
Terry Howe
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
5 days ago
George Jenkins
5b1fc3bbf9
Merge pull request #32235 from TerryHowe/fix/testifylint-empty-assertions
...
test: use assert.Empty for zero-length assertions in validate_test
5 days ago
Terry Howe
c36e4d52bd
test: use assert.Empty for zero-length assertions in validate_test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 days ago
Terry Howe
f59fae54cc
Merge pull request #32233 from s3onghyun/docs-version-desc-typo
...
docs: fix typo in helm version command description
6 days ago
George Jenkins
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
6 days ago
George Jenkins
b7ebb5575f
Merge pull request #32210 from helm/dependabot/go_modules/main/k8s-io-5cc882a701
...
chore(deps): bump the k8s-io group across 1 directory with 7 updates
6 days ago
s3onghyun
dd442c0cc7
docs: fix typo in helm version command description
...
Signed-off-by: s3onghyun <s3onghyun.hong@gmail.com>
6 days ago
George Jenkins
422773cd49
Merge pull request #32129 from gregory-m/fix-test-logs-non-pod-hooks
6 days ago
dependabot[bot]
fa68e6cb09
chore(deps): bump the k8s-io group across 1 directory with 7 updates
...
Bumps the k8s-io group with 4 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api ), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl ).
Updates `k8s.io/api` from 0.36.1 to 0.36.2
- [Commits](https://github.com/kubernetes/api/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/apiextensions-apiserver` from 0.36.1 to 0.36.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/apimachinery` from 0.36.1 to 0.36.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/apiserver` from 0.36.1 to 0.36.2
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/cli-runtime` from 0.36.1 to 0.36.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/client-go` from 0.36.1 to 0.36.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.36.1...v0.36.2 )
Updates `k8s.io/kubectl` from 0.36.1 to 0.36.2
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.36.1...v0.36.2 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
6 days ago
George Jenkins
5655e3f2a4
Merge pull request #32230 from helm/revert-32081-fix/statuswait-delete-race
...
Revert "fix(kube): prevent spurious early exit in WaitForDelete during informer sync"
6 days ago
George Jenkins
fb9791f492
Merge pull request #32136 from SebTardif/fix-digest-error-swallow
...
fix(provenance): check error return in Digest and encodeRelease
6 days ago
George Jenkins
9444d74104
Merge pull request #32178 from helm/dependabot/github_actions/main/actions/checkout-6.0.3
...
chore(deps): bump actions/checkout from 6.0.2 to 6.0.3
6 days ago
dependabot[bot]
3d2ff2a1aa
chore(deps): bump actions/checkout from 6.0.2 to 6.0.3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](de0fac2e45...df4cb1c069 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
6 days ago
Terry Howe
a82bd25fc0
Merge pull request #32223 from devShaik010/docs/contributing-wording-fixes
...
docs: improve CONTRIBUTING.md wording
7 days ago
George Jenkins
d3bd09147b
Revert "fix(kube): prevent spurious early exit in WaitForDelete during informer sync"
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 days ago
devShaik010
fa9cb49194
docs: improve CONTRIBUTING.md wording
...
Signed-off-by: devShaik010 <20dpcs044hy@manuu.edu.in>
1 week ago
Terry Howe
f8b5203160
Merge pull request #31185 from kyokuping/fix/31183
...
chore: Improve error reporting for `helm template --debug` with `--show-only`
1 week ago
Jeaeun Kim
9c1d5a3b24
chore: rename savedErr to clear its specific purpose
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 weeks ago
Jeaeun Kim
99baa2edd4
chore: fix lint
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 weeks ago
Jeaeun Kim
ea847fef95
chore: store err separately for clarity
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 weeks ago
Jeaeun Kim
2014946e55
chore: Improve error reporting for `helm template --debug` with `--show-only`
...
Signed-off-by: Jeaeun Kim <me@kyoku.dev>
2 weeks ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
2 weeks ago
George Jenkins
81d6f04c82
Merge pull request #30867 from mmorel-35/gocritic
...
chore: fix deprecatedComment issues from gocritic
2 weeks ago
Evans Mungai
ac4f8a6c22
Merge pull request #31584 from banjoh/em/check-ownership-before-delete
...
feat: add ownership verification before deleting resources during uni…
2 weeks ago
Mohammad Abdolirad
1f7869c31f
fix panic on repeated IsReachable calls
...
- only cache kube client when creation succeeds
- add regression test for two failed reachability checks
Signed-off-by: Mohammad Abdolirad <m.abdolirad@gmail.com>
2 weeks ago
Terry Howe
a5552edf9f
fix: protect FailingKubeClient.RecordedWaitOptions from data race ( #31925 )
...
* fix: protect FailingKubeClient.RecordedWaitOptions from concurrent access
Add a sync.Mutex to guard the append to RecordedWaitOptions in
GetWaiterWithOptions, fixing a data race detected by -race when
concurrent goroutines (e.g. upgrade + rollback) both call
GetWaiterWithOptions on the same FailingKubeClient instance.
Fixes race failures in TestUpgradeRelease_Interrupted_RollbackOnFailure
and TestInstallRelease_RollbackOnFailure_Interrupted.
Signed-off-by: Terry Howe <thowe@nvidia.com>
* fix: extract appendRecordedWaitOptionsLocked helper with defer unlock
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
---------
Signed-off-by: Terry Howe <thowe@nvidia.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 weeks ago
Terry Howe
c2f1b238a1
fix: route registry client output to stdout instead of stderr ( #32056 )
...
Commands like 'helm registry login', 'helm push', and 'helm pull' were
writing success messages ("Login Succeeded", "Pushed:", "Pulled:",
"Digest:") to stderr instead of stdout. The root cause was that
newDefaultRegistryClient and newRegistryClientWithTLS hard-coded
os.Stderr as the registry client writer, ignoring the out io.Writer
that main() passes as os.Stdout.
Thread out io.Writer through newRegistryClient, newDefaultRegistryClient,
and newRegistryClientWithTLS, and update all call sites in pkg/cmd.
Fixes #13464
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 weeks ago
Ogulcan Aydogan
7058f841af
fix(engine): add debug logging when lookup returns empty ( #32205 )
...
When lookup cannot find the requested resource (apierrors.IsNotFound),
add slog.Debug() calls with structured fields (apiVersion, kind,
namespace, name) so that users running helm template --debug can see
why lookup returned an empty map instead of silently swallowing the
not-found result.
Fixes: https://github.com/helm/helm/issues/32101
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
2 weeks ago
Robert Sirchia
5c3cb20e76
Merge pull request #32194 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.53.0
...
chore(deps): bump golang.org/x/crypto from 0.52.0 to 0.53.0
2 weeks ago
MrJack
0ade355c35
Merge branch 'helm:main' into feature/rollback-revision-history
2 weeks ago
Terry Howe
f4fa06e2d9
Merge pull request #32201 from helm/dependabot/go_modules/main/oras.land/oras-go/v2-2.6.1
...
chore(deps): bump oras.land/oras-go/v2 from 2.6.0 to 2.6.1
2 weeks ago
dependabot[bot]
74c1702157
chore(deps): bump oras.land/oras-go/v2 from 2.6.0 to 2.6.1
...
Bumps [oras.land/oras-go/v2](https://github.com/oras-project/oras-go ) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/oras-project/oras-go/releases )
- [Commits](https://github.com/oras-project/oras-go/compare/v2.6.0...v2.6.1 )
---
updated-dependencies:
- dependency-name: oras.land/oras-go/v2
dependency-version: 2.6.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 weeks ago
dependabot[bot]
33b4071886
chore(deps): bump golang.org/x/crypto from 0.52.0 to 0.53.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.52.0 to 0.53.0.
- [Commits](https://github.com/golang/crypto/compare/v0.52.0...v0.53.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.53.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 weeks ago
Terry Howe
22905ca019
Merge pull request #32190 from helm/dependabot/go_modules/main/golang.org/x/term-0.44.0
...
chore(deps): bump golang.org/x/term from 0.43.0 to 0.44.0
2 weeks ago
dependabot[bot]
1019146bb3
chore(deps): bump golang.org/x/term from 0.43.0 to 0.44.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.43.0 to 0.44.0.
- [Commits](https://github.com/golang/term/compare/v0.43.0...v0.44.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.44.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 weeks ago
Terry Howe
1df252176d
Merge pull request #32192 from helm/dependabot/go_modules/main/golang.org/x/text-0.38.0
...
chore(deps): bump golang.org/x/text from 0.37.0 to 0.38.0
2 weeks ago
George Jenkins
e5efe067ed
Merge pull request #31758 from benoittgt/fix-31757
...
fix: prevent warning when using version range constraints
2 weeks ago
dependabot[bot]
7f855dfe8a
chore(deps): bump golang.org/x/text from 0.37.0 to 0.38.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.37.0 to 0.38.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.37.0...v0.38.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.38.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 weeks ago
Terry Howe
d77bc716ba
Merge pull request #32181 from helm/dependabot/github_actions/main/github/codeql-action-4.36.2
...
chore(deps): bump github/codeql-action from 4.36.1 to 4.36.2
3 weeks ago
MrJack
b4c9d94df2
Merge branch 'helm:main' into feature/rollback-revision-history
3 weeks ago
dependabot[bot]
c603c50aa6
chore(deps): bump github/codeql-action from 4.36.1 to 4.36.2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.36.1 to 4.36.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](87557b9c84...8aad20d150 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.36.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 weeks ago
Evans Mungai
a6179d0dd1
Merge branch 'main' into em/check-ownership-before-delete
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 weeks ago
Terry Howe
827a960ec1
Merge pull request #32177 from helm/dependabot/github_actions/main/github/codeql-action-4.36.1
...
chore(deps): bump github/codeql-action from 4.36.0 to 4.36.1
3 weeks ago