Kai Tanaka
2032ec5cba
docs: fix 'than'->'that' typo in deprecatedAPIError godoc
...
Signed-off-by: Kai Tanaka <275430420+quyentonndbs@users.noreply.github.com>
3 months ago
box4wangjing
432fc8a217
refactor: use slices.Backward to simplify the code
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
3 months ago
MrJack
38336f84ec
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
George Jenkins
19b3656306
Bump to version v4.2 ( #32102 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
MrJack
dc04059ea3
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
Matthieu MOREL
f8ba28bb17
testifylint: enable error-is-as and error-nil rules
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matheus Pimenta
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
George Jenkins
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
3 months ago
MrJack
3838d2d2dd
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
Matheus Pimenta
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 months ago
MrJack
41ba370236
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
George Jenkins
087736b66e
fix: unnecessary-format lint issues from merge
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
586eb57338
fix: Plugin missing provenance bypass
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
f7c4d75574
Merge commit from fork
...
fix: Chart dot-name path bug
4 months ago
George Jenkins
f8afb35f4e
Merge commit from fork
...
fix: Plugin version path traversal
4 months ago
Anmol Virdi
de58531ca7
Minor nit: fix import instructions to comply with canonical import paths
...
Signed-off-by: Anmol Virdi <anmolvirdi2000@gmail.com>
4 months ago
MrJack
42db90d9e8
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
Matthieu MOREL
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
071558d69f
chore: fix bool-compare issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
83a0138172
chore: fix deprecatedComment issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
MrJack
a753caca76
Merge branch 'helm:main' into feature/rollback-revision-history
5 months ago
George Jenkins
47a084091e
ignore error plugin loads (cli, getter)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
36dcc27ca3
fix: Plugin version path traversal
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
tsinglua
259f181808
chore: fix some minor issues in the comments
...
Signed-off-by: tsinglua <tsinglua@outlook.com>
5 months ago
George Jenkins
60184996e5
fix: Chart dot-name path bug
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
MrJack
6927cde3f9
fix: address Copilot review feedback on rollback revision PR
...
- Clarify --show-rollback flag help text to specify it only affects table output
- Add RollbackRevision JSON round-trip tests for pkg/release/v1 and internal/release/v2
- Add omitempty behavior verification for zero rollback_revision
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
5 months ago
MrJack
643e6d581d
Merge branch 'helm:main' into feature/rollback-revision-history
5 months ago
George Jenkins
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
...
Replace non-format use of t.Fatalf with t.Fatal
5 months ago
Terry Howe
c0f6b13e0e
Merge pull request #31877 from mmorel-35/perfsprint-internal-3-dda677a
...
chore(internal): fix perfsprint linter issues part 3
5 months ago
Matthieu MOREL
d4f6193a7e
chore(internal): enable perfsprint linter ( #31871 )
...
#### Description
enable perfsprint linter in internal/plugin
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
6524162a0e
chore(internal): enable perfsprint linter
...
#### Description
enable perfsprint linter in internal/tlsutil
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
9409226e15
chore(internal): enable perfsprint linter
...
#### Description
enable perfsprint linter in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Mads Jensen
36cb3a2fe9
Replace unneeded use of t.Fatalf with t.Fatal
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
5 months ago
Matthieu MOREL
5b6c6bbfc7
fix: enable nolinlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
George Jenkins
bc43812115
Merge pull request #31807 from mmorel-35/errorlint-internal-3-48c7a5a
...
fix(internal): errorlint linter
5 months ago
MrJack
300f71b1eb
feat(history): add rollback revision column to helm history output
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
5 months ago
George Jenkins
92b64e87ad
chore: fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Evans Mungai
4a91f3ad5c
feat(release): add internal/release/v2 package for chart v3 support ( #31709 )
...
Introduce release/v2 that mirrors pkg/release/v1 but uses *v3.Chart
from internal/chart/v3. The code is structurally identical to v1 with
only import paths changed to reference internal/chart/v3 instead of
pkg/chart/v2.
- Add internal/release/v2 with Release, Info, Hook types
- Add internal/release/v2/util with filter, sorter, manifest utilities
- Update pkg/release/common.go with v2Accessor and v2HookAccessor
- Copy all test files from pkg/release/v1 and add a v2 test in common_test.go
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Joe Julian
14e0b8f970
Merge pull request #31128 from orgads/win-parallel
...
fix(downloader): prevent concurrent file access errors on Windows
6 months ago
Matthieu MOREL
025418291a
fix(internal): errorlint linter
...
errorlint linter in internal/third_party/dep/fs
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
abecafa0f5
fix(internal): errorlint linter
...
#### Description
errorlint linter in internal
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Terry Howe
9b22aa4e05
Merge pull request #31795 from mmorel-35/modernize-internal-1-bbfa1fe
...
chore(internal): fix modernize linter
6 months ago
Joe Julian
c040f470ac
Merge pull request #31799 from mmorel-35/modernize-internal-2-d850a43
...
chore(internal): fix modernize linter
6 months ago
Orgad Shaneh
76eb37c01a
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
6 months ago
Evans Mungai
5aac32077f
feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) ( #31592 )
...
* feat(create): add hidden --chart-api-version flag
Add --chart-api-version flag to helm create command to allow selecting
chart API version (v2 or v3) when creating a new chart.
- Default is v2 (existing behavior unchanged)
- v3 uses internal/chart/v3 scaffold generator
- Invalid versions return clear error message
- Works with --starter flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add HELM_EXPERIMENTAL_CHART_V3 feature gate to create command
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* make chartv3 private and use loader to load the chart
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Hide chart-api-version flag until chart v3 is officially released
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Conditionally hide the --chart-api-version flag if chart v3 is not enabled
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add internal gates package for internal feature gates
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add doc for internal/gates package
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Matthieu MOREL
859292e31b
chore(internal): fix modernize linter
...
#### Description
fix modernize linter in internal/chart/v3
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
e2d184c79e
chore(internal): fix modernize linter
...
#### Description
fix modernize linter in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Philipp Born
e3829ebbbb
fix(copystructure): handle nil elements in slice copying
...
When copying slices containing nil interface{} elements, the copyValue
function would panic with 'reflect: call of reflect.Value.Set on zero
Value'. This occurred because reflect.ValueOf(nil) returns a zero Value
that cannot be set.
This issue was introduced in v4.1.0 when replacing mitchellh/copystructure
with an internal implementation. The fix mirrors the existing nil handling
logic used for map values.
Fixes helm template panic when processing charts with YAML like:
extraArgs:
-
Added test case to verify slice elements with nil values are properly
handled during deep copy operations.
Signed-off-by: Philipp Born <git@pborn.eu>
6 months ago
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
7 months ago
Gergely Brautigam
138f730aac
fix: typo in the function names
...
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
7 months ago
George Jenkins
f05c21b6b6
Merge pull request #31296 from gjenkins8/gjenkins/runtime_kube_version
...
build: set kube version via `debug.BuildInfo`
7 months ago
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
8 months ago
Branch Vincent
c6d9a5bdc2
build: set kube version via `debug.BuildInfo`
...
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
Matt Farina
4d1150d2af
Merge pull request #31415 from banjoh/em/increase-logging-test-coverage
...
chore: increase logging test coverage
8 months ago
Mads Jensen
a490bb3c20
Use errors.Is to check for io.EOF and gzip.ErrHeader
...
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
8 months ago
Terry Howe
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
8 months ago
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
8 months ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
8 months ago
Terry Howe
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
8 months ago
wangjingcun
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
8 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
8 months ago
Zadkiel AHARONIAN
119341dca7
fix(getter): pass settings environment variables
...
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
8 months ago
Matt Farina
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
...
fix(lint): prevent segmentation violation on only comment yaml in multidoc
8 months ago
Scott Rigby
4d54bea5ff
Merge pull request #31491 from benoittgt/31490-plugin-name-helper
...
feat: improve plugin name validation error messages and field name detection (v1)
8 months ago
Benoit Tigeot
81d244ca21
fix: prevent segmentation violation on empty yaml in multidoc
...
Fixes: https://github.com/helm/helm/issues/31544
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Matt Farina
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
9 months ago
Matt Farina
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Benoit Tigeot
71591ee63e
style: linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
b296cbef6c
test: split tests between valid and invalid
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
9b242dd9ed
test: convert tests to table drive tests
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
c81a09b89a
test: refactor TestMetadataLegacyValidate to be more generic
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
yxxhero
8c87024860
update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
9 months ago
yxxhero
2d49f0cb4a
Refactor environment variable expansion in PrepareCommands and update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
9 months ago
Scott Rigby
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
9 months ago
Benoit Tigeot
acf331a005
fix: improve plugin name validation err messages early via unmarshalling
...
- Add strict YAML unmarshalling for v1 plugins (d.KnownFields)
- Add comprehensive test coverage for validPluginName regex
- Maintain backwards compatibility for legacy plugins
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
9e1e3d21c5
fix: Make invalid name error message more similar and move tests
...
Follow Scott comment\
https://github.com/helm/helm/pull/31491/files#r2524933784
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
cf077ceb27
fix: focus only on plugin name but give more info about what we get
...
And improve test
Follow Scott comment:
> here I would have a list of valid and invalid names based on pattern, with a check and intended outcome for each one so that we comprehensively cover the rules.
https://github.com/helm/helm/pull/31491/files#r2524820312
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
f4b139a82c
Make validation error similar and explicit for both metadatas
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
c04e18e452
fix: improve plugin name validation error messages
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Scott Rigby
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
9 months ago
tison
90d01915f9
for all other similar cases
...
Signed-off-by: tison <wander4096@gmail.com>
9 months ago
Evans Mungai
558cea7458
chore: increase logging package test coverage
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Matt Farina
15300549f0
When time not available, using time.Now
...
Note, when time is not available, the builds are not reproducible.
This problem would only happen when an SDK user is using parts of
the API to build their own tooling. Helm will consistently inject
the dates through the higher level APIs.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Matt Farina
ca8eae9361
Reproducible chart archive builds
...
Building the same chart into an archive multiple times will have
the same sha256 hash.
Perviously, the time in the headers for a file was time.Now() which
changed each time. The time is now collected from the operating
system when the file is loaded and this time is used.
Fixes : #3612
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Evans Mungai
a94878fb89
Fix failing test
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
28bc76c364
Add tests for logging LogHolder
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
e63b4d92cb
Update internal/logging/logging.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
99fe9b3b9b
Update logging to use a param for the logger
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
d67b17b6ec
Minor name change
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
b6eca1c0f1
Refactor logging functionality to use slog.Handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
5ab4ca5490
Embed logging functionality to DRY code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Evans Mungai
9c32e34d60
Add logger to sql driver and ensure storage has logger
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
Matt Farina
a3db5f5667
Merge pull request #31408 from AndiDog/plugin-err-msg
...
Improve error message when plugin source cannot be determined or a non-directory is passed
10 months ago
Matt Farina
97ee09d935
Merge pull request #31365 from reddaisyy/main
...
refactor: use reflect.TypeFor
10 months ago
Matt Farina
2cfd41ec28
Merge pull request #31351 from gjenkins8/gjenkins/helm_version_kubeversion
...
feat: `helm version` print Kubernetes (client-go) version
10 months ago
Matt Farina
37de51428c
Merge pull request #31376 from benoittgt/accept-yaml-yml
...
Do not ignore *.yml file on linting while accepting *.yaml
10 months ago
Robert Sirchia
3924cf3781
Merge pull request #31362 from fabiocarneiro/patch-1
...
Clarify the intent of the resource instructions
10 months ago
Andreas Sommer
b05411506a
Improve error message when plugin source cannot be determined or a non-directory is passed
...
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
10 months ago
wyrapeseed
b9eadd3186
chore: fix some comment format
...
Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>
10 months ago