Matthieu MOREL
6d1490ed1e
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
4d0ae7f33a
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
4330bdea04
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
c8989d984f
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Orgad Shaneh
76eb37c01a
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
3 months ago
Terry Howe
1468449ff5
Merge pull request #31794 from mmorel-35/modernize-pkg-1-f9be97c
...
chore(pkg): fix modernize linter
3 months ago
Manuel Alonso
9817a68618
fix(install): check nil for restClientGetter and fix tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
3 months ago
Evans Mungai
5aac32077f
feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) ( #31592 )
...
* feat(create): add hidden --chart-api-version flag
Add --chart-api-version flag to helm create command to allow selecting
chart API version (v2 or v3) when creating a new chart.
- Default is v2 (existing behavior unchanged)
- v3 uses internal/chart/v3 scaffold generator
- Invalid versions return clear error message
- Works with --starter flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add HELM_EXPERIMENTAL_CHART_V3 feature gate to create command
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* make chartv3 private and use loader to load the chart
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Hide chart-api-version flag until chart v3 is officially released
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Conditionally hide the --chart-api-version flag if chart v3 is not enabled
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add internal gates package for internal feature gates
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add doc for internal/gates package
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matthieu MOREL
5cc2e55714
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/chart/v2/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
ba38159313
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
111d4e6e0e
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/chart/common/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
...
fix(values): preserve nil values when chart default is empty map
3 months ago
Pedro Tôrres
e8f386b5aa
add image index test
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
3 months ago
Pedro Tôrres
d983696e35
fix pulling charts from OCI indices
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
3 months ago
Matheus Pimenta
787b61cedb
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Scott Rigby
f928025cdb
Merge pull request #31717 from AustinAbro321/use-logger-with-waiter
...
fix: use kube logger with status waiter
3 months ago
Evans Mungai
9211dfef6a
Merge pull request #31743 from banjoh/em/document-uninstall-using-cascade
...
docs: document uninstall using cascade foreground flag
3 months ago
Austin Abro
ec0726523e
whitespace
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
Austin Abro
63b40a7a5e
use logger with waiter
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
Matheus Pimenta
b0b35f1231
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Evans Mungai
e70d59de7c
docs: document uninstall using cascade foreground flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matheus Pimenta
bbec77c1f7
bugfix(kstatus): do not wait forever on failed resources
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
George Jenkins
50546ef665
Merge pull request #31723 from matheuscscp/fix-storage-logger
...
bugfix(logging): fix storage not getting logger from driver
3 months ago
Matheus Pimenta
c1cc625323
chore(defaults): server-side apply SDK defaults should always match the CLI defaults
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Evans Mungai
828038a8fe
chore: clarify --wait flag help text
...
Improve the description to explain the three usage scenarios:
- --wait alone defaults to 'watcher' strategy
- --wait=<value> uses the specified strategy
- flag omitted defaults to 'hookOnly'
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Manuel Alonso
7c089bed26
Merge branch 'main' into main
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
3 months ago
Manuel Alonso
6501ef490a
chore(refactor): better testing and functionality for installing crd
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
4 months ago
Matheus Pimenta
a8eb527847
bugfix(storage): fix storage not getting logger from driver
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 months ago
Evans Mungai
40a9de1086
Merge pull request #31412 from fmuyassarov/devel/rollback
...
Fix rollback for missing resources
4 months ago
Evans Mungai
f46f1ce55d
Update pkg/kube/statuswait.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago
Matheus Pimenta
59ece92bed
pkg/kube: introduce support for custom kstatus readers
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 months ago
Manuel Alonso
0f949a92c1
fix(test): fix tests and check nil for restclient
...
Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>
4 months ago
Manuel Alonso Gonzalez
561410ae1d
fix(test): merge fix correctly
...
Signed-off-by: Manuel Alonso Gonzalez <434575+manute@users.noreply.github.com>
Signed-off-by: Manuel Alonso Gonzalez <m.alonso@Manuels-MacBook-Pro.local>
4 months ago
Evans Mungai
e751a70e84
fix(release): fix test compilation error
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago
Evans Mungai
2e2cb05855
Merge pull request #31427 from tisonkun/resolve-todo
...
Check plugin name is not used
4 months ago
Evans Mungai
05f25a3834
Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval
...
fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`
4 months ago
Manuel Alonso
df8ec771f9
Merge branch 'main' into main
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
4 months ago
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
4 months ago
Evans Mungai
0298b2ffd0
Remove refactorring changes from coalesce_test.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago
Evans Mungai
b8937ad192
Fix import
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago
Evans Mungai
a333bbaf27
Update pkg/chart/common/util/coalesce_test.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 months ago
Feruzjon Muyassarov
374aeb4b4e
Fix rollback for missing resources
...
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
4 months ago
Terry Howe
08f17fc947
Merge pull request #31683 from majiayu000/fix-13198---api-versions-is-undocumented-1230-2329
...
fix: `--api-versions` is undocumented
4 months ago
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
Add tests to action package to improve coverage
4 months ago
Mads Jensen
2d6d9c09c4
Replace reflect.Ptr with reflect.Pointer
...
The reflect package has a go:fix annotation for Ptr = Pointer.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
4 months ago
majiayu000
c7cc77b68d
Add documentation for --api-versions flag in template command
...
The --api-versions flag was undocumented in the template command's
help text. This adds usage documentation and examples showing both
comma-separated and multiple flag usage patterns.
Fixes #13198
Signed-off-by: majiayu000 <1835304752@qq.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: majiayu000 <1835304752@qq.com>
4 months ago
Matt Farina
fe1c749183
Fixing failing tests for cli-tools update
...
Tests were failing for cli-utils watcher because upstream k8s made
changes that impacted cli-utils. In k8s WatchListClient is now
enabled by default. Fake clients used for testing don't know this
semantic. cli-utils leverages reflection in k8s to handle this.
The Helm tests didn't handle this well.
The tests are updated to use PrependReactor and PrependWatchReactor
in the same way that cli-utils does for testing. This works without
wrapping the client.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
George Jenkins
118d90e810
Merge pull request #31677 from gjenkins8/gjenkins/new_client_set
...
chore: Replace deprecated `NewSimpleClientset`
4 months ago
George Jenkins
a15db7f087
Replace deprecated `NewSimpleClientset`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
Terry Howe
8802d959cb
Merge pull request #31104 from LinPr/fix
...
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
4 months ago
Manuel Alonso
00f0a48a7d
fix(install): add more tests and check nil file data
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
4 months ago
Manuel Alonso
0357e8d0f7
fix(test): no check empty resources
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
4 months ago
Manuel Alonso
52235cc0bf
fix(install): check lenght and file nil, add tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
4 months ago
Manuel Alonso
268593bf2e
fix(action): crd resources can be empty
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
4 months ago
George Jenkins
f05c21b6b6
Merge pull request #31296 from gjenkins8/gjenkins/runtime_kube_version
...
build: set kube version via `debug.BuildInfo`
4 months ago
Mujib Ahasan
170911459b
fix: casing issue fixed
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
4 months ago
George Jenkins
24e8297343
Merge pull request #31610 from mohsenmottaghi/fix-helm-4-watch-strategy
...
fix: use namespace-scoped watching to avoid cluster-wide LIST permiss…
4 months ago
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
4 months ago
Mujib Ahasan
94860626ce
fix: error handled correctly
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
4 months ago
Branch Vincent
c6d9a5bdc2
build: set kube version via `debug.BuildInfo`
...
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
Matt Farina
2108bc5070
Merge pull request #31448 from laervn/feat/add-no-headers-option
...
feat(repo): add --no-headers option to 'helm repo list'
4 months ago
Mujib Ahasan
12e8b715aa
fix: doc string added
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
4 months ago
Deepak Chethan
55a4aed67f
doc: update based on review suggestion
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
4 months ago
Mohsen Mottaghi
d6b35cedeb
test(statuswait): fix Copilot code review suggestion for goroutine in tests
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 months ago
Mohsen Mottaghi
a1543d5947
test(statuswait): add more tests suggested by Copilot code review
...
add missing coverage for the positive case where cluster-scoped resources (like ClusterRole or Namespace) should work correctly
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 months ago
Mohsen Mottaghi
dd44f4ecd0
test(statuswait): add some tests for statuswait
...
Adding some tests for multi namespace deployment, simulate restrcited rbac access and mixed namespace scope and cluster scope resources
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 months ago
Mohsen Mottaghi
3dd54ed0b6
fix: use namespace-scoped watching to avoid cluster-wide LIST permissions
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 months ago
Deepak
f92ae18977
fix(doc): Update default wait strategy
...
fixes : #31652
Default wait strategy is hookOnly, so updated the docs to reflect the same
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
4 months ago
Terry Howe
019e7e7145
Merge pull request #31650 from helm/gjenkins/fix_TestConcurrencyDownloadIndex
...
Fix `TestConcurrencyDownloadIndex` typo
4 months ago
tison
9772037ed8
Update to use slog
...
Signed-off-by: tison <wander4096@gmail.com>
4 months ago
tison
3c6557dcf5
Fix TestCliPluginExitCode
...
Signed-off-by: tison <wander4096@gmail.com>
4 months ago
tison
5196b8431a
Check plugin name is not used
...
Signed-off-by: tison <wander4096@gmail.com>
4 months ago
George Jenkins
592815ea2b
Fix `TestConcurrencyDownloadIndex` typo
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
d2ea7c4276
Merge pull request #31649 from atombrella/feature/errorlint_is_as
...
Use errors.Is to check for io.EOF and gzip.ErrHeader
4 months ago
Terry Howe
188ac4e834
Merge pull request #31635 from banjoh/em/fix-ssa-upgrade-install-cmd
...
fix(upgrade): pass --server-side flag to install when using upgrade --install
5 months ago
Mads Jensen
a490bb3c20
Use errors.Is to check for io.EOF and gzip.ErrHeader
...
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
5 months ago
Terry Howe
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
...
fix(uninstall): supersede deployed releases
5 months ago
Terry Howe
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
5 months ago
Terry Howe
2597088a20
Merge pull request #31586 from calvinbui/main
...
fix: use length check for MetaDependencies instead of nil comparison
5 months ago
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
5 months ago
Evans Mungai
3416dd5f21
Fix lint warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Evans Mungai
679f051980
Preserve nil values in chart already
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Evans Mungai
292fe70219
fix(values): preserve nil values when chart default is empty map
...
Only delete nil user values when overriding a non-nil chart default.
When chart has empty map or no default for a key, preserve user's nil.
| Scenario | Result |
|----------|--------|
| User sets `baz: ~`, chart has `baz: "value"` | Key deleted |
| User sets `baz: ~`, chart has empty map `{}` | Nil preserved |
| User sets `baz: ~`, chart has `baz: ~` | Nil preserved |
Fixes #31643
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
5 months ago
Terry Howe
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
5 months ago
wangjingcun
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
5 months ago
Evans Mungai
2dc581dc1c
fix(upgrade): pass --server-side flag to install when using upgrade --install
...
When running `helm upgrade --install` on a non-existent release, the
--server-side flag was not being passed to the install action. This
caused the install to always use server-side apply (the default),
ignoring --server-side=false.
Copy ServerSideApply and ForceConflicts from the upgrade client to the
install client when falling back to install.
Fixes #31627
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
5 months ago
George Jenkins
7edfdb6c5e
Merge pull request #31549 from benoittgt/31548
...
fix: prevent reporting fallback on version when none specified
5 months ago
George Jenkins
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
...
fix: preserve vendor suffixes in KubeVersion.GitVersion
5 months ago
Zadkiel AHARONIAN
8534663e73
fix(cli): handle nil config in EnvSettings.Namespace()
...
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
5 months ago
Zadkiel AHARONIAN
119341dca7
fix(getter): pass settings environment variables
...
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
5 months ago
Stephanie Hohenberg
a109ac2f06
fixes comment in install.go
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Stephanie Hohenberg
2f598ffc85
fixes tests after merge
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Stephanie Hohenberg
bb9356e182
fixes lint issue
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Stephanie Hohenberg
8cf4ad73c3
updates tests after rebase from master
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Stephanie Hohenberg
31131cff9b
Add tests to action package to improve coverage
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
5 months ago
Matt Farina
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
...
fix(lint): prevent segmentation violation on only comment yaml in multidoc
5 months ago
Mujib Ahasan
115409976b
update: test coverage added for helper function validateNameAndGenerateName
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
5 months ago
Mujib Ahasan
522d2fe615
update: helper function added for the business logic
...
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
5 months ago