Evans Mungai
5895a7e8f9
fix: default to foreground cascade when --wait is used in uninstall
...
When `helm uninstall --wait` is called, the default deletion propagation
is now "foreground" instead of "background". This ensures dependent
resources (like Pods, ReplicaSets created by controllers) are fully
cleaned up before the command returns.
Previously, with background deletion, parent resources were deleted
immediately while garbage collection handled dependents asynchronously.
This caused subsequent namespace deletions to hang for 2+ minutes waiting
for those dependent resources to be cleaned up.
With foreground deletion, Kubernetes waits for all dependents to be
deleted before removing the parent resource, ensuring `--wait` truly
waits for all cleanup to complete.
Cascade behavior by command:
| Command | Cascade |
|----------------------------------------------|------------|
| `helm uninstall release` | background |
| `helm uninstall release --wait` | foreground |
| `helm uninstall release --wait=hookOnly` | background |
| `helm uninstall release --wait --cascade=background` | background |
Users can still explicitly set `--cascade=background` to restore the
previous behavior if needed.
Fixes #31651
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 month ago
Matt Farina
4d1150d2af
Merge pull request #31415 from banjoh/em/increase-logging-test-coverage
...
chore: increase logging test coverage
1 month ago
Matt Farina
2108bc5070
Merge pull request #31448 from laervn/feat/add-no-headers-option
...
feat(repo): add --no-headers option to 'helm repo list'
1 month ago
Terry Howe
657e66d31d
Merge pull request #31654 from deepakchethan/fix_default-wait-strategy-doc
...
fix(doc): Update default wait strategy
1 month ago
Deepak Chethan
55a4aed67f
doc: update based on review suggestion
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
1 month ago
Robert Sirchia
9cbfce573b
Merge pull request #31645 from helm/dependabot/github_actions/main/actions/upload-artifact-6.0.0
...
chore(deps): bump actions/upload-artifact from 4.6.2 to 6.0.0
1 month ago
Deepak
f92ae18977
fix(doc): Update default wait strategy
...
fixes : #31652
Default wait strategy is hookOnly, so updated the docs to reflect the same
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
1 month ago
Terry Howe
019e7e7145
Merge pull request #31650 from helm/gjenkins/fix_TestConcurrencyDownloadIndex
...
Fix `TestConcurrencyDownloadIndex` typo
1 month ago
George Jenkins
b7b7a066af
Merge pull request #31215 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-0.36.0-flux.15
...
chore(deps): bump github.com/fluxcd/cli-utils from 0.36.0-flux.14 to 0.36.0-flux.15
1 month ago
dependabot[bot]
364a7aa942
chore(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.36.0-flux.14 to 0.36.0-flux.15.
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.36.0-flux.14...v0.36.0-flux.15 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 0.36.0-flux.15
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
George Jenkins
02b75a7029
Merge pull request #31565 from helm/gjenkins8-patch-1
...
Bump required go version (`go.mod` version)
1 month ago
George Jenkins
592815ea2b
Fix `TestConcurrencyDownloadIndex` typo
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
George Jenkins
d2ea7c4276
Merge pull request #31649 from atombrella/feature/errorlint_is_as
...
Use errors.Is to check for io.EOF and gzip.ErrHeader
1 month ago
Terry Howe
188ac4e834
Merge pull request #31635 from banjoh/em/fix-ssa-upgrade-install-cmd
...
fix(upgrade): pass --server-side flag to install when using upgrade --install
1 month ago
Mads Jensen
a490bb3c20
Use errors.Is to check for io.EOF and gzip.ErrHeader
...
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
Terry Howe
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
...
fix(uninstall): supersede deployed releases
1 month ago
Terry Howe
9d664eb9bf
Merge pull request #31587 from benoittgt/ensure-golangci-lint-proper-version
...
Inform if make test-style uses a different golangci-lint version than CI
1 month ago
Terry Howe
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
1 month ago
Terry Howe
2597088a20
Merge pull request #31586 from calvinbui/main
...
fix: use length check for MetaDependencies instead of nil comparison
1 month ago
dependabot[bot]
09ae0d4f2d
chore(deps): bump actions/upload-artifact from 4.6.2 to 6.0.0
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.2 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](ea165f8d65...b7c566a772 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
90ee28abf0
Merge pull request #31639 from helm/dependabot/go_modules/main/k8s-io-c801e060e5
...
chore(deps): bump the k8s-io group with 7 updates
1 month ago
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
1 month ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
1 month ago
Terry Howe
9a462ac570
Merge pull request #31622 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.46.0
...
chore(deps): bump golang.org/x/crypto from 0.45.0 to 0.46.0
1 month ago
Terry Howe
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
1 month ago
dependabot[bot]
1f8e84dff2
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.34.2` | `0.34.3` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.34.2` | `0.34.3` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.34.2` | `0.34.3` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.34.2` | `0.34.3` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.34.2` | `0.34.3` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.34.2` | `0.34.3` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.34.2` | `0.34.3` |
Updates `k8s.io/api` from 0.34.2 to 0.34.3
- [Commits](https://github.com/kubernetes/api/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/apiextensions-apiserver` from 0.34.2 to 0.34.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/apimachinery` from 0.34.2 to 0.34.3
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/apiserver` from 0.34.2 to 0.34.3
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/cli-runtime` from 0.34.2 to 0.34.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/client-go` from 0.34.2 to 0.34.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.34.2...v0.34.3 )
Updates `k8s.io/kubectl` from 0.34.2 to 0.34.3
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.34.2...v0.34.3 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.34.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
dependabot[bot]
e9a0510b02
chore(deps): bump golang.org/x/crypto from 0.45.0 to 0.46.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.45.0 to 0.46.0.
- [Commits](https://github.com/golang/crypto/compare/v0.45.0...v0.46.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.46.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
576f8b552e
Merge pull request #31640 from helm/dependabot/go_modules/main/golang.org/x/text-0.32.0
...
chore(deps): bump golang.org/x/text from 0.31.0 to 0.32.0
1 month ago
wangjingcun
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
1 month ago
dependabot[bot]
7fb17286fa
chore(deps): bump golang.org/x/text from 0.31.0 to 0.32.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.31.0 to 0.32.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.31.0...v0.32.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.32.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
cb78d7f7f3
Merge pull request #31638 from TerryHowe/feat-move-terryhowe-from-triage-to-maintainers
...
feat: move TerryHowe triage to maintainers
1 month ago
Terry Howe
e900a255ef
feat: move TerryHowe triage to maintainers
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 month ago
Matt Farina
e932c8cc2b
Merge pull request #31636 from mattfarina/fix-31634
...
Use latest patch release of Go in releases
1 month ago
Matt Farina
8f636b5bd2
Use latest patch release of Go in releases
...
GitHub Actions has a cache of tools, like Go, and it does not update
this cache when a new version comes out. It can take more than a week
for a new version to be available.
This change forces the action to check if a newer version is available
than is in the cache.
Closes #31634
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Robert Sirchia
894e1f3cb4
Merge pull request #31559 from helm/dependabot/go_modules/main/github.com/rubenv/sql-migrate-1.8.1
...
chore(deps): bump github.com/rubenv/sql-migrate from 1.8.0 to 1.8.1
1 month ago
dependabot[bot]
ea52f87398
chore(deps): bump github.com/rubenv/sql-migrate from 1.8.0 to 1.8.1
...
Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate ) from 1.8.0 to 1.8.1.
- [Commits](https://github.com/rubenv/sql-migrate/compare/v1.8.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: github.com/rubenv/sql-migrate
dependency-version: 1.8.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Robert Sirchia
d2600fed66
Merge pull request #31607 from helm/dependabot/go_modules/main/github.com/spf13/cobra-1.10.2
...
chore(deps): bump github.com/spf13/cobra from 1.10.1 to 1.10.2
1 month ago
Evans Mungai
2dc581dc1c
fix(upgrade): pass --server-side flag to install when using upgrade --install
...
When running `helm upgrade --install` on a non-existent release, the
--server-side flag was not being passed to the install action. This
caused the install to always use server-side apply (the default),
ignoring --server-side=false.
Copy ServerSideApply and ForceConflicts from the upgrade client to the
install client when falling back to install.
Fixes #31627
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 month ago
dependabot[bot]
a9bbffb4b6
chore(deps): bump github.com/spf13/cobra from 1.10.1 to 1.10.2
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Commits](https://github.com/spf13/cobra/compare/v1.10.1...v1.10.2 )
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-version: 1.10.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Robert Sirchia
65f46d2298
Merge pull request #31621 from helm/dependabot/go_modules/main/golang.org/x/term-0.38.0
...
chore(deps): bump golang.org/x/term from 0.37.0 to 0.38.0
1 month ago
dependabot[bot]
d195cfa2e3
chore(deps): bump golang.org/x/term from 0.37.0 to 0.38.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.37.0 to 0.38.0.
- [Commits](https://github.com/golang/term/compare/v0.37.0...v0.38.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.38.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
e1bdab214f
Merge pull request #31625 from mattfarina/fix-golangvuln
...
Fix govulncheck in CI
1 month ago
Matt Farina
24a82589f8
Run the vulnerability check on PR that change the file
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Matt Farina
bc9462f20f
Fix govulncheck in CI
...
govulncheck is having trouble checking out the source due to
multiple Authorization headers. The fix for this is to not
persist the credentials.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Matt Farina
5a97235092
Merge pull request #31628 from mattfarina/govulncheckonchange
...
Update the govulncheck.yml to run on change
1 month ago
Matt Farina
b825a18362
Update the govulncheck.yml to run on change
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
George Jenkins
7edfdb6c5e
Merge pull request #31549 from benoittgt/31548
...
fix: prevent reporting fallback on version when none specified
1 month ago
George Jenkins
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
...
fix: preserve vendor suffixes in KubeVersion.GitVersion
1 month ago
Robert Sirchia
5bab984cef
Merge pull request #31599 from helm/dependabot/github_actions/main/actions/checkout-6.0.1
...
chore(deps): bump actions/checkout from 6.0.0 to 6.0.1
2 months ago