Terry Howe
514b151c72
fix(registry): use URL.Host for ghcr.io check and retry with OAuth2 on 401/403
...
- reqHost() prefers req.URL.Hostname() over req.Host so the ghcr.io
special case fires correctly for ORAS-constructed requests where the
host lives in req.URL, not req.Host
- Add dedicated TestAuthorizer_Do_GHCRSkipsBearerProbe test that sets
the host via URL (as ORAS does) to verify the ghcr.io path
- Redesign Do() retry logic: first attempt uses standard auth; only
after a 401/403 do we retry with ForceAttemptOAuth2=true to support
registries whose token endpoints require OAuth2-style requests
(previously setting it before the first attempt caused 400 errors on
standard registries)
- Disable attemptBearerAuthentication after successful fallback retry
so basic-auth-only registries pay the probe cost only once
- Add GoDoc comments on Authorizer, NewAuthorizer, and EnableCache
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
0d9e74dfa7
style: fix lint issues in authorizer_test.go
...
Use range-over-int for loops and rename unused parameters to _.
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
d86be80107
fix: address authorizer review comments
...
- Normalize ghcr.io hostname using net.SplitHostPort + strings.EqualFold
- Save and restore ForceAttemptOAuth2 via defer so it is always false
after Do() returns, fixing regression tests
- Explicitly switch to basic auth (ForceAttemptOAuth2=false) before
retrying after a 401/403 error so the second attempt uses a different
auth mode
- Fix require.NoError called from goroutine in concurrent test; use
t.Errorf+return instead (testify require is not goroutine-safe)
- Replace TestAuthorizer_Do_StatusCodeErrorChecking with tests that
exercise Authorizer.Do directly: RetriesOn401 and NoRetryOn404
- Restore TestLogin_ResetsForceAttemptOAuth2_OnSuccess and
TestLogin_ResetsForceAttemptOAuth2_OnFailure regression tests that
were removed; these now pass with the defer-based restore
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
4d55d14033
chore: handle specific errors
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
496031f299
chore: handle mutliple threads
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
7e0d14b15b
simplify tests
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
e431e8b36e
feature: add registry authorizer retry
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 week ago
Terry Howe
b3a458fde9
Merge pull request #31970 from isumitsolanki/fix/31965-decouple-cli-from-kube
...
refactor(cli): decouple EnvSettings from pkg/kube to avoid import cycles
1 week ago
Terry Howe
bdf2747c5f
Merge pull request #32095 from helm/dependabot/github_actions/main/github/codeql-action-4.35.3
...
chore(deps): bump github/codeql-action from 4.35.2 to 4.35.3
1 week ago
Terry Howe
547df4a2a0
Merge pull request #32096 from helm/dependabot/go_modules/main/github.com/distribution/distribution/v3-3.1.1
...
chore(deps): bump github.com/distribution/distribution/v3 from 3.1.0 to 3.1.1
1 week ago
dependabot[bot]
12f2c41c0d
chore(deps): bump github.com/distribution/distribution/v3
...
Bumps [github.com/distribution/distribution/v3](https://github.com/distribution/distribution ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/distribution/distribution/releases )
- [Commits](https://github.com/distribution/distribution/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: github.com/distribution/distribution/v3
dependency-version: 3.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
dependabot[bot]
58e8ffdc33
chore(deps): bump github/codeql-action from 4.35.2 to 4.35.3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.35.2 to 4.35.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](95e58e9a2c...e46ed2cbd0 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.35.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
Terry Howe
707afe4b22
Merge pull request #32094 from helm/dependabot/go_modules/main/github.com/Masterminds/semver/v3-3.5.0
...
chore(deps): bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0
1 week ago
dependabot[bot]
e61bbfbfff
chore(deps): bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0
...
Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/Masterminds/semver/releases )
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Masterminds/semver/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
dependency-version: 3.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
Terry Howe
ea10188070
Merge pull request #32090 from matheuscscp/cli-utils-1.2-c-r-0.24
...
Upgrade kstatus to 1.2 and controller-runtime to 0.24
2 weeks ago
Matheus Pimenta
081c6dff53
Upgrade kstatus to 1.2 and controller-runtime to 0.24
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 weeks ago
Terry Howe
96c152cb1a
Merge pull request #31923 from gaganhr94/fix/token-permissions
...
fix: adds topLevel permissions to improve openSSF scores
2 weeks ago
Terry Howe
38f3704983
Merge pull request #32034 from cairon-ab/fix/pull-debug-output
...
fix: add debug logging to HTTP getter for helm pull
2 weeks ago
Gagan H R
277d970255
fix: adds topLevel permissions to improve openSSF scores
...
Signed-off-by: Gagan H R <hrgagan4@gmail.com>
2 weeks ago
Terry Howe
fbc2791886
Merge pull request #32078 from matheuscscp/go-1.26-k8s-1.36-cli-utils-1.1
...
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
2 weeks ago
Terry Howe
2fb101a20b
Merge pull request #31755 from scottrigby/template-cmd-deprecate-notes-flags
...
fix(template): deprecate unused --hide-notes and --render-subchart-notes flags
2 weeks ago
Matheus Pimenta
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
2 weeks ago
George Jenkins
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
2 weeks ago
Matheus Pimenta
8f56f24d63
fix(templating): hooks conflicting with templates in post-renderers ( #32049 )
...
* fix(templating): hooks conflicting with templates in post-renderers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* fix(templating): allow disabling hooks from postrenderers entirely
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
Terry Howe
29d309e56b
Merge pull request #31981 from abhay1999/fix/ssa-error-context
...
fix(kube): clarify server-side apply patch errors
3 weeks ago
George Jenkins
66e5049405
Merge pull request #32008 from rhysmcneill/bugfix/helm-upgrade-err-variable-defect
...
fix(action): return correct error variable in prepareUpgrade
3 weeks ago
Terry Howe
1d6469cfcb
Merge pull request #32057 from MohitSalvi16/docs/fix-contributing-typos
...
docs: fix grammar and spacing in CONTRIBUTING.md
3 weeks ago
Mohit
db40adb1d1
docs: fix grammar and spacing in CONTRIBUTING.md
...
Signed-off-by: Mohit <salvimohit08@gmail.com>
3 weeks ago
Terry Howe
20eae2bb0f
Merge pull request #32052 from helm/dependabot/go_modules/main/k8s-io-dc9379caa6
...
chore(deps): bump the k8s-io group across 1 directory with 7 updates
3 weeks ago
dependabot[bot]
775e794319
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.35.3` | `0.35.4` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.35.3` | `0.35.4` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.35.3` | `0.35.4` |
Updates `k8s.io/api` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/api/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiextensions-apiserver` from 0.35.3 to 0.35.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apimachinery` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiserver` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/cli-runtime` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/client-go` from 0.35.3 to 0.35.4
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/kubectl` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.35.3...v0.35.4 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
3 weeks ago
Terry Howe
83a4611908
Merge pull request #12932 from AndiDog/error-message
...
Make error message instructional for the case of lock file being out of date
3 weeks ago
Terry Howe
354c85d6a4
Merge pull request #32050 from helm/dependabot/github_actions/main/github/codeql-action-4.35.2
...
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
4 weeks ago
dependabot[bot]
934ace35df
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.35.1 to 4.35.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c10b8064de...95e58e9a2c )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.35.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
4 weeks ago
Matheus Pimenta
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 weeks ago
Terry Howe
c51456c45d
Merge pull request #31979 from Y0-L0/jlohmer/coalesce-nil
...
Jlohmer/coalesce nil
4 weeks ago
Terry Howe
1c007051ae
Merge pull request #32045 from helm/dependabot/go_modules/main/github.com/mattn/go-shellwords-1.0.13
...
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
4 weeks ago
dependabot[bot]
48e2b7ddd4
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
...
Bumps [github.com/mattn/go-shellwords](https://github.com/mattn/go-shellwords ) from 1.0.12 to 1.0.13.
- [Commits](https://github.com/mattn/go-shellwords/compare/v1.0.12...v1.0.13 )
---
updated-dependencies:
- dependency-name: github.com/mattn/go-shellwords
dependency-version: 1.0.13
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
4 weeks ago
Evans Mungai
a8e249714f
Update pkg/chart/common/util/coalesce.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
4 weeks ago
Johannes Lohmer
52fc971da3
test(values): Add test for nil cleanup in partially overridden subchart maps
...
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
4 weeks ago
Johannes Lohmer
00638773d1
fix(values): do not copy chart-default nils into coalesced values
...
Only user-supplied nils should survive coalescing. Chart-default nils
defaults, not just user overrides. This caused:
- %!s(<nil>) in templates using Bitnami common.secrets.key (#31919 )
- pluck fallbacks returning nil instead of falling through to globals
(#31971 )
Fixes #31919
Fixes #31971
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
4 weeks ago
Johannes Lohmer
6eb4ebf0e1
test(values): add test for subchart nil producing %!s(<nil>)
...
Regression test for the Bitnami common.secrets.key issue.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
4 weeks ago
Johannes Lohmer
5cb4e7d992
test(values): add tests for subchart nil value regressions
...
Three test cases that cover the regression scenarios introduced
by the #31644 nil preservation fix:
- subchart default nils should be cleaned up
when parent doesn't set those keys (#31919 )
- user-supplied null should erase subchart defaults (#31919 )
- subchart default nil should not shadow global values via pluck (#31971 )
Tests are expected to fail until the regression is fixed.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
4 weeks ago
Terry Howe
1164a5fbda
Merge pull request #32037 from helm/dependabot/github_actions/main/actions/upload-artifact-7.0.1
...
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
4 weeks ago
George Jenkins
bd061e0cd7
Merge pull request #32016 from TerryHowe/fix/flaky-waitfordelete-timeout
...
test(kube): fix flaky WaitForDelete timing in status wait tests
4 weeks ago
dependabot[bot]
b5c7c80de3
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](bbbca2ddaa...043fb46d1a )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 7.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matheus Pimenta
a27f1add79
fix(templating): fix wrong YAML separator parsing for post-renderers ( #31941 )
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
1 month ago
Cairon
c26be60d81
fix: add debug logging to HTTP getter for helm pull
...
When running 'helm pull --debug', no debug output was printed because
the HTTP getter did not emit any slog.Debug messages. This adds
slog.Debug calls to log the URL being fetched and the response status
when debug-level logging is enabled.
Fixes helm/helm#31098
Signed-off-by: Cairon <cairon-ab@users.noreply.github.com>
1 month ago
Terry Howe
cf69a6ef70
Merge pull request #32030 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.50.0
...
chore(deps): bump golang.org/x/crypto from 0.49.0 to 0.50.0
1 month ago
Robert Sirchia
38213a9548
Merge pull request #32000 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.3
...
chore(deps): bump github.com/lib/pq from 1.12.2 to 1.12.3
1 month ago
Terry Howe
ed7c3e47a9
Merge pull request #32028 from gjenkins8/gjenkins/release_notes_v4
...
chore: Update release notes script for Helm v4
1 month ago