4e9ca06856
chore: go mod tidy after rebase on main
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
3cbee7e935
fix(registry): use plain-http registry in token-auth scope test
...
The scope test configured a TLS registry while advertising an http token
realm. oras refuses to send credentials to an http token realm when the
registry itself was contacted over https, so the auth server was never
reached and the test timed out ("timeout waiting for auth request").
Use a plain-http registry so the registry and token-realm schemes match;
the scope carried in the token request is what this test verifies, and
that is independent of TLS.
Also make the auth handler's channel send non-blocking so that a client
retry can never block the handler and stall the push/pull flow, which
addresses the review comment about a potential deadlock.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
26ada49c1a
Update pkg/registry/client.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 weeks ago
9b7a70f0ca
test: improve client_scope_test.go to avoid data races and brittle assertions
...
- Fix data race by using channel instead of shared variable for requestURL
- Make assertions more robust by parsing URL and checking query parameters instead of exact string matching
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
ee181f4570
fix typos in withScopeHint function comment
...
- Change 'bellow' to 'below' (spelling correction in multiple places)
- Change 'WithScopeHint' to 'withScopeHint' to match actual function name
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
1f0a728496
fix registry test failures by adjusting DockerRegistryHost and auth server listener management
...
- Change DockerRegistryHost to use 127.0.0.1 for HTTP tests and helm-test-registry for TLS tests to match certificate hostname
- Add defer ln.Close() to prevent resource leak in token auth server setup
- Restore requestURL variable and assertion in test body instead of handler to avoid potential race condition
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
8883c9cc70
fix variable naming requestUrl -> requestURL
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
530e728ea9
fix typo, remove unnecessary code, fix to avoid to use the assertion in http hanlder
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
4 weeks ago
26e5071f66
change suite.Nil, suite.NotNill to more proper function(suite.NoError, suite.Error)
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
8c8d6e3262
change client_scope_test.go to use httptest
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
9d77ccd46d
fix typo
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
fc743b2a1b
remove freeport dependency
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
319e06cda3
add newline in license header
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
301e3a12d5
fix scope when helm push to a registry that use token auth
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
4 weeks ago
af25d22902
Merge pull request #32275 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.3.0
...
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
1 month ago
943242fb83
Merge pull request #32276 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-1.2.2
...
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
1 month ago
5a9b8a788f
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/fluxcd/cli-utils/releases )
- [Commits](https://github.com/fluxcd/cli-utils/compare/v1.2.1...v1.2.2 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 1.2.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
f76136d39f
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.2.1 to 9.3.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](82606bf257...ba0d7d2ec0
1 month ago
188d331dc3
Merge pull request #32259 from gjenkins8/refactor/testify-pkg-cli
...
refactor(pkg/cli): convert tests to testify assert/require
1 month ago
144246cd28
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
187a02298a
Merge pull request #32263 from helm/dependabot/github_actions/main/actions/setup-go-6.5.0
...
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
1 month ago
07faec5593
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](4a3601121d...924ae3a1cd
1 month ago
1ffd0012d3
Merge pull request #32221 from gjenkins8/refactor/testify-pkg-small
...
refactor(pkg): convert tests to testify assert/require
1 month ago
dd443e9685
Merge pull request #32260 from gjenkins8/refactor/testify-internal-small
...
refactor(internal): convert tests to testify assert/require
1 month ago
addbab2e64
refactor(internal): convert tests to testify assert/require
...
Convert internal/urlutil, internal/cli/output, internal/monocular,
and internal/sympath test files from native Go testing patterns
(t.Errorf, t.Fatalf, t.Error, t.Fatal) to github.com/stretchr/testify
equivalents (assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
0bca9871ad
Merge pull request #32254 from gjenkins8/refactor/testify-pkg-registry
...
refactor(pkg/registry): convert tests to testify assert/require
1 month ago
dd31a27000
Merge pull request #32256 from gjenkins8/refactor/testify-internal-util
...
refactor(internal): convert tests to testify assert/require
1 month ago
7e2bdcb526
Merge pull request #32255 from gjenkins8/refactor/testify-pkg-release
...
refactor(pkg/release): convert tests to testify assert/require
1 month ago
662c99f910
Merge pull request #32253 from gjenkins8/refactor/testify-repotest
...
refactor(repotest): convert tests to testify assert/require
1 month ago
645e6369a7
Merge pull request #32252 from gjenkins8/refactor/testify-pkg-strvals
...
refactor(pkg/strvals): convert tests to testify assert/require
1 month ago
4e810c9366
Merge pull request #32251 from gjenkins8/refactor/testify-cmd-helm
...
refactor(cmd/helm): convert tests to testify assert/require
1 month ago
7ab295fcfc
refactor(internal/release): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
4cce0e9e2a
refactor(pkg/release): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
8b0a167484
refactor(pkg/registry): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
3ce02c585a
refactor(internal): convert tests to testify assert/require
...
Convert internal/fileutil, internal/tlsutil, and internal/resolver
test files from native Go testing patterns (t.Errorf, t.Fatalf,
t.Error, t.Fatal) to github.com/stretchr/testify equivalents
(assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
b42faba9d2
refactor(repotest): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
74fa4fceb8
Merge pull request #31862 from mmorel-35/context
...
chore: enable contextcheck, fatcontext and noctx linters
1 month ago
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
be45213874
Merge pull request #32238 from helm/dependabot/github_actions/main/actions/checkout-7.0.0
...
chore(deps): bump actions/checkout from 6.0.3 to 7.0.0
1 month ago
5a64a89e99
Merge pull request #32241 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.7.0
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.6.1 to 0.7.0
1 month ago
a0c7d1e1f5
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.6.1 to 0.7.0.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.6.1...v0.7.0 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.7.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
5848047c6b
chore(deps): bump actions/checkout from 6.0.3 to 7.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](df4cb1c069...9c091bb21b
1 month ago
05b2746081
Merge pull request #32184 from atkrad/fix/kube-isreachable-nil-panic
...
fix panic on repeated IsReachable calls
1 month ago
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
1 month ago
5b1fc3bbf9
Merge pull request #32235 from TerryHowe/fix/testifylint-empty-assertions
...
test: use assert.Empty for zero-length assertions in validate_test
1 month ago
c36e4d52bd
test: use assert.Empty for zero-length assertions in validate_test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 month ago
f59fae54cc
Merge pull request #32233 from s3onghyun/docs-version-desc-typo
...
docs: fix typo in helm version command description
1 month ago
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
1 month ago
b7ebb5575f
Merge pull request #32210 from helm/dependabot/go_modules/main/k8s-io-5cc882a701
...
chore(deps): bump the k8s-io group across 1 directory with 7 updates
1 month ago
dd442c0cc7
docs: fix typo in helm version command description
...
Signed-off-by: s3onghyun <s3onghyun.hong@gmail.com>
1 month ago
kimsm28
Terry Howe
dependabot[bot]
George Jenkins
Matthieu MOREL
s3onghyun