Terry Howe
4e24ee41a4
fix(kube): prevent spurious early exit in WaitForDelete during informer sync
...
During informer initialization there is a brief window where watched
resources appear as Unknown before their real statuses are delivered.
The statusObserver skips Unknown resources when waiting for deletion
(they may have been deleted before the watch started), but if *all*
resources are in that transient Unknown state the skipped-resource list
is empty. AggregateStatus on an empty slice returns the desired status,
causing cancel() to be called immediately — before any real status event
has arrived.
Guard against this by tracking the count of Unknown-skipped resources.
When every resource was Unknown-skipped and none have a definitive status
yet, defer the early-cancel decision until at least one resource reports
a real status. This preserves the correct behaviour for resources that
were genuinely deleted before the watch started (they eventually receive
a NotFound or stay Unknown, and the aggregate succeeds), while fixing
the race for resources that are transiently Unknown at startup.
Also tighten the ctx.Err() check in waitForDelete: only append a
deadline error when there are resource-specific errors to accompany it.
A timeout while all resources are Unknown or NotFound is not itself an
error — the resources are in an acceptable state for a delete wait.
Fixes: TestStatusWaitForDelete/error_when_not_all_objects_are_deleted
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
3 weeks ago
Terry Howe
fbc2791886
Merge pull request #32078 from matheuscscp/go-1.26-k8s-1.36-cli-utils-1.1
...
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
3 weeks ago
Terry Howe
2fb101a20b
Merge pull request #31755 from scottrigby/template-cmd-deprecate-notes-flags
...
fix(template): deprecate unused --hide-notes and --render-subchart-notes flags
3 weeks ago
Matheus Pimenta
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
George Jenkins
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
3 weeks ago
Matheus Pimenta
8f56f24d63
fix(templating): hooks conflicting with templates in post-renderers ( #32049 )
...
* fix(templating): hooks conflicting with templates in post-renderers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* fix(templating): allow disabling hooks from postrenderers entirely
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
4 weeks ago
Terry Howe
29d309e56b
Merge pull request #31981 from abhay1999/fix/ssa-error-context
...
fix(kube): clarify server-side apply patch errors
4 weeks ago
George Jenkins
66e5049405
Merge pull request #32008 from rhysmcneill/bugfix/helm-upgrade-err-variable-defect
...
fix(action): return correct error variable in prepareUpgrade
4 weeks ago
Terry Howe
1d6469cfcb
Merge pull request #32057 from MohitSalvi16/docs/fix-contributing-typos
...
docs: fix grammar and spacing in CONTRIBUTING.md
4 weeks ago
Mohit
db40adb1d1
docs: fix grammar and spacing in CONTRIBUTING.md
...
Signed-off-by: Mohit <salvimohit08@gmail.com>
4 weeks ago
Terry Howe
20eae2bb0f
Merge pull request #32052 from helm/dependabot/go_modules/main/k8s-io-dc9379caa6
...
chore(deps): bump the k8s-io group across 1 directory with 7 updates
4 weeks ago
dependabot[bot]
775e794319
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.35.3` | `0.35.4` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.35.3` | `0.35.4` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.35.3` | `0.35.4` |
Updates `k8s.io/api` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/api/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiextensions-apiserver` from 0.35.3 to 0.35.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apimachinery` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiserver` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/cli-runtime` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/client-go` from 0.35.3 to 0.35.4
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/kubectl` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.35.3...v0.35.4 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
4 weeks ago
Terry Howe
83a4611908
Merge pull request #12932 from AndiDog/error-message
...
Make error message instructional for the case of lock file being out of date
1 month ago
Terry Howe
354c85d6a4
Merge pull request #32050 from helm/dependabot/github_actions/main/github/codeql-action-4.35.2
...
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
1 month ago
dependabot[bot]
934ace35df
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.35.1 to 4.35.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c10b8064de...95e58e9a2c )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.35.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matheus Pimenta
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
1 month ago
Terry Howe
c51456c45d
Merge pull request #31979 from Y0-L0/jlohmer/coalesce-nil
...
Jlohmer/coalesce nil
1 month ago
Terry Howe
1c007051ae
Merge pull request #32045 from helm/dependabot/go_modules/main/github.com/mattn/go-shellwords-1.0.13
...
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
1 month ago
dependabot[bot]
48e2b7ddd4
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
...
Bumps [github.com/mattn/go-shellwords](https://github.com/mattn/go-shellwords ) from 1.0.12 to 1.0.13.
- [Commits](https://github.com/mattn/go-shellwords/compare/v1.0.12...v1.0.13 )
---
updated-dependencies:
- dependency-name: github.com/mattn/go-shellwords
dependency-version: 1.0.13
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Evans Mungai
a8e249714f
Update pkg/chart/common/util/coalesce.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 month ago
Johannes Lohmer
52fc971da3
test(values): Add test for nil cleanup in partially overridden subchart maps
...
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
1 month ago
Johannes Lohmer
00638773d1
fix(values): do not copy chart-default nils into coalesced values
...
Only user-supplied nils should survive coalescing. Chart-default nils
defaults, not just user overrides. This caused:
- %!s(<nil>) in templates using Bitnami common.secrets.key (#31919 )
- pluck fallbacks returning nil instead of falling through to globals
(#31971 )
Fixes #31919
Fixes #31971
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
1 month ago
Johannes Lohmer
6eb4ebf0e1
test(values): add test for subchart nil producing %!s(<nil>)
...
Regression test for the Bitnami common.secrets.key issue.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
1 month ago
Johannes Lohmer
5cb4e7d992
test(values): add tests for subchart nil value regressions
...
Three test cases that cover the regression scenarios introduced
by the #31644 nil preservation fix:
- subchart default nils should be cleaned up
when parent doesn't set those keys (#31919 )
- user-supplied null should erase subchart defaults (#31919 )
- subchart default nil should not shadow global values via pluck (#31971 )
Tests are expected to fail until the regression is fixed.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
1 month ago
Terry Howe
1164a5fbda
Merge pull request #32037 from helm/dependabot/github_actions/main/actions/upload-artifact-7.0.1
...
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
1 month ago
George Jenkins
bd061e0cd7
Merge pull request #32016 from TerryHowe/fix/flaky-waitfordelete-timeout
...
test(kube): fix flaky WaitForDelete timing in status wait tests
1 month ago
dependabot[bot]
b5c7c80de3
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](bbbca2ddaa...043fb46d1a )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 7.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matheus Pimenta
a27f1add79
fix(templating): fix wrong YAML separator parsing for post-renderers ( #31941 )
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
1 month ago
Terry Howe
cf69a6ef70
Merge pull request #32030 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.50.0
...
chore(deps): bump golang.org/x/crypto from 0.49.0 to 0.50.0
1 month ago
Robert Sirchia
38213a9548
Merge pull request #32000 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.3
...
chore(deps): bump github.com/lib/pq from 1.12.2 to 1.12.3
1 month ago
Terry Howe
ed7c3e47a9
Merge pull request #32028 from gjenkins8/gjenkins/release_notes_v4
...
chore: Update release notes script for Helm v4
1 month ago
dependabot[bot]
953f5f031b
chore(deps): bump golang.org/x/crypto from 0.49.0 to 0.50.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.49.0 to 0.50.0.
- [Commits](https://github.com/golang/crypto/compare/v0.49.0...v0.50.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.50.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Terry Howe
79493bc6a8
Merge pull request #32031 from helm/dependabot/go_modules/main/golang.org/x/term-0.42.0
...
chore(deps): bump golang.org/x/term from 0.41.0 to 0.42.0
1 month ago
dependabot[bot]
10fc5f335b
chore(deps): bump golang.org/x/term from 0.41.0 to 0.42.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.41.0 to 0.42.0.
- [Commits](https://github.com/golang/term/compare/v0.41.0...v0.42.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.42.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Terry Howe
36030c947b
Merge pull request #32029 from helm/dependabot/go_modules/main/golang.org/x/text-0.36.0
...
chore(deps): bump golang.org/x/text from 0.35.0 to 0.36.0
1 month ago
dependabot[bot]
d89e7c6076
chore(deps): bump golang.org/x/text from 0.35.0 to 0.36.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.35.0 to 0.36.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.35.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.36.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
George Jenkins
8a95461925
chore: Update release notes script for Helm v4
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
Terry Howe
be5aaf7e34
Merge pull request #32024 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-1.0.0
...
chore(deps): bump github.com/fluxcd/cli-utils from 0.37.2-flux.1 to 1.0.0
1 month ago
dependabot[bot]
bd5027a9cf
chore(deps): bump github.com/lib/pq from 1.12.2 to 1.12.3
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.12.2 to 1.12.3.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.12.2...v1.12.3 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.12.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Terry Howe
fa194a0609
Merge pull request #32025 from gjenkins8/gjenkins/fix_lint
...
fix: unnecessary-format lint issues from merge
1 month ago
George Jenkins
087736b66e
fix: unnecessary-format lint issues from merge
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
George Jenkins
bc215d8c19
Merge commit from fork
...
fix: Plugin missing provenance bypass
1 month ago
George Jenkins
586eb57338
fix: Plugin missing provenance bypass
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
George Jenkins
f7c4d75574
Merge commit from fork
...
fix: Chart dot-name path bug
1 month ago
George Jenkins
f8afb35f4e
Merge commit from fork
...
fix: Plugin version path traversal
1 month ago
dependabot[bot]
c8c5dfad63
chore(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.37.2-flux.1 to 1.0.0.
- [Release notes](https://github.com/fluxcd/cli-utils/releases )
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.37.2-flux.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 1.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
8985aed4e3
Merge pull request #32022 from helm/dependabot/go_modules/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp-1.43.0
...
chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp from 1.42.0 to 1.43.0
1 month ago
dependabot[bot]
998466cfcf
chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp
...
Bumps [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp](https://github.com/open-telemetry/opentelemetry-go ) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.42.0...v1.43.0 )
---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp
dependency-version: 1.43.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
Matt Farina
e8988d3ead
Merge pull request #32021 from helm/dependabot/go_modules/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp-1.43.0
...
chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from 1.42.0 to 1.43.0
1 month ago
dependabot[bot]
b0cec589f5
chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
...
Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go ) from 1.42.0 to 1.43.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.42.0...v1.43.0 )
---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
dependency-version: 1.43.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago