45c5f3aaca
Deal with golint warning with private executeShutdownFunc
...
```
Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive)
func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 weeks ago
70fc5f97e2
Code review
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
9f1c8a26f0
Fix linting issue
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
6bb5bcc212
Update pkg/action/hooks.go
...
Co-authored-by: Marco Lecheler <marco@task.media>
Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>
1 month ago
d9301441f4
added check for nil shutdown
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
7a61ebf013
cleaned up empty line
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
10714772be
updated comment and made defer of shutdown function return errors as before and not the possible shutdown error
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
7a557580e1
added shutdown hook that is executed after the logs have been retrieved
...
Signed-off-by: Michelle Fernandez Bieber <mfbieber@gmail.com>
1 month ago
722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
1 month ago
e824d94f74
Merge pull request #31557 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.1.0
...
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
1 month ago
4d54bea5ff
Merge pull request #31491 from benoittgt/31490-plugin-name-helper
...
feat: improve plugin name validation error messages and field name detection (v1)
1 month ago
00e12b8477
Merge pull request #31560 from mattfarina/fix-kube-client-logging
...
Fix kube client logging
1 month ago
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
936cd328ac
Fix kube client logging
...
The kube client logging is based on the actionConfig logging. This
is setup to use slog.Default() before the logging flags are parsed
and logging is setup.
newRootCmdWithConfig changes the logging but it wasn't picked up
for actionConfig or the kube client. This change updates the logging
to include any changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
1 month ago
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
1 month ago
cb35947ae6
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](0a35821d5c...e7fa5ac41e
1 month ago
bd9425c00b
Merge pull request #31550 from helm/dependabot/github_actions/main/actions/setup-go-6.1.0
...
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
1 month ago
2a614eeeab
Merge pull request #31551 from helm/dependabot/github_actions/main/actions/checkout-6.0.0
...
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
1 month ago
4fddc64678
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](93cb6efe18...1af3b93b68
1 month ago
b87f2da2f8
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.5.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](d35c59abb0...4dc6199c7b
1 month ago
df6aafeeee
Merge pull request #31462 from mattfarina/load-archive
...
Adding a LoadArchive to common loader
1 month ago
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
1 month ago
eb3da36e2e
Merge pull request #31530 from shuv0id/improve-debug-logging
...
fix: add missing context to debug logs
1 month ago
47e940341f
Merge pull request #31527 from helm/dependabot/github_actions/main/actions/checkout-5.0.1
...
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
1 month ago
c185492188
Merge pull request #31540 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.6.1
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.6.0 to 0.6.1
1 month ago
02000f4710
Merge pull request #31542 from helm/dependabot/go_modules/golang.org/x/crypto-0.45.0
...
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
1 month ago
c2405ce8c2
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.44.0 to 0.45.0.
- [Commits](https://github.com/golang/crypto/compare/v0.44.0...v0.45.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.45.0
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
28baa972c1
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.6.0...v0.6.1 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.6.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
63dcb5c74c
Merge pull request #31464 from benoittgt/fix-test
...
Properly test error messages on pull command's test
1 month ago
a7ba4fc80e
Merge pull request #31514 from yxxhero/fix-helm-plugin-cmd-args-env-issues
...
Refactor environment variable expansion in PrepareCommands and update tests
1 month ago
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
2dc5864f44
fix: add missing context to debug logs
...
Adds chart name to dependency logs, namespace to resource waiting logs,
and confirmation message when all resources are ready.
Addresses #31520
Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com>
1 month ago
f6ceae9b74
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](08c6903cd8...93cb6efe18
1 month ago
f8a49f1852
fixup test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
a9cdc78116
logs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
b1a976073f
fix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
a75fcc2948
Merge pull request #31478 from promalert/main
...
refactor: use strings.Builder to improve performance
1 month ago
71591ee63e
style: linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
b296cbef6c
test: split tests between valid and invalid
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
9b242dd9ed
test: convert tests to table drive tests
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
c81a09b89a
test: refactor TestMetadataLegacyValidate to be more generic
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
8c87024860
update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
1 month ago
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
ebd5f53fc3
Merge pull request #31421 from benoittgt/improve-doc-wait-strategy
...
Unify --wait strategy inputs, clarify defaults and docs; avoid SDK timeout footgun
1 month ago
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
2d49f0cb4a
Refactor environment variable expansion in PrepareCommands and update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
1 month ago
3e06a8a440
Merge pull request #31512 from benoittgt/31508-client-go
...
fix: correct LDFLAGS path for default Kubernetes version
1 month ago
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
1 month ago
b6a8c65216
fix: correct LDFLAGS path for default Kubernetes version
...
The Makefile LDFLAGS were pointing to an incorrect package path
(helm.sh/helm/v4/pkg/chart/common/util) that doesn't exist, causing
the k8sVersionMajor and k8sVersionMinor variables to silently fail
to be set. This left the hardcoded defaults (1.20) in place.
After this fix, `helm template` now correctly defaults to Kubernetes
v1.34.0 (matching the bundled client-go version) instead of v1.20.0,
ensuring charts render with current stable API versions.
Testing scenario:
```sh
cat > /tmp/test-chart/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart
version: 1.0.0
kubeVersion: ">= 1.28.0-0"
EOF
./bin/helm template test-release /tmp/test-chart
cat > /tmp/test-chart-fail/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart-fail
version: 1.0.0
kubeVersion: ">= 1.35.0-0"
EOF
./bin/helm template test-release /tmp/test-chart-fail
Exit code 1
Error: chart requires kubeVersion: >= 1.35.0-0 which is incompatible with Kubernetes v1.34.0
```
Fixes #31508
Closes #31501
Closes #31502
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
Benoit Tigeot
Michelle Fernandez Bieber
Michelle Fernandez Bieber
Robert Sirchia
Scott Rigby
George Jenkins
Mads Jensen
Matt Farina
dependabot[bot]
shuv0id
yxxhero