Scott Rigby
390dacae32
Merge pull request #10527 from scottrigby/oci-deppendency-version-range-support
...
OCI version range support
3 years ago
Scott Rigby
808a2d1908
Change underscore (_) back to plus (+) for Helm
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
ee382eb169
Remove unneeded assignment
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
bd754a054c
Bring exact version check logic from IndexFile.Get into registry tag check
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
1a9cb93551
Handling name of OCI file
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
23989f9e24
Updates to chart downloader
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
ba4020770e
Fix linting
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
4d50526a2b
Move OCI tag semver range logic from OCIGetter to ChartDownloader
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Matt Farina
c7b2a9d487
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Scott Rigby
1b3e0bc46a
Update oras-go to v1.1.0
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
9c3b000889
Fixed bad commit
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
828941b273
Readded resolver OCI logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
291c17fcc5
Enabled auth and support http registries for OCI
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
4c8a3faaa2
Fix import
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
1fabbabae9
Fix Trim to TrimPrefix
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
a8df413c41
Update ORAS to v1.1.0-rc1
...
Now that https://github.com/oras-project/oras-go/pull/89 is merged and released
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
Scott Rigby
39792b5ad0
Revert "It appears we never got to this block below. Quick rec by Farina. Untested if necessary"
...
This reverts commit f616a01808da3428c6191e5196f32ca72eb22254.
Removing for now until we know we need it.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
3dc9930488
Revert "hack in progress"
...
This reverts commit c0be414e4b8d2928018504c010cb04b1b2450bf3.
Taking a different approach, but keep this work in git history for now until we
know the new approach works.
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
16453c372c
It appears we never got to this block below. Quick rec by Farina. Untested if necessary
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
042e13d0d1
Temp use Andy's fork PR branch
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
0d2f0116ea
hack in progress
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
3072ce42d9
Merge pull request #10536 from zonggen/issue-10156
...
registry: change default registry config from `registry.json` to `registry/config.json`
3 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
Scott Rigby
46aa53ad22
Merge pull request #10521 from scottrigby/adopt-underscore-convention-for-semver-build-metadata
...
For OCI, convert + to _ before pull, and + to _ before push
3 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
Martin Hickey
292368a64d
Merge pull request #10209 from yxxhero/fix_sa_issue
...
Add more debug msg when helm upgrade
3 years ago
yxxhero
f82896b0b5
add more debug msg when helm upgrade
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
Matt Farina
ea5d7af200
Merge pull request #10535 from mattfarina/fix-10534
...
Fixing issue where OCI handling early causes a bad message
3 years ago
Matt Farina
d02f13c1bf
Merge pull request #10424 from davidxia/patch1
...
docs: Clarify use of --set-file
3 years ago
Matt Farina
ee73a0263c
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Martin Hickey
39ca699ca7
Merge pull request #9119 from ErmakovDmitriy/master
...
Added flag --list-repo
3 years ago
Bridget Kromhout
a30a8481b8
Adding Joe Julian as triage maintainer
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
Matt Farina
d9ffe37d37
Merge pull request #9536 from mengjiao-liu/add-install-validate
...
validate release name during install
3 years ago
Scott Rigby
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
Marc Khouzam
b8d3535991
feat(comp): Allow fuzzy matching during completion
...
We had made the assumption that when doing shell completion, we only
needed choices that had for *prefix* what the user had typed.
However, the zsh and fish shells have a more advanced matching system
which first matches on prefix, but if no match is found, then does
more advanced matching attempts, such as sub-strings; fish even matches
on descriptions of completions.
For example,
helm status nginx<tab>
would match releases such as
ingress-nginx
ingress-nginx-release
as long as no release had a prefix of "nginx".
Such fuzzy matching can make completion even more useful for users in
cases where identical prefixes are common.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
3 years ago
Matt Farina
66fb403804
Merge pull request #10490 from helm/dependabot/go_modules/github.com/docker/docker-20.10.12incompatible
...
chore(deps): bump github.com/docker/docker from 20.10.11+incompatible to 20.10.12+incompatible
3 years ago
mengjiao.liu
160da867d0
validate release name during install
...
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
3 years ago
Matthew Fisher
d3dbd65997
Merge pull request #10504 from jayonlau/clean_up
...
Clean up extra spaces
3 years ago