33183f6e2d
fix: seed parent.Values via MergeValues in regression tests
...
Populate parent.Values with MergeValues(parent, nil) to simulate the
state after processImportValues, so tests exercise the
childChartMergeTrue code path that was the actual source of the #32093
regression. Rename partial-override test to avoid duplication with
existing TestCoalesceValuesSubchartNilCleanedWhenUserPartiallyOverrides.
Signed-off-by: yxxhero <aiopsclub@163.com>
2 months ago
281552a64f
fix: clean subchart-default nils when parent sets any child value
...
In coalesceValues, childChartMergeTrue() was shadowing the merge
variable to true for child chart keys, which caused cleanNilValues(src)
to be skipped even during CoalesceValues (merge=false). This let nil
values from subchart defaults leak through when the parent chart
provided any user value under the subchart's namespace.
Fix by using a separate childMerge variable for childChartMergeTrue
so the original merge flag controls nil cleaning.
Fixes #32093
Signed-off-by: yxxhero <aiopsclub@163.com>
2 months ago
707afe4b22
Merge pull request #32094 from helm/dependabot/go_modules/main/github.com/Masterminds/semver/v3-3.5.0
...
chore(deps): bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0
3 months ago
e61bbfbfff
chore(deps): bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0
...
Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/Masterminds/semver/releases )
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Masterminds/semver/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
dependency-version: 3.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
ea10188070
Merge pull request #32090 from matheuscscp/cli-utils-1.2-c-r-0.24
...
Upgrade kstatus to 1.2 and controller-runtime to 0.24
3 months ago
081c6dff53
Upgrade kstatus to 1.2 and controller-runtime to 0.24
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
96c152cb1a
Merge pull request #31923 from gaganhr94/fix/token-permissions
...
fix: adds topLevel permissions to improve openSSF scores
3 months ago
38f3704983
Merge pull request #32034 from cairon-ab/fix/pull-debug-output
...
fix: add debug logging to HTTP getter for helm pull
3 months ago
277d970255
fix: adds topLevel permissions to improve openSSF scores
...
Signed-off-by: Gagan H R <hrgagan4@gmail.com>
3 months ago
fbc2791886
Merge pull request #32078 from matheuscscp/go-1.26-k8s-1.36-cli-utils-1.1
...
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
3 months ago
2fb101a20b
Merge pull request #31755 from scottrigby/template-cmd-deprecate-notes-flags
...
fix(template): deprecate unused --hide-notes and --render-subchart-notes flags
3 months ago
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
3 months ago
8f56f24d63
fix(templating): hooks conflicting with templates in post-renderers ( #32049 )
...
* fix(templating): hooks conflicting with templates in post-renderers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* fix(templating): allow disabling hooks from postrenderers entirely
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
29d309e56b
Merge pull request #31981 from abhay1999/fix/ssa-error-context
...
fix(kube): clarify server-side apply patch errors
3 months ago
66e5049405
Merge pull request #32008 from rhysmcneill/bugfix/helm-upgrade-err-variable-defect
...
fix(action): return correct error variable in prepareUpgrade
3 months ago
1d6469cfcb
Merge pull request #32057 from MohitSalvi16/docs/fix-contributing-typos
...
docs: fix grammar and spacing in CONTRIBUTING.md
3 months ago
db40adb1d1
docs: fix grammar and spacing in CONTRIBUTING.md
...
Signed-off-by: Mohit <salvimohit08@gmail.com>
3 months ago
20eae2bb0f
Merge pull request #32052 from helm/dependabot/go_modules/main/k8s-io-dc9379caa6
...
chore(deps): bump the k8s-io group across 1 directory with 7 updates
3 months ago
775e794319
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.35.3` | `0.35.4` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.35.3` | `0.35.4` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.35.3` | `0.35.4` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.35.3` | `0.35.4` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.35.3` | `0.35.4` |
Updates `k8s.io/api` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/api/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiextensions-apiserver` from 0.35.3 to 0.35.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apimachinery` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/apiserver` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/cli-runtime` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/client-go` from 0.35.3 to 0.35.4
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.3...v0.35.4 )
Updates `k8s.io/kubectl` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.35.3...v0.35.4 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
83a4611908
Merge pull request #12932 from AndiDog/error-message
...
Make error message instructional for the case of lock file being out of date
3 months ago
354c85d6a4
Merge pull request #32050 from helm/dependabot/github_actions/main/github/codeql-action-4.35.2
...
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
3 months ago
934ace35df
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.35.1 to 4.35.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c10b8064de...95e58e9a2c
3 months ago
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
c51456c45d
Merge pull request #31979 from Y0-L0/jlohmer/coalesce-nil
...
Jlohmer/coalesce nil
3 months ago
1c007051ae
Merge pull request #32045 from helm/dependabot/go_modules/main/github.com/mattn/go-shellwords-1.0.13
...
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
3 months ago
48e2b7ddd4
chore(deps): bump github.com/mattn/go-shellwords from 1.0.12 to 1.0.13
...
Bumps [github.com/mattn/go-shellwords](https://github.com/mattn/go-shellwords ) from 1.0.12 to 1.0.13.
- [Commits](https://github.com/mattn/go-shellwords/compare/v1.0.12...v1.0.13 )
---
updated-dependencies:
- dependency-name: github.com/mattn/go-shellwords
dependency-version: 1.0.13
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
a8e249714f
Update pkg/chart/common/util/coalesce.go
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
52fc971da3
test(values): Add test for nil cleanup in partially overridden subchart maps
...
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
3 months ago
00638773d1
fix(values): do not copy chart-default nils into coalesced values
...
Only user-supplied nils should survive coalescing. Chart-default nils
defaults, not just user overrides. This caused:
- %!s(<nil>) in templates using Bitnami common.secrets.key (#31919 )
- pluck fallbacks returning nil instead of falling through to globals
(#31971 )
Fixes #31919
Fixes #31971
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
3 months ago
6eb4ebf0e1
test(values): add test for subchart nil producing %!s(<nil>)
...
Regression test for the Bitnami common.secrets.key issue.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
3 months ago
5cb4e7d992
test(values): add tests for subchart nil value regressions
...
Three test cases that cover the regression scenarios introduced
by the #31644 nil preservation fix:
- subchart default nils should be cleaned up
when parent doesn't set those keys (#31919 )
- user-supplied null should erase subchart defaults (#31919 )
- subchart default nil should not shadow global values via pluck (#31971 )
Tests are expected to fail until the regression is fixed.
Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
3 months ago
1164a5fbda
Merge pull request #32037 from helm/dependabot/github_actions/main/actions/upload-artifact-7.0.1
...
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
3 months ago
bd061e0cd7
Merge pull request #32016 from TerryHowe/fix/flaky-waitfordelete-timeout
...
test(kube): fix flaky WaitForDelete timing in status wait tests
3 months ago
b5c7c80de3
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](bbbca2ddaa...043fb46d1a
3 months ago
a27f1add79
fix(templating): fix wrong YAML separator parsing for post-renderers ( #31941 )
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
c26be60d81
fix: add debug logging to HTTP getter for helm pull
...
When running 'helm pull --debug', no debug output was printed because
the HTTP getter did not emit any slog.Debug messages. This adds
slog.Debug calls to log the URL being fetched and the response status
when debug-level logging is enabled.
Fixes helm/helm#31098
Signed-off-by: Cairon <cairon-ab@users.noreply.github.com>
3 months ago
cf69a6ef70
Merge pull request #32030 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.50.0
...
chore(deps): bump golang.org/x/crypto from 0.49.0 to 0.50.0
3 months ago
38213a9548
Merge pull request #32000 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.3
...
chore(deps): bump github.com/lib/pq from 1.12.2 to 1.12.3
3 months ago
ed7c3e47a9
Merge pull request #32028 from gjenkins8/gjenkins/release_notes_v4
...
chore: Update release notes script for Helm v4
3 months ago
953f5f031b
chore(deps): bump golang.org/x/crypto from 0.49.0 to 0.50.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.49.0 to 0.50.0.
- [Commits](https://github.com/golang/crypto/compare/v0.49.0...v0.50.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.50.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
79493bc6a8
Merge pull request #32031 from helm/dependabot/go_modules/main/golang.org/x/term-0.42.0
...
chore(deps): bump golang.org/x/term from 0.41.0 to 0.42.0
3 months ago
10fc5f335b
chore(deps): bump golang.org/x/term from 0.41.0 to 0.42.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.41.0 to 0.42.0.
- [Commits](https://github.com/golang/term/compare/v0.41.0...v0.42.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.42.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
36030c947b
Merge pull request #32029 from helm/dependabot/go_modules/main/golang.org/x/text-0.36.0
...
chore(deps): bump golang.org/x/text from 0.35.0 to 0.36.0
3 months ago
d89e7c6076
chore(deps): bump golang.org/x/text from 0.35.0 to 0.36.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.35.0 to 0.36.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.35.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.36.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
8a95461925
chore: Update release notes script for Helm v4
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
be5aaf7e34
Merge pull request #32024 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-1.0.0
...
chore(deps): bump github.com/fluxcd/cli-utils from 0.37.2-flux.1 to 1.0.0
3 months ago
bd5027a9cf
chore(deps): bump github.com/lib/pq from 1.12.2 to 1.12.3
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.12.2 to 1.12.3.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.12.2...v1.12.3 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.12.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
fa194a0609
Merge pull request #32025 from gjenkins8/gjenkins/fix_lint
...
fix: unnecessary-format lint issues from merge
3 months ago
087736b66e
fix: unnecessary-format lint issues from merge
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
yxxhero
Terry Howe
dependabot[bot]
Matheus Pimenta
Gagan H R
George Jenkins
Mohit
Evans Mungai
Johannes Lohmer
Johannes Lohmer
Cairon
Robert Sirchia