915 Commits (2b239b84e445a85807fc851d261e6ae9999d364d)

Author	SHA1	Message	Date
Terry Howe	59b57c5c31	Merge pull request #31885 from mmorel-35/whitespace ... chore: fix whitespace linter	2 months ago
Matthieu MOREL	488c4a805d	Fix empty and len testifylint violations across test files ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 months ago
Evans Mungai	d374e823b2	Merge pull request #32086 from mmorel-35/error-is-as ... testifylint: enable error-is-as and error-nil rules	2 months ago
MrJack	291a1a3b26	Merge branch 'helm:main' into feature/rollback-revision-history	3 months ago
Gregory Man	1a1ec6e3cc	fix: skip non-Pod test hooks in GetPodLogs ... Before this change, hooks with `helm.sh/hook: test` but Kind != Pod (ConfigMap, Secret, ...) led to `helm test --logs` fail with `unable to get pod <name>`. Signed-off-by: Gregory Man <man.gregory@gmail.com>	3 months ago
box4wangjing	432fc8a217	refactor: use slices.Backward to simplify the code ... Signed-off-by: box4wangjing <box4wangjing@outlook.com>	3 months ago
Evans Mungai	03a65a71f7	Fix lint errors ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	3 months ago
Evans Mungai	007713087b	fix: address Copilot review on ownership-verified uninstall ... - Distinguish unowned resources from those whose ownership could not be verified (e.g. RBAC/network errors). Unverifiable resources are now returned in a separate list with the underlying error so log output and the "kept" summary describe what actually happened. - Only prefix the kept summary with the resource-policy header when there are policy-kept resources, so users with only ownership-skipped resources don't see a misleading header. - Update verifyOwnershipBeforeDelete doc comment to reflect that not-found resources are excluded from all returned lists. - Assert success of Releases.Create in uninstall tests so fixture setup failures are surfaced immediately. Signed-off-by: Evans Mungai <mbuevans@gmail.com>	3 months ago
Evans Mungai	9728c5af31	Potential fix for pull request finding ... Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Evans Mungai <mbuevans@gmail.com>	3 months ago
Evans Mungai	ed5789cbda	Merge remote-tracking branch 'origin/main' into em/check-ownership-before-delete	3 months ago
Sebastien Tardif	922558fc1a	fix: address review feedback ... - Close log stream after reading (prevents connection/fd leak) - Strengthen tests to assert on output headers rather than error paths - Remove unused import Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>	3 months ago
Sebastien Tardif	854f7f6b72	fix: fetch logs from all containers in test pods ... When a test pod contains multiple containers (e.g. Istio/Consul/Vault sidecars), 'helm test --logs' failed with 'a container name must be specified'. This happened because GetPodLogs called the Kubernetes log API without specifying a container name. The fix fetches the pod spec first, then iterates over all containers (init containers + regular containers) and requests logs for each one explicitly. Errors from individual containers are collected and returned together via errors.Join rather than aborting on the first failure. Also fixes a typo: hooksByWight -> hooksByWeight. Closes #6902 Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>	3 months ago
MrJack	dc04059ea3	Merge branch 'helm:main' into feature/rollback-revision-history	3 months ago
Matthieu MOREL	f8ba28bb17	testifylint: enable error-is-as and error-nil rules ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	3 months ago
George Jenkins	4bd9e90aa0	Merge pull request #30811 from mmorel-35/testifylint ... chore: fix bool-compare issues from testifylint	3 months ago
Matheus Pimenta	8f56f24d63	fix(templating): hooks conflicting with templates in post-renderers (#32049) ... * fix(templating): hooks conflicting with templates in post-renderers Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> * fix(templating): allow disabling hooks from postrenderers entirely Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> --------- Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	4 months ago
MrJack	3838d2d2dd	Merge branch 'helm:main' into feature/rollback-revision-history	4 months ago
George Jenkins	66e5049405	Merge pull request #32008 from rhysmcneill/bugfix/helm-upgrade-err-variable-defect ... fix(action): return correct error variable in prepareUpgrade	4 months ago
Matheus Pimenta	265c5eb530	fix(templating): SplitManifests must preserve line endings for downstream YAML parsers (#31952) ... * fix(templating): SplitManifests must preserve line endings for downstream YAML parsers Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> * Address copilot comment about skipping empty docs Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> * Port fix to release v2 Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> * Address copilot comments Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> --------- Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	4 months ago
MrJack	16c6662566	Merge branch 'helm:main' into feature/rollback-revision-history	4 months ago
Matheus Pimenta	a27f1add79	fix(templating): fix wrong YAML separator parsing for post-renderers (#31941) ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	4 months ago
Rhys McNeill	8ef2d45934	fix(action): return correct error variable in prepareUpgrade ... When Deployed() succeeds but releaserToV1Release() fails, prepareUpgrade returned err (nil) instead of cerr (the conversion error), causing a silent nil return that could lead to nil pointer dereferences downstream. Closes #32007 Signed-off-by: Rhys McNeill <rhysmcneill7@hotmail.co.uk>	4 months ago
MrJack	42db90d9e8	Merge branch 'helm:main' into feature/rollback-revision-history	4 months ago
Matthieu MOREL	7edfff33eb	chore: fix unnecessary-format issues from revive ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	071558d69f	chore: fix bool-compare issues from testifylint ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	af31a67924	chore: enable errorlint linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	1e0f702f00	chore: fix whitespace linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
George Jenkins	42f78ba60e	Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3 ... chore(pkg): fix perfsprint linter issues part 6	5 months ago
George Jenkins	e3b4808450	Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58 ... chore(pkg): fix perfsprint linter issues part 4	5 months ago
George Jenkins	610547b570	Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250 ... chore(pkg): fix perfsprint linter issues part 5	5 months ago
MrJack	a753caca76	Merge branch 'helm:main' into feature/rollback-revision-history	5 months ago
Terry Howe	3e7b38fd04	Merge pull request #31868 from matheuscscp/fix-31867 ... fix: insert newline after doc separators glued to content by template trimming	5 months ago
Matheus Pimenta	af94abf976	fix: insert newline after doc separators glued to content by template trimming ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	5 months ago
MrJack	643e6d581d	Merge branch 'helm:main' into feature/rollback-revision-history	5 months ago
George Jenkins	df8e0301ed	Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f ... chore(pkg): fix perfsprint linter issues part 3	5 months ago
George Jenkins	4f9f18c453	Merge pull request #31875 from mmorel-35/perfsprint-pkg-2-0e1acbc ... chore(pkg): fix perfsprint linter issues part 2	5 months ago
George Jenkins	c4392033cc	Merge pull request #31853 from atombrella/feature/fmt_unneeded ... Replace non-format use of t.Fatalf with t.Fatal	5 months ago
Matthieu MOREL	dc0e3f10c3	chore(pkg): fix perfsprint linter issues part 6 ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	1d2d63cc43	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	63f03c0f5c	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/action Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	c25c988cfb	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/registry Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	0fecfd04c2	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	6c2cb2f547	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Mads Jensen	36cb3a2fe9	Replace unneeded use of t.Fatalf with t.Fatal ... Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	5 months ago
George Jenkins	be7cdb69e5	Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a ... fix(pkg): errorlint linter	5 months ago
George Jenkins	3dfc4f3cf6	Merge pull request #31858 from helm/gjenkins/go_fix ... chore: `go fix` fixes	5 months ago
MrJack	300f71b1eb	feat(history): add rollback revision column to helm history output ... Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>	5 months ago
George Jenkins	3ad9ccdb19	Merge pull request #31563 from Mujib-Ahasan/dry-run-fix ... fix: --dry-run=server now respect generateName	5 months ago
George Jenkins	92b64e87ad	chore: fixes ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	5 months ago
Joe Julian	947b429cdd	Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248 ... chore(pkg): fix modernize linter	6 months ago
Joe Julian	78f5af72be	Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb ... chore(pkg): fix modernize linter	6 months ago
Joe Julian	70899a6b3f	Merge pull request #31578 from manute/main ... fix(action): crd resources can be empty	6 months ago
Joe Julian	56d0d9374a	Merge pull request #31810 from mmorel-35/errorlint-pkg-5-dda0145 ... fix(pkg): errorlint linter	6 months ago
Matthieu MOREL	259f76a849	fix(pkg): errorlint linter ... errorlint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	4d0ae7f33a	fix(pkg): errorlint linter ... #### Description errorlint linter in pkg Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	c8989d984f	fix(pkg): errorlint linter ... #### Description errorlint linter in pkg Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Manuel Alonso	9817a68618	fix(install): check nil for restClientGetter and fix tests ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	6 months ago
Matthieu MOREL	5cc2e55714	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/chart/v2/lint/rules Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	111d4e6e0e	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/chart/common/util Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matheus Pimenta	c1cc625323	chore(defaults): server-side apply SDK defaults should always match the CLI defaults ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	7 months ago
Manuel Alonso	7c089bed26	Merge branch 'main' into main ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Manuel Alonso	6501ef490a	chore(refactor): better testing and functionality for installing crd ... Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>	7 months ago
Matheus Pimenta	59ece92bed	pkg/kube: introduce support for custom kstatus readers ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	7 months ago
Manuel Alonso	0f949a92c1	fix(test): fix tests and check nil for restclient ... Signed-off-by: Manuel Alonso <m.alonso@Manuels-MacBook-Pro.local>	7 months ago
Manuel Alonso Gonzalez	561410ae1d	fix(test): merge fix correctly ... Signed-off-by: Manuel Alonso Gonzalez <434575+manute@users.noreply.github.com> Signed-off-by: Manuel Alonso Gonzalez <m.alonso@Manuels-MacBook-Pro.local>	7 months ago
Evans Mungai	e751a70e84	fix(release): fix test compilation error ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	7 months ago
Evans Mungai	05f25a3834	Merge pull request #31579 from benoittgt/delete-hook-after-log-retrieval ... fix: Delay test hook deletion until after logs are retrieved with `helm test release --logs`	7 months ago
Manuel Alonso	df8ec771f9	Merge branch 'main' into main ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Evans Mungai	03b535d6b7	Merge branch 'main' into em/check-ownership-before-delete ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	7 months ago
George Jenkins	fa41d60d73	Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg ... Add tests to action package to improve coverage	7 months ago
Manuel Alonso	00f0a48a7d	fix(install): add more tests and check nil file data ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Manuel Alonso	0357e8d0f7	fix(test): no check empty resources ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Manuel Alonso	52235cc0bf	fix(install): check lenght and file nil, add tests ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Manuel Alonso	268593bf2e	fix(action): crd resources can be empty ... Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>	7 months ago
Mujib Ahasan	170911459b	fix: casing issue fixed ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
Mujib Ahasan	94860626ce	fix: error handled correctly ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
Mujib Ahasan	12e8b715aa	fix: doc string added ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
Terry Howe	5d2ab10caa	Merge pull request #12564 from hiddeco/supersede-on-uninstall ... fix(uninstall): supersede deployed releases	8 months ago
Terry Howe	2597088a20	Merge pull request #31586 from calvinbui/main ... fix: use length check for MetaDependencies instead of nil comparison	8 months ago
Robert Sirchia	4cf7d8d025	Merge pull request #31641 from wangjingcun/main ... chore: fix some comments to improve readability	8 months ago
Terry Howe	d28853e206	Merge pull request #31624 from atombrella/feature/sloglint ... Enable the `sloglint` linter	8 months ago
wangjingcun	858cf31583	chore: fix some comments to improve readability ... Signed-off-by: wangjingcun <wangjingcun@aliyun.com>	8 months ago
Mads Jensen	a18e59e465	Enable the sloglint linter ... Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	8 months ago
George Jenkins	3165e5463a	Merge pull request #31528 from benoittgt/31423-git-version ... fix: preserve vendor suffixes in KubeVersion.GitVersion	8 months ago
Stephanie Hohenberg	a109ac2f06	fixes comment in install.go ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	8 months ago
Stephanie Hohenberg	2f598ffc85	fixes tests after merge ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	8 months ago
Stephanie Hohenberg	bb9356e182	fixes lint issue ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	8 months ago
Stephanie Hohenberg	8cf4ad73c3	updates tests after rebase from master ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	8 months ago
Stephanie Hohenberg	31131cff9b	Add tests to action package to improve coverage ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	8 months ago
Mujib Ahasan	115409976b	update: test coverage added for helper function validateNameAndGenerateName ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
Mujib Ahasan	522d2fe615	update: helper function added for the business logic ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
George Jenkins	dfa1e3c3c5	Merge pull request #31562 from atombrella/feature/modernize ... Use modernize to use newer Golang features.	8 months ago
Evans Mungai	f552950b05	Add ownership verification to uninstall action ... This commit adds ownership verification to the uninstall action. It checks that the resource to be deleted is owned by the chart before deleting it. Fixes: #31333 Signed-off-by: Evans Mungai <mbuevans@gmail.com>	8 months ago
Benoit Tigeot	45c5f3aaca	Deal with golint warning with private executeShutdownFunc ... ``` Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive) func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) { ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	8 months ago
Calvin Bui	b33d4ae0c0	Use length check for MetaDependencies instead of nil comparison ... Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>	8 months ago
Benoit Tigeot	70fc5f97e2	Code review ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	8 months ago
Evans Mungai	6d5b5aab32	Additional logging for ownership verification in dry-run mode ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	8 months ago
Evans Mungai	906f87ce1d	feat: add ownership verification before deleting resources during uninstall ... Fixes #31333 Helm uninstall now verifies resource ownership before deletion by checking Helm labels and annotations. Resources not owned by the release being uninstalled are skipped with warnings, preventing accidental deletion of resources belonging to other releases. Signed-off-by: Evans Mungai <mbuevans@gmail.com>	8 months ago
Mujib Ahasan	6769fb6fb6	generateName is also considered in logic ... Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>	8 months ago
Michelle Fernandez Bieber	6bb5bcc212	Update pkg/action/hooks.go ... Co-authored-by: Marco Lecheler <marco@task.media> Signed-off-by: Michelle Fernandez Bieber <37021266+mfbieber@users.noreply.github.com>	8 months ago