abhay1999
bec935df41
remove legacy import comments from remaining packages
...
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.
Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver
Follows up on #31931 and #31932 which addressed pkg/kube.
Fixes #31846
Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2 weeks ago
tsinglua
259f181808
chore: fix some minor issues in the comments
...
Signed-off-by: tsinglua <tsinglua@outlook.com>
2 weeks ago
George Jenkins
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
...
Replace non-format use of t.Fatalf with t.Fatal
3 weeks ago
Matthieu MOREL
d4f6193a7e
chore(internal): enable perfsprint linter ( #31871 )
...
#### Description
enable perfsprint linter in internal/plugin
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
9409226e15
chore(internal): enable perfsprint linter
...
#### Description
enable perfsprint linter in internal/plugin/installer
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Mads Jensen
36cb3a2fe9
Replace unneeded use of t.Fatalf with t.Fatal
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
4 weeks ago
Matthieu MOREL
5b6c6bbfc7
fix: enable nolinlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
George Jenkins
bc43812115
Merge pull request #31807 from mmorel-35/errorlint-internal-3-48c7a5a
...
fix(internal): errorlint linter
4 weeks ago
Matthieu MOREL
025418291a
fix(internal): errorlint linter
...
errorlint linter in internal/third_party/dep/fs
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
Matthieu MOREL
abecafa0f5
fix(internal): errorlint linter
...
#### Description
errorlint linter in internal
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
Terry Howe
429ce93848
Merge pull request #31613 from aslafy-z/feat/getter-env
...
fix(getter): pass settings environment variables
3 months ago
Gergely Brautigam
138f730aac
fix: typo in the function names
...
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
3 months ago
Mads Jensen
a490bb3c20
Use errors.Is to check for io.EOF and gzip.ErrHeader
...
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
3 months ago
Terry Howe
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
3 months ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
3 months ago
Terry Howe
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
3 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
4 months ago
Zadkiel AHARONIAN
119341dca7
fix(getter): pass settings environment variables
...
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
4 months ago
Scott Rigby
4d54bea5ff
Merge pull request #31491 from benoittgt/31490-plugin-name-helper
...
feat: improve plugin name validation error messages and field name detection (v1)
4 months ago
Benoit Tigeot
71591ee63e
style: linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
b296cbef6c
test: split tests between valid and invalid
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
9b242dd9ed
test: convert tests to table drive tests
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
c81a09b89a
test: refactor TestMetadataLegacyValidate to be more generic
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
yxxhero
8c87024860
update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 months ago
yxxhero
2d49f0cb4a
Refactor environment variable expansion in PrepareCommands and update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 months ago
Benoit Tigeot
acf331a005
fix: improve plugin name validation err messages early via unmarshalling
...
- Add strict YAML unmarshalling for v1 plugins (d.KnownFields)
- Add comprehensive test coverage for validPluginName regex
- Maintain backwards compatibility for legacy plugins
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
9e1e3d21c5
fix: Make invalid name error message more similar and move tests
...
Follow Scott comment\
https://github.com/helm/helm/pull/31491/files#r2524933784
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
cf077ceb27
fix: focus only on plugin name but give more info about what we get
...
And improve test
Follow Scott comment:
> here I would have a list of valid and invalid names based on pattern, with a check and intended outcome for each one so that we comprehensively cover the rules.
https://github.com/helm/helm/pull/31491/files#r2524820312
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
f4b139a82c
Make validation error similar and explicit for both metadatas
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
c04e18e452
fix: improve plugin name validation error messages
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Matt Farina
a3db5f5667
Merge pull request #31408 from AndiDog/plugin-err-msg
...
Improve error message when plugin source cannot be determined or a non-directory is passed
5 months ago
Matt Farina
97ee09d935
Merge pull request #31365 from reddaisyy/main
...
refactor: use reflect.TypeFor
5 months ago
Andreas Sommer
b05411506a
Improve error message when plugin source cannot be determined or a non-directory is passed
...
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
5 months ago
wyrapeseed
b9eadd3186
chore: fix some comment format
...
Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>
5 months ago
reddaisyy
e69a12dad3
refactor: use reflect.TypeFor
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
6 months ago
George Jenkins
a7a6a5e3b0
Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
...
Remove unused 'Settings' from plugin schema
6 months ago
George Jenkins
93c02523bb
Merge pull request #31249 from banjoh/em/additional-logging
...
chore: add additional logging to plugin installer
6 months ago
George Jenkins
900cf2a93d
Merge pull request #31320 from kosiew/sign-31181
...
provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)
6 months ago
juejinyuxitu
69dbd6115e
chore: fix some typos in comment
...
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
6 months ago
Siew Kam Onn
7c9176ae35
Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
6 months ago
George Jenkins
6bc6231bcc
Remove unused 'Settings' from plugin schema
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
zyfy29
b24bfe4168
Merge branch 'main' into delete-unused-var
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
6 months ago
Tom Wieczorek
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
6 months ago
yajianggroup
cfaf30083a
refactor: use strings.CutPrefix
...
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
6 months ago
Evans Mungai
3d23230ef8
chore: add additional logging to plugin installer
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
7 months ago
George Jenkins
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
665c5a1fc9
Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value
...
fix: Adjust PostRenderer plugin output to value
7 months ago
George Jenkins
d99d732542
fix: Adjust PostRenderer plugin output to value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago